The shared Mbed TLS heap feature has a default implementation (weak
function) that will soon be removed: plat_get_mbedtls_heap(). This is
part of the general effort to avoid using weak functions in generic
code. As a result, the implementation of this function becomes mandatory
when supporting Trusted Board Boot.
The corresponding patch can be found here:
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/841
The fact that the implementation of plat_get_mbedtls_heap() becomes
mandatory will break compatibility with platforms not implementing a
strong version of the function.
Upstream platforms are taken care of in the above patch.
Downstream platforms will break, but it is easy to fix.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Hi Abel,
Thanks for the RFC. On the face of it, this is a new PSCI command that would need further discussion involving Architecture and Kernel teams.
Just to summarize my understanding:
Currently any interrupt targeted to a suspended core can wake it up, but it seems that this mechanism is broken on i.MX8MQ and hence you need an explicit command to wake it. This assumes that one CPU is always ON within the system ready to poke the suspended CPU back to life. This assumption is not true always as it is legal for all the CPUs to be in suspend state at the same time.
Adding the kernel team for their input.
JFYI, We do not intend to review patches via the mailing list and patches should be pushed as mentioned here:
https://github.com/ARM-software/arm-trusted-firmware/blob/master/contributi…
Currently the project is in github but we expect to migrate to trustedfirmware.org in April.
Best Regards
Soby Mathew
> -----Original Message-----
> From: TF-A <tf-a-bounces(a)lists.trustedfirmware.org> On Behalf Of Abel Vesa
> via TF-A
> Sent: 27 March 2019 12:16
> To: tf-a(a)lists.trustedfirmware.org
> Subject: [TF-A] [RFC 0/2] psci: Add core wakeup operation
>
> This is more like a workaround for platforms like i.MX8MQ that have an issue
> related to the wake_request GIC signal integration.
>
> See E11171 here:
> https://www.nxp.com/docs/en/errata/IMX8MDQLQ_0N14W.pdf
>
> The workaround mentioned in the document has the dissadvantage of waking
> up all the sleeping cores instead of just one.
>
> This patchset adds another psci op for core 'poking' (waking up).
> On i.MX8MQ, the plat specific implementation writes the corresponding bits in
> GPC to wake up independently each core.
>
> Abel Vesa (2):
> psci: Add cpu wake operation
> plat: imx8mq: Trigger SW power up per core
>
> include/lib/psci/psci.h | 3 +++
> lib/psci/psci_main.c | 17 +++++++++++++++++
> lib/psci/psci_setup.c | 2 ++
> plat/imx/imx8m/imx8mq/gpc.c | 7 +++++++
> plat/imx/imx8m/imx8mq/imx8mq_psci.c | 8 ++++++++
> plat/imx/imx8m/include/gpc.h | 2 ++
> 6 files changed, 39 insertions(+)
>
> --
> 2.7.4
>
> --
> TF-A mailing list
> TF-A(a)lists.trustedfirmware.org
> https://lists.trustedfirmware.org/mailman/listinfo/tf-a
This is more like a workaround for platforms like i.MX8MQ that have
an issue related to the wake_request GIC signal integration.
See E11171 here: https://www.nxp.com/docs/en/errata/IMX8MDQLQ_0N14W.pdf
The workaround mentioned in the document has the dissadvantage of waking
up all the sleeping cores instead of just one.
This patchset adds another psci op for core 'poking' (waking up).
On i.MX8MQ, the plat specific implementation writes the corresponding
bits in GPC to wake up independently each core.
Abel Vesa (2):
psci: Add cpu wake operation
plat: imx8mq: Trigger SW power up per core
include/lib/psci/psci.h | 3 +++
lib/psci/psci_main.c | 17 +++++++++++++++++
lib/psci/psci_setup.c | 2 ++
plat/imx/imx8m/imx8mq/gpc.c | 7 +++++++
plat/imx/imx8m/imx8mq/imx8mq_psci.c | 8 ++++++++
plat/imx/imx8m/include/gpc.h | 2 ++
6 files changed, 39 insertions(+)
--
2.7.4
Test reply.
On 06/02/2019, 12:55, "TF-A on behalf of John Tsichritzis via TF-A" <tf-a-bounces(a)lists.trustedfirmware.org on behalf of tf-a(a)lists.trustedfirmware.org> wrote:
Dear all,
This is a test email. Please ignore it and sorry for the inconvenience.
Kind regards,
John
--
[cid:part1.F2AC7E65.FED3DCD0@arm.com] <https://www.arm.com/>
John Tsichritzis | Graduate Software Engineer
Email : john.tsichritzis(a)arm.com<mailto:john.tsichritzis@arm.com>
110 Fulbourn Road, Cambridge, CB1 9NJ, United Kingdom
--
TF-A mailing list
TF-A(a)lists.trustedfirmware.org
https://lists.trustedfirmware.org/mailman/listinfo/tf-a
Dear all,
This is a test email. Please ignore it and sorry for the inconvenience.
Kind regards,
John
--
[cid:part1.F2AC7E65.FED3DCD0@arm.com] <https://www.arm.com/>
John Tsichritzis | Graduate Software Engineer
Email : john.tsichritzis(a)arm.com<mailto:john.tsichritzis@arm.com>
110 Fulbourn Road, Cambridge, CB1 9NJ, United Kingdom
> Has CMAKE been considered ? CMAKE should work equally well on
> windows(visual studio and Cygwin) and linux. You can create a new build
> system around CMAKE while keeping the current Makefile system alive, and
> deprecate it later, once the CMAKE based build system is stable.
>
> -Raghu
Thanks for the suggestion.
Does CMAKE support configuration system as well ? Another factor to consider is the familiarity of the build system with the community, and we think Kbuild would rank high on that.
Best Regards
Soby Mathew
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Has CMAKE been considered ? CMAKE should work equally well on windows(visual studio and Cygwin) and linux. You can create a new build system around CMAKE while keeping the current Makefile system alive, and deprecate it later, once the CMAKE based build system is stable.
-Raghu
On Dec 13, 2018, at 04:00 AM, tf-a-request(a)lists.trustedfirmware.org wrote:
Send TF-A mailing list submissions to
tf-a(a)lists.trustedfirmware.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.trustedfirmware.org/mailman/listinfo/tf-a
or, via email, send a message with subject or body 'help' to
tf-a-request(a)lists.trustedfirmware.org
You can reach the person managing the list at
tf-a-owner(a)lists.trustedfirmware.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of TF-A digest..."
Today's Topics:
1. New build system based on Kconfig/Kbuild (Antonio Nino Diaz)
2. Re: New build system based on Kconfig/Kbuild (Antonio Nino Diaz)
----------------------------------------------------------------------
Message: 1
Date: Wed, 12 Dec 2018 15:50:15 +0000
From: Antonio Nino Diaz <Antonio.NinoDiaz(a)arm.com>
To: "tf-a(a)lists.trustedfirmware.org" <tf-a(a)lists.trustedfirmware.org>
Subject: [Tf-a] New build system based on Kconfig/Kbuild
Message-ID:
<DB6PR0801MB1943C8DAE7D0574D1C6E15BD89A70(a)DB6PR0801MB1943.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
Hello,
One of the biggest issues that the current codebase of TF-A has is the build
system. It is unfit for the amount of options and dependencies of said options,
and adding new features is now an effort of trying to add the new feature while
not breaking the rest of the code.
There is another problem. When the firmware is compiled with, say, OPTION=1, if
it is recompiled with OPTION=0 without cleaning first, nothing will be rebuilt.
We have had several discussions about this internally and we have decided to
migrate to Kbuild/Kconfig, the build system used by the Linux kernel. There are
already some projects using it, like U-Boot or Zephyr RTOS.
We are starting the work related to this migration, and our intention is to
migrate upstream platforms to this new build system.
However, this change means that:
- All non-upstream platforms will break until they update their makefiles.
- Compilation under Windows won't be possible anymore without Cygwin or MinGW.
We're open to comments.
Regards,
Antonio
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
------------------------------
Message: 2
Date: Wed, 12 Dec 2018 15:54:30 +0000
From: Antonio Nino Diaz <Antonio.NinoDiaz(a)arm.com>
To: Antonio Nino Diaz <Antonio.NinoDiaz(a)arm.com>,
"tf-a(a)lists.trustedfirmware.org" <tf-a(a)lists.trustedfirmware.org>
Cc: nd <nd(a)arm.com>
Subject: Re: [Tf-a] New build system based on Kconfig/Kbuild
Message-ID:
<DB6PR0801MB1943F0BC699C1B37A8787C2889A70(a)DB6PR0801MB1943.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset="us-ascii"
Please, ignore the confidentiality notice.
________________________________
From: TF-A <tf-a-bounces(a)lists.trustedfirmware.org> on behalf of Antonio Nino Diaz via TF-A <tf-a(a)lists.trustedfirmware.org>
Sent: 12 December 2018 15:50:24
To: tf-a(a)lists.trustedfirmware.org
Subject: [Tf-a] New build system based on Kconfig/Kbuild
Hello,
One of the biggest issues that the current codebase of TF-A has is the build
system. It is unfit for the amount of options and dependencies of said options,
and adding new features is now an effort of trying to add the new feature while
not breaking the rest of the code.
There is another problem. When the firmware is compiled with, say, OPTION=1, if
it is recompiled with OPTION=0 without cleaning first, nothing will be rebuilt.
We have had several discussions about this internally and we have decided to
migrate to Kbuild/Kconfig, the build system used by the Linux kernel. There are
already some projects using it, like U-Boot or Zephyr RTOS.
We are starting the work related to this migration, and our intention is to
migrate upstream platforms to this new build system.
However, this change means that:
- All non-upstream platforms will break until they update their makefiles.
- Compilation under Windows won't be possible anymore without Cygwin or MinGW.
We're open to comments.
Regards,
Antonio
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
--
TF-A mailing list
TF-A(a)lists.trustedfirmware.org
https://lists.trustedfirmware.org/mailman/listinfo/tf-a
------------------------------
Subject: Digest Footer
TF-A mailing list
TF-A(a)lists.trustedfirmware.org
https://lists.trustedfirmware.org/mailman/listinfo/tf-a
------------------------------
End of TF-A Digest, Vol 1, Issue 1
**********************************
Please, ignore the confidentiality notice.
________________________________
From: TF-A <tf-a-bounces(a)lists.trustedfirmware.org> on behalf of Antonio Nino Diaz via TF-A <tf-a(a)lists.trustedfirmware.org>
Sent: 12 December 2018 15:50:24
To: tf-a(a)lists.trustedfirmware.org
Subject: [Tf-a] New build system based on Kconfig/Kbuild
Hello,
One of the biggest issues that the current codebase of TF-A has is the build
system. It is unfit for the amount of options and dependencies of said options,
and adding new features is now an effort of trying to add the new feature while
not breaking the rest of the code.
There is another problem. When the firmware is compiled with, say, OPTION=1, if
it is recompiled with OPTION=0 without cleaning first, nothing will be rebuilt.
We have had several discussions about this internally and we have decided to
migrate to Kbuild/Kconfig, the build system used by the Linux kernel. There are
already some projects using it, like U-Boot or Zephyr RTOS.
We are starting the work related to this migration, and our intention is to
migrate upstream platforms to this new build system.
However, this change means that:
- All non-upstream platforms will break until they update their makefiles.
- Compilation under Windows won't be possible anymore without Cygwin or MinGW.
We're open to comments.
Regards,
Antonio
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
--
TF-A mailing list
TF-A(a)lists.trustedfirmware.org
https://lists.trustedfirmware.org/mailman/listinfo/tf-a
Hello,
One of the biggest issues that the current codebase of TF-A has is the build
system. It is unfit for the amount of options and dependencies of said options,
and adding new features is now an effort of trying to add the new feature while
not breaking the rest of the code.
There is another problem. When the firmware is compiled with, say, OPTION=1, if
it is recompiled with OPTION=0 without cleaning first, nothing will be rebuilt.
We have had several discussions about this internally and we have decided to
migrate to Kbuild/Kconfig, the build system used by the Linux kernel. There are
already some projects using it, like U-Boot or Zephyr RTOS.
We are starting the work related to this migration, and our intention is to
migrate upstream platforms to this new build system.
However, this change means that:
- All non-upstream platforms will break until they update their makefiles.
- Compilation under Windows won't be possible anymore without Cygwin or MinGW.
We're open to comments.
Regards,
Antonio
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
