Hi, I saw there is no concern raised about applying Jinja2 into TF-M project, and some code review is done on these patches. Plan to merge it at end of Mar 19th, if you have something please just shout 😉
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/507/ https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/509/
Thanks
-Ken
-----Original Message----- From: TF-M tf-m-bounces@lists.trustedfirmware.org On Behalf Of Ken Liu (Arm Technology China) via TF-M Sent: Wednesday, January 23, 2019 2:18 PM To: tf-m@lists.trustedfirmware.org Cc: nd nd@arm.com Subject: Re: [Tf-m] Replace custom code generating scripts with Jinja2
Hi Mate, I have checked your change and the document, it looks quite easy to support conditional including. I am OK for this tool.
Thanks.
-Ken
From: Ken Liu (Arm Technology China) Ken.Liu@arm.com Sent: Monday, January 21, 2019 9:35 PM To: tf-m@lists.trustedfirmware.org Cc: nd nd@arm.com Subject: Re: Replace custom code generating scripts with Jinja2
Hi Mate,
Thanks for the proposal. It looks nice.
I have read the "Improvements over the current solution" part and I think the "More advanced functionality" is the point I am interested in. There are some necessary jobs to be done in the code generating scripts for IPC; hope using this tool could help on that. One thing we are investigating is:
- We need to put PSA RoT and APP RoT into different groups in linker script;
current tool just put all partitions together and ignores partition type.
Can you help to check if the new tool could make this change easier?
Thanks.
-Ken
From: TF-M <tf-m-bounces@lists.trustedfirmware.orgmailto:tf-m- bounces@lists.trustedfirmware.org> on behalf of Mate Toth-Pal via TF-M <tf- m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org> Sent: Monday, January 21, 2019 8:37:58 PM To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Cc: nd Subject: [Tf-m] Replace custom code generating scripts with Jinja2
Hi All,
Based on the design proposal published here: https://developer.trustedfirmware.org/w/tf_m/design/code_generation_with_j inja2/ I am planning to replace the code generation tool currently used in the TF- M with the Jinja2 template engine.
I already prepared the change that implements this. It is available for review and testing in this gerrit review: https://review.trustedfirmware.org/#/c/trusted- firmware-m/+/507/
Please note, that this introduces a new tool dependency: jinja2 v2.10 python library have to be installed to generate code from the partition manifests. Earlier than 2.10 versions won't work, as one of the templates relies on the namespace feature introduced in this version.
Based on this change I also would like to make the secure sct files automatically generated (just like the secure ld files). The gerrit review for this change is here: https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/509/
Should you have any questions, suggestions, objections, please do not hesitate to contact!
Thanks, Mate -- TF-M mailing list TF-M@lists.trustedfirmware.orgmailto:TF-M@lists.trustedfirmware.org https://lists.trustedfirmware.org/mailman/listinfo/tf-m -- TF-M mailing list TF-M@lists.trustedfirmware.org https://lists.trustedfirmware.org/mailman/listinfo/tf-m