Hi,
Please find the latest report on new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
3 new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s)
** CID 400208: Performance inefficiencies (PASS_BY_VALUE) /include/services/el3_spmd_logical_sp.h: 108 in ffa_partition_info_regs_get_last_idx()
________________________________________________________________________________________________________ *** CID 400208: Performance inefficiencies (PASS_BY_VALUE) /include/services/el3_spmd_logical_sp.h: 108 in ffa_partition_info_regs_get_last_idx() 102 { 103 return (retval->func == FFA_MSG_SEND_DIRECT_RESP_SMC32) || 104 (retval->func == FFA_MSG_SEND_DIRECT_RESP_SMC64); 105 } 106 107 static inline uint16_t ffa_partition_info_regs_get_last_idx(
CID 400208: Performance inefficiencies (PASS_BY_VALUE) Passing parameter args of type "struct ffa_value" (size 144 bytes) by value, which exceeds the low threshold of 128 bytes.
108 struct ffa_value args) 109 { 110 return (uint16_t)(args.arg2 & 0xFFFFU); 111 } 112 113 static inline uint16_t ffa_partition_info_regs_get_curr_idx(
** CID 400207: Performance inefficiencies (PASS_BY_VALUE) /services/std_svc/spmd/spmd_logical_sp.c: 359 in ffa_partition_info_regs_get_part_info()
________________________________________________________________________________________________________ *** CID 400207: Performance inefficiencies (PASS_BY_VALUE) /services/std_svc/spmd/spmd_logical_sp.c: 359 in ffa_partition_info_regs_get_part_info() 353 * This function takes an ffa_value structure populated with partition 354 * information from an FFA_PARTITION_INFO_GET_REGS ABI call, extracts 355 * the values and writes it into a ffa_partition_info_v1_1 structure for 356 * other code to consume. 357 */ 358 bool ffa_partition_info_regs_get_part_info(
CID 400207: Performance inefficiencies (PASS_BY_VALUE) Passing parameter args of type "struct ffa_value" (size 144 bytes) by value, which exceeds the low threshold of 128 bytes.
359 struct ffa_value args, uint8_t idx, 360 struct ffa_partition_info_v1_1 *partition_info) 361 { 362 uint64_t *arg_ptrs; 363 uint64_t info, uuid_lo, uuid_high; 364
** CID 400206: Control flow issues (UNREACHABLE) /plat/xilinx/common/plat_fdt.c: 28 in prepare_dtb()
________________________________________________________________________________________________________ *** CID 400206: Control flow issues (UNREACHABLE) /plat/xilinx/common/plat_fdt.c: 28 in prepare_dtb() 22 dtb = (void *)XILINX_OF_BOARD_DTB_ADDR; 23 #endif 24 if (IS_TFA_IN_OCM(BL31_BASE)) 25 return; 26 27 /* Return if no device tree is detected */
CID 400206: Control flow issues (UNREACHABLE) This code cannot be reached: "if (fdt_check_header(dtb) !...".
28 if (fdt_check_header(dtb) != 0) { 29 NOTICE("Can't read DT at %p\n", dtb); 30 return; 31 } 32 33 ret = fdt_open_into(dtb, dtb, XILINX_OF_BOARD_DTB_MAX_SIZE);
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...
-----Original Message----- From: scan-admin--- via TF-A tf-a@lists.trustedfirmware.org Sent: Saturday, September 9, 2023 11:39 AM To: tf-a@lists.trustedfirmware.org Subject: [TF-A] New Defects reported by Coverity Scan for ARM-software/arm- trusted-firmware
Hi,
Please find the latest report on new defect(s) introduced to ARM- software/arm-trusted-firmware found with Coverity Scan.
3 new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s)
** CID 400206: Control flow issues (UNREACHABLE) /plat/xilinx/common/plat_fdt.c: 28 in prepare_dtb()
This issue is false warning . Please close this issue by using below mentioned justification. Alternatively, please suggest how this warning can be justified by us. ______________________________________________________________
*** CID 400206: Control flow issues (UNREACHABLE) /plat/xilinx/common/plat_fdt.c: 28 in prepare_dtb() 22 dtb = (void *)XILINX_OF_BOARD_DTB_ADDR; 23 #endif 24 if (IS_TFA_IN_OCM(BL31_BASE)) 25 return; 26
When TF-A runs from OCM, we return in prepare_dtb() as device tree updates are not done in this flow. When TF-A runs from DDR and DTB address is provided on build command line, Below code from line 27 onwards executes . CI script https://git.trustedfirmware.org/ci/tf-a-ci-scripts.git/tree/tf_config/versal... verifies this flow.
27 /* Return if no device tree is detected */
CID 400206: Control flow issues (UNREACHABLE) This code cannot be reached: "if (fdt_check_header(dtb) !...".28 if (fdt_check_header(dtb) != 0) { 29 NOTICE("Can't read DT at %p\n", dtb); 30 return; 31 } 32 33 ret = fdt_open_into(dtb, dtb, XILINX_OF_BOARD_DTB_MAX_SIZE);
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC- 2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp5YIaEOLnCdbFI-2FIc4JLP8- 2FUmbB2NyPEcjqFJPhqYnGCbuJCc- 2BtvVqmFI370Sr9nyYSB6KjGZP4HisQwqHQINdavyf_rJIKl4NImC2S1pVD9xH- 2BTiYorMVvk9q4XtI1ZLWqo3O4c2E0fDUfvWGCGUHiR8GkHCAzDRv6tl- 2BukXcfyBLyl-2FNJ5nifPsWzRNWlP7jPOhPOhlPGo0hC3bsPqdP1yh- 2FVoTWrxesgXJbLCtJ66LMvy9KzeyByLc4ECL6Oc0GfWXNjvL- 2BYFxRaYdDMghc5oEh-2BhiATS3FM9s- 2FUnucAu9wPxVu4rb4CWy5Wj27IbOCj6R0-3D
-- TF-A mailing list -- tf-a@lists.trustedfirmware.org To unsubscribe send an email to tf-a-leave@lists.trustedfirmware.org
Amit,
I have processed your request.
Joanna
From: Nagal, Amit via TF-A tf-a@lists.trustedfirmware.org Date: Tuesday, 12 September 2023 at 05:45 To: scan-admin@coverity.com scan-admin@coverity.com, tf-a@lists.trustedfirmware.org tf-a@lists.trustedfirmware.org Cc: Simek, Michal michal.simek@amd.com, Belsare, Akshay akshay.belsare@amd.com, Gudipalli, Sugadeesh sugadeesh.gudipalli@amd.com Subject: [TF-A] Re: New Defects reported by Coverity Scan for ARM-software/arm-trusted-firmware
-----Original Message----- From: scan-admin--- via TF-A tf-a@lists.trustedfirmware.org Sent: Saturday, September 9, 2023 11:39 AM To: tf-a@lists.trustedfirmware.org Subject: [TF-A] New Defects reported by Coverity Scan for ARM-software/arm- trusted-firmware
Hi,
Please find the latest report on new defect(s) introduced to ARM- software/arm-trusted-firmware found with Coverity Scan.
3 new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s)
** CID 400206: Control flow issues (UNREACHABLE) /plat/xilinx/common/plat_fdt.c: 28 in prepare_dtb()
This issue is false warning . Please close this issue by using below mentioned justification. Alternatively, please suggest how this warning can be justified by us. ______________________________________________________________
*** CID 400206: Control flow issues (UNREACHABLE) /plat/xilinx/common/plat_fdt.c: 28 in prepare_dtb() 22 dtb = (void *)XILINX_OF_BOARD_DTB_ADDR; 23 #endif 24 if (IS_TFA_IN_OCM(BL31_BASE)) 25 return; 26
When TF-A runs from OCM, we return in prepare_dtb() as device tree updates are not done in this flow. When TF-A runs from DDR and DTB address is provided on build command line, Below code from line 27 onwards executes . CI script https://git.trustedfirmware.org/ci/tf-a-ci-scripts.git/tree/tf_config/versal... verifies this flow.
27 /* Return if no device tree is detected */
CID 400206: Control flow issues (UNREACHABLE) This code cannot be reached: "if (fdt_check_header(dtb) !...".28 if (fdt_check_header(dtb) != 0) { 29 NOTICE("Can't read DT at %p\n", dtb); 30 return; 31 } 32 33 ret = fdt_open_into(dtb, dtb, XILINX_OF_BOARD_DTB_MAX_SIZE);
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC- 2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp5YIaEOLnCdbFI-2FIc4JLP8- 2FUmbB2NyPEcjqFJPhqYnGCbuJCc- 2BtvVqmFI370Sr9nyYSB6KjGZP4HisQwqHQINdavyf_rJIKl4NImC2S1pVD9xH- 2BTiYorMVvk9q4XtI1ZLWqo3O4c2E0fDUfvWGCGUHiR8GkHCAzDRv6tl- 2BukXcfyBLyl-2FNJ5nifPsWzRNWlP7jPOhPOhlPGo0hC3bsPqdP1yh- 2FVoTWrxesgXJbLCtJ66LMvy9KzeyByLc4ECL6Oc0GfWXNjvL- 2BYFxRaYdDMghc5oEh-2BhiATS3FM9s- 2FUnucAu9wPxVu4rb4CWy5Wj27IbOCj6R0-3D
-- TF-A mailing list -- tf-a@lists.trustedfirmware.org To unsubscribe send an email to tf-a-leave@lists.trustedfirmware.org
-- TF-A mailing list -- tf-a@lists.trustedfirmware.org To unsubscribe send an email to tf-a-leave@lists.trustedfirmware.org
Hi Joanna,
Thanks very much.
Regards Amit
From: Joanna Farley Joanna.Farley@arm.com Sent: Tuesday, September 12, 2023 1:47 PM To: Nagal, Amit amit.nagal@amd.com; tf-a@lists.trustedfirmware.org Cc: Simek, Michal michal.simek@amd.com; Belsare, Akshay akshay.belsare@amd.com; Gudipalli, Sugadeesh sugadeesh.gudipalli@amd.com Subject: Re: [TF-A] Re: New Defects reported by Coverity Scan for ARM-software/arm-trusted-firmware
Amit,
I have processed your request.
Joanna
From: Nagal, Amit via TF-A <tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org> Date: Tuesday, 12 September 2023 at 05:45 To: scan-admin@coverity.commailto:scan-admin@coverity.com <scan-admin@coverity.commailto:scan-admin@coverity.com>, tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org <tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org> Cc: Simek, Michal <michal.simek@amd.commailto:michal.simek@amd.com>, Belsare, Akshay <akshay.belsare@amd.commailto:akshay.belsare@amd.com>, Gudipalli, Sugadeesh <sugadeesh.gudipalli@amd.commailto:sugadeesh.gudipalli@amd.com> Subject: [TF-A] Re: New Defects reported by Coverity Scan for ARM-software/arm-trusted-firmware
-----Original Message----- From: scan-admin--- via TF-A <tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org> Sent: Saturday, September 9, 2023 11:39 AM To: tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org Subject: [TF-A] New Defects reported by Coverity Scan for ARM-software/arm- trusted-firmware
Hi,
Please find the latest report on new defect(s) introduced to ARM- software/arm-trusted-firmware found with Coverity Scan.
3 new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s)
** CID 400206: Control flow issues (UNREACHABLE) /plat/xilinx/common/plat_fdt.c: 28 in prepare_dtb()
This issue is false warning . Please close this issue by using below mentioned justification. Alternatively, please suggest how this warning can be justified by us. ______________________________________________________________
*** CID 400206: Control flow issues (UNREACHABLE) /plat/xilinx/common/plat_fdt.c: 28 in prepare_dtb() 22 dtb = (void *)XILINX_OF_BOARD_DTB_ADDR; 23 #endif 24 if (IS_TFA_IN_OCM(BL31_BASE)) 25 return; 26
When TF-A runs from OCM, we return in prepare_dtb() as device tree updates are not done in this flow. When TF-A runs from DDR and DTB address is provided on build command line, Below code from line 27 onwards executes . CI script https://git.trustedfirmware.org/ci/tf-a-ci-scripts.git/tree/tf_config/versal... verifies this flow.
27 /* Return if no device tree is detected */
CID 400206: Control flow issues (UNREACHABLE) This code cannot be reached: "if (fdt_check_header(dtb) !...".28 if (fdt_check_header(dtb) != 0) { 29 NOTICE("Can't read DT at %p\n", dtb); 30 return; 31 } 32 33 ret = fdt_open_into(dtb, dtb, XILINX_OF_BOARD_DTB_MAX_SIZE);
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC- 2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp5YIaEOLnCdbFI-2FIc4JLP8- 2FUmbB2NyPEcjqFJPhqYnGCbuJCc- 2BtvVqmFI370Sr9nyYSB6KjGZP4HisQwqHQINdavyf_rJIKl4NImC2S1pVD9xH- 2BTiYorMVvk9q4XtI1ZLWqo3O4c2E0fDUfvWGCGUHiR8GkHCAzDRv6tl- 2BukXcfyBLyl-2FNJ5nifPsWzRNWlP7jPOhPOhlPGo0hC3bsPqdP1yh- 2FVoTWrxesgXJbLCtJ66LMvy9KzeyByLc4ECL6Oc0GfWXNjvL- 2BYFxRaYdDMghc5oEh-2BhiATS3FM9s- 2FUnucAu9wPxVu4rb4CWy5Wj27IbOCj6R0-3D
-- TF-A mailing list -- tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org To unsubscribe send an email to tf-a-leave@lists.trustedfirmware.orgmailto:tf-a-leave@lists.trustedfirmware.org
-- TF-A mailing list -- tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org To unsubscribe send an email to tf-a-leave@lists.trustedfirmware.orgmailto:tf-a-leave@lists.trustedfirmware.org
tf-a@lists.trustedfirmware.org
-
Joanna Farley -
Nagal, Amit -
scan-admin＠coverity.com