mmc_enumerate() is the only caller of mmc_send_op_cond(). mmc_enumerate() calls mmc_reset_to_idle() just before calling mmc_send_op_cond(). No need to do that again in mmc_send_op_cond().
Signed-off-by: Baruch Siach baruch@tkos.co.il Change-Id: Ib8c8ed1a559e3fecb315245f91bb3dc1f547d820 ---
Sending the patch to the list once again. review.trustedfirmware.org does not work for me.
https://lists.trustedfirmware.org/archives/list/tf-a@lists.trustedfirmware.o... --- drivers/mmc/mmc.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 2b727d4e7696..57f47482013a 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -452,11 +452,6 @@ static int mmc_send_op_cond(void) int ret, n; unsigned int resp_data[4];
- ret = mmc_reset_to_idle(); - if (ret != 0) { - return ret; - } - for (n = 0; n < SEND_OP_COND_MAX_RETRIES; n++) { ret = mmc_send_cmd(MMC_CMD(1), OCR_SECTOR_MODE | OCR_VDD_MIN_2V7 | OCR_VDD_MIN_1V7,
Hi Barush,
I've pushed the patch there: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/19804
Best regards, Yann
On 2/28/23 11:52, Baruch Siach via TF-A wrote:
mmc_enumerate() is the only caller of mmc_send_op_cond(). mmc_enumerate() calls mmc_reset_to_idle() just before calling mmc_send_op_cond(). No need to do that again in mmc_send_op_cond().
Signed-off-by: Baruch Siach baruch@tkos.co.il Change-Id: Ib8c8ed1a559e3fecb315245f91bb3dc1f547d820
Sending the patch to the list once again. review.trustedfirmware.org does not work for me.
https://lists.trustedfirmware.org/archives/list/tf-a@lists.trustedfirmware.o...
drivers/mmc/mmc.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 2b727d4e7696..57f47482013a 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -452,11 +452,6 @@ static int mmc_send_op_cond(void) int ret, n; unsigned int resp_data[4];
- ret = mmc_reset_to_idle();
- if (ret != 0) {
return ret;- }
- for (n = 0; n < SEND_OP_COND_MAX_RETRIES; n++) { ret = mmc_send_cmd(MMC_CMD(1), OCR_SECTOR_MODE | OCR_VDD_MIN_2V7 | OCR_VDD_MIN_1V7,
tf-a@lists.trustedfirmware.org
-
Baruch Siach -
Yann Gautier