New Defects reported by Coverity Scan for ARM-software/arm-trusted-firmware - TF-A

1 Jul 2023


      Hi,
Please find the latest report on new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
2 new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 394601:  Integer handling issues  (NO_EFFECT)
/lib/xlat_tables_v2/aarch64/xlat_tables_arch.c: 30 in xlat_arch_is_granule_size_supported()
________________________________________________________________________________________________________
*** CID 394601:  Integer handling issues  (NO_EFFECT)
/lib/xlat_tables_v2/aarch64/xlat_tables_arch.c: 30 in xlat_arch_is_granule_size_supported()
24     {
25     	unsigned int tgranx;
26     
27     	if (size == PAGE_SIZE_4KB) {
28     		tgranx = read_id_aa64mmfr0_el0_tgran4_field();
29     		/* MSB of TGRAN4 field will be '1' for unsupported feature */
...
...
...
CID 394601:  Integer handling issues  (NO_EFFECT)
This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "tgranx >= 0ULL".

30     		return ((tgranx >= ID_AA64MMFR0_EL1_TGRAN4_SUPPORTED) &&
31     			(tgranx < 8U));
32     	} else if (size == PAGE_SIZE_16KB) {
33     		tgranx = read_id_aa64mmfr0_el0_tgran16_field();
34     		return (tgranx >= ID_AA64MMFR0_EL1_TGRAN16_SUPPORTED);
35     	} else if (size == PAGE_SIZE_64KB) {
** CID 394600:    (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 394600:    (NULL_RETURNS)
/plat/qemu/qemu_sbsa/sbsa_sip_svc.c: 104 in read_platform_version()
98     	int node;
99     
100     	node = fdt_path_offset(dtb, "/");
101     	if (node >= 0) {
102     		platform_version_major = fdt32_ld(fdt_getprop(dtb, node,
103     							      "machine-version-major", NULL));
...
...
...
CID 394600:    (NULL_RETURNS)
Dereferencing a pointer that might be "NULL" "fdt_getprop(dtb, node, "machine-version-minor", NULL)" when calling "fdt32_ld".

104     		platform_version_minor = fdt32_ld(fdt_getprop(dtb, node,
105     							      "machine-version-minor", NULL));
106     	}
107     }
108     
109     void sip_svc_init(void)
/plat/qemu/qemu_sbsa/sbsa_sip_svc.c: 102 in read_platform_version()
96     void read_platform_version(void *dtb)
97     {
98     	int node;
99     
100     	node = fdt_path_offset(dtb, "/");
101     	if (node >= 0) {
...
...
...
CID 394600:    (NULL_RETURNS)
Dereferencing a pointer that might be "NULL" "fdt_getprop(dtb, node, "machine-version-major", NULL)" when calling "fdt32_ld".

102     		platform_version_major = fdt32_ld(fdt_getprop(dtb, node,
103     							      "machine-version-major", NULL));
104     		platform_version_minor = fdt32_ld(fdt_getprop(dtb, node,
105     							      "machine-version-minor", NULL));
106     	}
107     }
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...