Hi Boyan,
Some questions about erratum in TF-A: 1 Why workaround's flag is 0? In my mind, all flag should be 1 because there is func to check cpu revisions, such as check_errata_2326639.
43438ad1a patch: +ERRATA_N2_2326639 ?=0
2 After e444763d6(shorten errata flag defines) patch, introduce CPU_FLAG_LIST, Is the workaround's flag change to 1?
e444763d6 patch: -ERRATA_N2_2326639 ?=0 +CPU_FLAG_LIST += ERRATA_N2_2326639
Regards, Ming
Hi Ming
1. Not all errata affect all platforms and usually workarounds have some performance or other undesirable impact. Therefore we leave it to the platform integrator to choose whether to include each workaround.
2. I've only just looked at that patch but it appears the CPU_FLAG_LIST is zero initialized so there is no longer any need to zero initialize each entry in the list.
Regards
Dan.
-----Original Message----- From: Ming Huang via TF-A tf-a@lists.trustedfirmware.org Sent: Wednesday, August 2, 2023 10:29 AM To: Boyan Karatotev Boyan.Karatotev@arm.com Cc: tf-a@lists.trustedfirmware.org Subject: [TF-A] About erratum in TF-A
Hi Boyan,
Some questions about erratum in TF-A: 1 Why workaround's flag is 0? In my mind, all flag should be 1 because there is func to check cpu revisions, such as check_errata_2326639.
43438ad1a patch: +ERRATA_N2_2326639 ?=0
2 After e444763d6(shorten errata flag defines) patch, introduce CPU_FLAG_LIST, Is the workaround's flag change to 1?
e444763d6 patch: -ERRATA_N2_2326639 ?=0 +CPU_FLAG_LIST += ERRATA_N2_2326639
Regards, Ming -- TF-A mailing list -- tf-a@lists.trustedfirmware.org To unsubscribe send an email to tf-a-leave@lists.trustedfirmware.org
Hi Dan,
Thanks for reply!
On 8/3/23 7:55 PM, Dan Handley wrote:
Hi Ming
Not all errata affect all platforms and usually workarounds have some performance or other undesirable impact. Therefore we leave it to the platform integrator to choose whether to include each workaround.
I've only just looked at that patch but it appears the CPU_FLAG_LIST is zero initialized so there is no longer any need to zero initialize each entry in the list.
Regards
Dan.
-----Original Message----- From: Ming Huang via TF-A tf-a@lists.trustedfirmware.org Sent: Wednesday, August 2, 2023 10:29 AM To: Boyan Karatotev Boyan.Karatotev@arm.com Cc: tf-a@lists.trustedfirmware.org Subject: [TF-A] About erratum in TF-A
Hi Boyan,
Some questions about erratum in TF-A: 1 Why workaround's flag is 0? In my mind, all flag should be 1 because there is func to check cpu revisions, such as check_errata_2326639.
43438ad1a patch: +ERRATA_N2_2326639 ?=0
2 After e444763d6(shorten errata flag defines) patch, introduce CPU_FLAG_LIST, Is the workaround's flag change to 1?
e444763d6 patch: -ERRATA_N2_2326639 ?=0 +CPU_FLAG_LIST += ERRATA_N2_2326639
Regards, Ming -- TF-A mailing list -- tf-a@lists.trustedfirmware.org To unsubscribe send an email to tf-a-leave@lists.trustedfirmware.org
tf-a@lists.trustedfirmware.org
-
Dan Handley -
Ming Huang