I am working on qemu_sbsa platform. We are now adding a way to share data from QEMU via TF-A to EDK2. Standard Arm way - using Secure Monitor Calls.
I checked how other platforms do it and wrote a patch [1]. It got reviews, went through CI and all is fine except one thing:
New source files have been identified in your patch.. plat/qemu/qemu_sbsa/sbsa_sip_svc.c
1. https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/20871
I have read TF-A documentation linked to CI report. This new file is covered already by PLAT=qemu_sbsa build because it is not optional. How to make CI pass?
Same problem is with second patch [2] where I added another new source file.
2. https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/20953
Hello Marcin,
I understand your confusion. Unfortunately, this CI job is not that clever and blindly flags any newly introduced files. As can be seen here [1], it simply compares the list of TF-A source files present on the integration branch with the list of source files in your commit.
This is meant to serve just as a reminder to take potential CI changes into account and the last part of the message tries (but evidently failed...) to remove confusion:
"2. Please ignore if your files are already updated. Further the Code Maintainer will resolve the issue by taking appropriate action."
I admit there is room for improvement!
There is no action on you. As you pointed out, the new files you're adding are covered by the existing build config. A maintainer will remove the Verified-1 down-vote after checking this is the only issue flagged by the CI on your patches.
Regards, Sandrine
[1] https://git.trustedfirmware.org/ci/tf-a-ci-scripts.git/tree/script/static-ch...
On 6/1/23 12:19, Marcin Juszkiewicz via TF-A wrote:
I am working on qemu_sbsa platform. We are now adding a way to share data from QEMU via TF-A to EDK2. Standard Arm way - using Secure Monitor Calls.
I checked how other platforms do it and wrote a patch [1]. It got reviews, went through CI and all is fine except one thing:
New source files have been identified in your patch.. plat/qemu/qemu_sbsa/sbsa_sip_svc.c
I have read TF-A documentation linked to CI report. This new file is covered already by PLAT=qemu_sbsa build because it is not optional. How to make CI pass?
Same problem is with second patch [2] where I added another new source file.
W dniu 2.06.2023 o 11:53, Sandrine Bailleux pisze:
There is no action on you. As you pointed out, the new files you're adding are covered by the existing build config.
Thanks for explaining.
A maintainer will remove the Verified-1 down-vote after checking this is the only issue flagged by the CI on your patches.
I just hope it will not take 3 months like it did with my previous patch ;D
tf-a@lists.trustedfirmware.org