New Defects reported by Coverity Scan for ARM-software/arm-trusted-firmware - TF-A

10 Dec 2020


      Hi,
Please find the latest report on new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
3 new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 364146:  Control flow issues  (DEADCODE)
/plat/mediatek/mt8192/plat_pm.c: 301 in plat_validate_power_state()
________________________________________________________________________________________________________
*** CID 364146:  Control flow issues  (DEADCODE)
/plat/mediatek/mt8192/plat_pm.c: 301 in plat_validate_power_state()
295     {
296     	unsigned int pstate = psci_get_pstate_type(power_state);
297     	unsigned int aff_lvl = psci_get_pstate_pwrlvl(power_state);
298     	unsigned int cpu = plat_my_core_pos();
299     
300     	if (aff_lvl > PLAT_MAX_PWR_LVL) {
...
...
...
CID 364146:  Control flow issues  (DEADCODE)
Execution cannot reach this statement: "return -2;".

301     		return PSCI_E_INVALID_PARAMS;
302     	}
303     
304     	if (pstate == PSTATE_TYPE_STANDBY) {
305     		req_state->pwr_domain_state[0] = PLAT_MAX_RET_STATE;
306     	} else {
** CID 364145:  Integer handling issues  (NO_EFFECT)
/plat/mediatek/mt8192/drivers/ptp3/mtk_ptp3_main.c: 42 in ptp3_init()
________________________________________________________________________________________________________
*** CID 364145:  Integer handling issues  (NO_EFFECT)
/plat/mediatek/mt8192/drivers/ptp3/mtk_ptp3_main.c: 42 in ptp3_init()
36      * API
37      ************************************************/
38     void ptp3_init(unsigned int core)
39     {
40     	unsigned int _core;
41
...
...
...
CID 364145:  Integer handling issues  (NO_EFFECT)
This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "core >= 0U".

42     	if (core >= PTP3_CFG1_CPU_START_ID) {
43     		if (core < NR_PTP3_CFG1_CPU) {
44     			/* update ptp3_cfg1 */
45     			ptp3_write(
46     				ptp3_cfg1[core][PTP3_CFG_ADDR],
47     				ptp3_cfg1[core][PTP3_CFG_VALUE]);
** CID 364144:  Integer handling issues  (NO_EFFECT)
/plat/mediatek/mt8192/drivers/ptp3/mtk_ptp3_main.c: 76 in ptp3_deinit()
________________________________________________________________________________________________________
*** CID 364144:  Integer handling issues  (NO_EFFECT)
/plat/mediatek/mt8192/drivers/ptp3/mtk_ptp3_main.c: 76 in ptp3_deinit()
70     		}
71     	}
72     }
73     
74     void ptp3_deinit(unsigned int core)
75     {
...
...
...
CID 364144:  Integer handling issues  (NO_EFFECT)
This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "core >= 0U".

76     	if (core >= PTP3_CFG1_CPU_START_ID) {
77     		if (core < NR_PTP3_CFG1_CPU) {
78     			/* update ptp3_cfg1 */
79     			ptp3_write(
80     				ptp3_cfg1[core][PTP3_CFG_ADDR],
81     				ptp3_cfg1[core][PTP3_CFG_VALUE] &
82     					 ~PTP3_CFG1_MASK);
83     		}
84     	}
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...