New Defects reported by Coverity Scan for ARM-software/arm-trusted-firmware - TF-A

29 Mar 2022


      Hi,
Please find the latest report on new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
2 new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 376885:  Integer handling issues  (NEGATIVE_RETURNS)
________________________________________________________________________________________________________
*** CID 376885:  Integer handling issues  (NEGATIVE_RETURNS)
/drivers/st/clk/clk-stm32-core.c: 343 in _clk_stm32_set_parent()
337     		if (parents->id_parents[sel] == (uint16_t)clkp) {
338     			bool clk_was_enabled = _clk_stm32_is_enabled(priv, clk);
339     			int err = 0;
340     
341     			/* Enable the parents (for glitch free mux) */
342     			_clk_stm32_enable(priv, clkp);
...
...
...
CID 376885:  Integer handling issues  (NEGATIVE_RETURNS)
"old_parent" is passed to a parameter that cannot be negative.

343     			_clk_stm32_enable(priv, old_parent);
344     
345     			err = clk_mux_set_parent(priv, pid, sel);
346     
347     			_clk_stm32_disable(priv, old_parent);
348
** CID 376884:  Error handling issues  (CHECKED_RETURN)
/drivers/nxp/ddr/phy-gen2/phy.c: 2219 in load_fw()
________________________________________________________________________________________________________
*** CID 376884:  Error handling issues  (CHECKED_RETURN)
/drivers/nxp/ddr/phy-gen2/phy.c: 2219 in load_fw()
2213     		ERROR("Unsupported DIMM type\n");
2214     		return -EINVAL;
2215     	}
2216     
2217     	size = PHY_GEN2_MAX_IMAGE_SIZE;
2218     	image_buf = (uintptr_t)phy_gen2_fw_img_buf;
...
...
...
CID 376884:  Error handling issues  (CHECKED_RETURN)
Calling "mmap_add_dynamic_region" without checking return value (as is done elsewhere 14 out of 16 times).

2219     	mmap_add_dynamic_region(phy_gen2_fw_img_buf,
2220     			phy_gen2_fw_img_buf,
2221     			PHY_GEN2_MAX_IMAGE_SIZE,
2222     			MT_MEMORY | MT_RW | MT_SECURE);
2223     	ret = img_loadr(imem_id, &image_buf, &size);
2224     	if (ret != 0) {
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...