New Defects reported by Coverity Scan for ARM-software/arm-trusted-firmware - TF-A

19 Sep 2019


      Hi,
Please find the latest report on new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
1 new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 349459:    (ARRAY_VS_SINGLETON)
________________________________________________________________________________________________________
*** CID 349459:    (ARRAY_VS_SINGLETON)
/plat/mediatek/mt8183/drivers/sspm/sspm.c: 150 in sspm_alive_show()
144     
145     	if (sspm_ipi_send_non_blocking(IPI_ID_PLATFORM, &ipi_data) != 0) {
146     		ERROR("sspm init send fail! ret=%d\n", ret);
147     		return -1;
148     	}
149
...
...
...
CID 349459:    (ARRAY_VS_SINGLETON)
Passing "&ipi_data" to function "sspm_ipi_recv_non_blocking" which uses it as an array. This might corrupt or misinterpret adjacent memory locations.

150     	while (sspm_ipi_recv_non_blocking(IPI_ID_PLATFORM,
151     					  &ipi_data,
152     					  sizeof(ipi_data))
153     					  && count) {
154     		mdelay(100);
155     		count--;
156     	}
157     
158     	return (ipi_data == 1) ? 0 : -1;
/plat/mediatek/mt8183/drivers/sspm/sspm.c: 145 in sspm_alive_show()
139     	uint32_t ipi_data, count;
140     	int ret = 0;
141     
142     	count = 5;
143     	ipi_data = 0xdead;
144
...
...
...
CID 349459:    (ARRAY_VS_SINGLETON)
Passing "&ipi_data" to function "sspm_ipi_send_non_blocking" which uses it as an array. This might corrupt or misinterpret adjacent memory locations.

145     	if (sspm_ipi_send_non_blocking(IPI_ID_PLATFORM, &ipi_data) != 0) {
146     		ERROR("sspm init send fail! ret=%d\n", ret);
147     		return -1;
148     	}
149     
150     	while (sspm_ipi_recv_non_blocking(IPI_ID_PLATFORM,
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05...