Hi,

I submitted the change for you https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/27986

We'll get maintainers review shortly.

For submitting a change, next time can you try

git push origin HEAD:refs/for/integration

Regards, Olivier.

________________________________ From: Jacob Kroon via TF-A tf-a@lists.trustedfirmware.org Sent: 12 April 2024 14:20 To: tf-a@lists.trustedfirmware.org tf-a@lists.trustedfirmware.org Subject: [TF-A] Patch for fixing SGIR_NSATT bitshift

Hi,

I tried to follow the contribution guide but was unable to push the patch to gerrit for review. "git review" just hangs with nothing happening.

The patch I want to push for review is:

From 198af98d05cfb4704aa2387eaa0a1e606a7968de Mon Sep 17 00:00:00 2001 From: Jacob Kroon <jacob.kroon@gmail.commailto:jacob.kroon@gmail.com> Date: Fri, 12 Apr 2024 13:11:36 +0200 Subject: [PATCH] fix(gic): Fix SGIR_NSATT bitshift

See https://documentation-service.arm.com/static/5f8ff196f86e16515cdbf969?token=

Fixes: dcb31ff79096fc88b45df8068e5de83b93f833ed Signed-off-by: Jacob Kroon <jacob.kroon@gmail.commailto:jacob.kroon@gmail.com> --- include/drivers/arm/gicv2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drivers/arm/gicv2.h b/include/drivers/arm/gicv2.h index bebd9ceff..c7c441d78 100644 --- a/include/drivers/arm/gicv2.h +++ b/include/drivers/arm/gicv2.h @@ -51,7 +51,7 @@ #define SGIR_TGTLSTFLT_MASK U(0x3) #define SGIR_TGTLST_SHIFT 16 #define SGIR_TGTLST_MASK U(0xff) -#define SGIR_NSATT (U(0x1) << 16) +#define SGIR_NSATT (U(0x1) << 15) #define SGIR_INTID_MASK ULL(0xf)

#define SGIR_TGT_SPECIFIC U(0) -- 2.39.2

Are there any suggestions on what I should do next ?

Regards Jacob