Hi Nicolas,
On 3/29/21 12:40 AM, Nicolas Boulenguez via TF-A wrote:
Currently, tools/cert_create/cert_create is not removed. The attached one-line patch fixes this.
Thank you for your patch!
The TF-A project uses the Gerrit review system for patch reviews, would you mind resending your patch on review.trustedfirmware.org please?
If you need help with that, there's a "getting started" guide there (it is a bit outdated but hopefully still helpful): https://developer.trustedfirmware.org/w/tf_a/gerrit-getting-started/
And our project specific contribution guidelines are there:
https://trustedfirmware-a.readthedocs.io/en/latest/process/contributing.html
Regards, Sandrine
The TF-A project uses the Gerrit review system for patch reviews, would you mind resending your patch on review.trustedfirmware.org please?
If you need help with that, there's a "getting started" guide there (it is a bit outdated but hopefully still helpful): https://developer.trustedfirmware.org/w/tf_a/gerrit-getting-started/
And our project specific contribution guidelines are there:
https://trustedfirmware-a.readthedocs.io/en/latest/process/contributing.html
I had checked the "guidelines". The absence of terms like "requirements" or "policy" was suggesting alternative submission channels.
Paperwork is useful for complex, critical or paid code, but this specific change affects four letters in the trivial clean step of a build-time script. The procedure would take much more time than the patch itself.
Hi Nicolas,
On 3/29/21 7:19 PM, Nicolas Bouleng
I had checked the "guidelines". The absence of terms like "requirements" or "policy" was suggesting alternative submission channels.
Although they are called guidelines in the project's documentation, Gerrit is actually the only accepted patch submission channel, no matter the size or complexity of the patch. We might need to strengthen the language in the documentation.
Regards, Sandrine
Hello again.
https://developer.trustedfirmware.org/w/tf_a/gerrit-getting-started/ https://trustedfirmware-a.readthedocs.io/en/latest/process/contributing.html
# git clone https://.... # git push origin HEAD:refs/for/integation%topic=clean-cert-create requires a password.
In order to create an account on review.trustedfirmware.org, a github account seems necessary. It also seems necessary to authorize review.trustedfirmware.org to look at my email address in github.
Once logged to review.trustedfirmware.org, I suppose I should click on the "GENERATE NEW PASSWORD" button in the "HTTP Credentials" section. Two pop-up windows appear:
New Password: Generating... This password will not be displayed again. If you lose it, you will need to generate a new one. (CLOSE)
Error 500 (Server Error): Internal server error Endpoint: /accounts/self/password.http (DISMISS)
Another sensible option is probably to add SSH keys, but the "SAVE CHANGES" button is inactive/grey and cannot be clicked.
What should I do now? Thanks.
Hi Nicolas,
On 3/31/21 2:02 PM, Nicolas Boulenguez wrote:
<snip>> Once logged to review.trustedfirmware.org, I suppose I should click on the "GENERATE NEW PASSWORD" button in the "HTTP Credentials" section. Two pop-up windows appear:
New Password: Generating... This password will not be displayed again. If you lose it, you will need to generate a new one. (CLOSE)
Error 500 (Server Error): Internal server error Endpoint: /accounts/self/password.http (DISMISS)
Another sensible option is probably to add SSH keys, but the "SAVE CHANGES" button is inactive/grey and cannot be clicked.
What should I do now?
I've never tried the password authentication myself, I use an SSH key instead so I can try to help with this.
In my settings, in the section "SSH keys", this is what I see (from top to bottom): 1. A summary of my existing key. 2. The "SAVE CHANGES" button you refer to. 3. A text box with "New SSH Key" written inside it. 4. The "ADD NEW SSH KEY" button, which is greyed out by default.
If I copy and paste my public key inside the text box (3.), the button (4.) turns blue and I can click it to add the key. The "SAVE CHANGES" button (2.) does not play a role in this.
Hope that helps.
Regards, Sandrine
Error 500 (Server Error): Internal server error Endpoint: /accounts/self/password.http
- A text box with "New SSH Key" written inside it.
- The "ADD NEW SSH KEY" button, which is greyed out by default.
If I copy and paste my public key inside the text box (3.), the button (4.) turns blue and I can click it to add the key.
Thanks for the explanation, SSH is be more convenient than a password. However, for now, I seem to encounter the same problem than above when I click on (4).
Error 500 (Server Error): Internal server error Endpoint: /accounts/self/sshkeys
In case it helps: the error message differs with an incorrectly formatted key, so the server error happens after the key is parsed.
Hi,
On 4/1/21 2:37 PM, Nicolas Boulenguez wrote:
Error 500 (Server Error): Internal server error Endpoint: /accounts/self/password.http
- A text box with "New SSH Key" written inside it.
- The "ADD NEW SSH KEY" button, which is greyed out by default.
If I copy and paste my public key inside the text box (3.), the button (4.) turns blue and I can click it to add the key.
Thanks for the explanation, SSH is be more convenient than a password. However, for now, I seem to encounter the same problem than above when I click on (4).
Error 500 (Server Error): Internal server error Endpoint: /accounts/self/sshkeys
In case it helps: the error message differs with an incorrectly formatted key, so the server error happens after the key is parsed.
Sorry I am out of idea... I've setup my own key a while ago and I don't remember whether I faced any such issue.
I'm CC'ing a couple of Linaro folks who might be able to help.
@Leonardo, @Ben, @Fathi: Hi guys, any idea how to solve the "500 server error" Nicolas is facing when registering his SSH key in Gerrit?
Regards, Sandrine
tf-a@lists.trustedfirmware.org
-
Nicolas Boulenguez -
Sandrine Bailleux