New Defects reported by Coverity Scan for ARM-software/arm-trusted-firmware - TF-A

26 Aug 2022


      Hi,
Please find the latest report on new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
3 new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 380536:  Control flow issues  (NO_EFFECT)
/bl32/tsp/tsp_ffa_main.c: 220 in test_memory_send()
________________________________________________________________________________________________________
*** CID 380536:  Control flow issues  (NO_EFFECT)
/bl32/tsp/tsp_ffa_main.c: 220 in test_memory_send()
214     			ERROR("Failed [%u] mmap_add_dynamic_region %u (%lx) (%lx) (%x)!\n",
215     				i, ret,
216     				(uint64_t)composite->address_range_array[i].address,
217     				size, mem_attrs);
218     
219     			/* Remove mappings created in this transaction. */
...
...
...
CID 380536:  Control flow issues  (NO_EFFECT)
This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "i >= 0U".

220     			for (i--; i >= 0U; i--) {
221     				ret = mmap_remove_dynamic_region(
222     					(uint64_t)ptr,
223     					composite->address_range_array[i].page_count * PAGE_SIZE);
224     
225     				if (ret != 0) {
** CID 380535:  Null pointer dereferences  (REVERSE_INULL)
/bl32/tsp/ffa_helpers.c: 154 in memory_retrieve()
________________________________________________________________________________________________________
*** CID 380535:  Null pointer dereferences  (REVERSE_INULL)
/bl32/tsp/ffa_helpers.c: 154 in memory_retrieve()
148     			    uint32_t *total_length)
149     {
150     	smc_args_t ret;
151     	uint32_t descriptor_size;
152     	struct ffa_mtd *memory_region = (struct ffa_mtd *)mb->tx_buffer;
153
...
...
...
CID 380535:  Null pointer dereferences  (REVERSE_INULL)
Null-checking "mb" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

154     	if (retrieved == NULL || mb == NULL) {
155     		ERROR("Invalid parameters!\n");
156     		return false;
157     	}
158     
159     	/* Clear TX buffer. */
** CID 380534:  API usage errors  (SWAPPED_ARGUMENTS)
________________________________________________________________________________________________________
*** CID 380534:  API usage errors  (SWAPPED_ARGUMENTS)
/bl32/tsp/tsp_ffa_main.c: 476 in handle_partition_message()
470     
471     	default:
472     		INFO("TSP Tests: Unknown request ID %d--\n", (int) arg3);
473     	}
474     
475     	/* Swap the sender and receiver in the response. */
...
...
...
CID 380534:  API usage errors  (SWAPPED_ARGUMENTS)
The positions of arguments in the call to "ffa_msg_send_direct_resp" do not match the ordering of the parameters:

* "receiver" is passed to "sender".
* "sender" is passed to "receiver".
476     	return ffa_msg_send_direct_resp(receiver, sender, status, 0, 0, 0, 0);
477     }
478     
479     /*******************************************************************************
480      * This function implements the event loop for handling FF-A ABI invocations.
481      ******************************************************************************/
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...