When booting my Pine64 Rock64 (rk3328), I see the following warning: WARNING: BL31: cortex_a53: CPU workaround for 1530924 was missing!
That warning is present in u-boot 2023.01 and also in 2023.07. Asking on their IRC channel and they indicated it should be fixed in TF-A.
In the source code I saw various commits which all seem a variation of 74665119f04de0cd7c735fa741aff607a4a9fde8 titled "Enable workaround for Cortex-A53 erratum 1530924"
But such a commit seems to be missing for the rk3328 platform.
I guess a patch like this is needed to fix that? ```patch diff --git a/plat/rockchip/rk3328/platform.mk b/plat/rockchip/rk3328/ platform.mk index 5b4766d51..bd86a1cc8 100644 --- a/plat/rockchip/rk3328/platform.mk +++ b/plat/rockchip/rk3328/platform.mk @@ -65,6 +65,7 @@ include lib/libfdt/libfdt.mk
# Enable workarounds for selected Cortex-A53 errata ERRATA_A53_855873 := 1 +ERRATA_A53_1530924 := 1
$(eval $(call add_define,PLAT_EXTRA_LD_SCRIPT)) $(eval $(call add_define,PLAT_SKIP_OPTEE_S_EL1_INT_REGISTER)) ```
The Contributor’s Guide indicates that it requires a Microsoft Github account, so I opted to post a patch to this list.
Cheers, Diederik
PS: https://developer.trustedfirmware.org/ seems to be full of spam; you may want to look into that.
Hi,
I guess a patch like this is needed to fix that?
Yes this change looks reasonable.
The Contributor’s Guide indicates that it requires a Microsoft Github account,
Reviews happens in https://review.trustedfirmware.org Yes you need a github account id to post a change for review.
PS: https://developer.trustedfirmware.org/ seems to be full of spam; you may
want to look into that.
Thanks for reporting. Note you may preferably report issues to the github interface https://github.com/TrustedFirmware-A/trusted-firmware-a/issues
Regards, Olivier.
________________________________________ From: Diederik de Haas via TF-A tf-a@lists.trustedfirmware.org Sent: 23 November 2023 20:51 To: tf-a@lists.trustedfirmware.org; tony.xie@rock-chips.com Subject: [TF-A] rk3328: WARNING: BL31: cortex_a53: CPU workaround for 1530924 was missing!
When booting my Pine64 Rock64 (rk3328), I see the following warning: WARNING: BL31: cortex_a53: CPU workaround for 1530924 was missing!
That warning is present in u-boot 2023.01 and also in 2023.07. Asking on their IRC channel and they indicated it should be fixed in TF-A.
In the source code I saw various commits which all seem a variation of 74665119f04de0cd7c735fa741aff607a4a9fde8 titled "Enable workaround for Cortex-A53 erratum 1530924"
But such a commit seems to be missing for the rk3328 platform.
I guess a patch like this is needed to fix that? ```patch diff --git a/plat/rockchip/rk3328/platform.mk b/plat/rockchip/rk3328/ platform.mk index 5b4766d51..bd86a1cc8 100644 --- a/plat/rockchip/rk3328/platform.mk +++ b/plat/rockchip/rk3328/platform.mk @@ -65,6 +65,7 @@ include lib/libfdt/libfdt.mk
# Enable workarounds for selected Cortex-A53 errata ERRATA_A53_855873 := 1 +ERRATA_A53_1530924 := 1
$(eval $(call add_define,PLAT_EXTRA_LD_SCRIPT)) $(eval $(call add_define,PLAT_SKIP_OPTEE_S_EL1_INT_REGISTER)) ```
The Contributor’s Guide indicates that it requires a Microsoft Github account, so I opted to post a patch to this list.
Cheers, Diederik
PS: https://developer.trustedfirmware.org/ seems to be full of spam; you may want to look into that.
-- TF-A mailing list -- tf-a@lists.trustedfirmware.org To unsubscribe send an email to tf-a-leave@lists.trustedfirmware.org
Hi,
On Friday, 24 November 2023 10:12:36 CET Olivier Deprez wrote:
The Contributor’s Guide indicates that it requires a Microsoft Github account,
Reviews happens in https://review.trustedfirmware.org Yes you need a github account id to post a change for review.
I know that reviews happen there, but I have a problem with Microsoft Github. So I hope someone else will submit this fix to resolve the warning.
Thanks for reporting. Note you may preferably report issues to the github interface https://github.com/TrustedFirmware-A/trusted-firmware-a/issues
I'm glad there was another option (this ML), so that I could (still) report the issue.
Cheers, Diederik
Hi,
See the change https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/25171
Regards, Olivier.
________________________________________ From: Diederik de Haas didi.trustedfirmware@cknow.org Sent: 24 November 2023 12:11 To: tf-a@lists.trustedfirmware.org; tony.xie@rock-chips.com; Olivier Deprez Subject: Re: [TF-A] rk3328: WARNING: BL31: cortex_a53: CPU workaround for 1530924 was missing!
Hi,
On Friday, 24 November 2023 10:12:36 CET Olivier Deprez wrote:
The Contributor’s Guide indicates that it requires a Microsoft Github account,
Reviews happens in https://review.trustedfirmware.org Yes you need a github account id to post a change for review.
I know that reviews happen there, but I have a problem with Microsoft Github. So I hope someone else will submit this fix to resolve the warning.
Thanks for reporting. Note you may preferably report issues to the github interface https://github.com/TrustedFirmware-A/trusted-firmware-a/issues
I'm glad there was another option (this ML), so that I could (still) report the issue.
Cheers, Diederik
On Monday, 27 November 2023 10:27:23 CET Olivier Deprez wrote:
See the change https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/25171
Thanks!
Cheers, Diederik
tf-a@lists.trustedfirmware.org
-
Diederik de Haas -
Olivier Deprez