New Defects reported by Coverity Scan for ARM-software/arm-trusted-firmware - TF-A

1 Nov 2021


      Hi,
Please find the latest report on new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
3 new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 373791:  Control flow issues  (DEADCODE)
/drivers/usb/usb_device.c: 646 in usb_core_receive()
________________________________________________________________________________________________________
*** CID 373791:  Control flow issues  (DEADCODE)
/drivers/usb/usb_device.c: 646 in usb_core_receive()
640     	ep->is_in = false;
641     	ep->num = num;
642     
643     	if (num == 0U) {
644     		pdev->driver->ep0_start_xfer(hpcd->instance, ep);
645     	} else {
...
...
...
CID 373791:  Control flow issues  (DEADCODE)
Execution cannot reach this statement: "(*pdev->driver->ep_start_xf...".

646     		pdev->driver->ep_start_xfer(hpcd->instance, ep);
647     	}
648     
649     	return USBD_OK;
650     }
651
** CID 373790:  Null pointer dereferences  (FORWARD_NULL)
/drivers/usb/usb_device.c: 182 in usb_core_set_config()
________________________________________________________________________________________________________
*** CID 373790:  Null pointer dereferences  (FORWARD_NULL)
/drivers/usb/usb_device.c: 182 in usb_core_set_config()
176     		} else if (cfgidx != pdev->dev_config) {
177     			if (pdev->class != NULL) {
178     				usb_core_ctl_error(pdev);
179     				return;
180     			}
181     			/* Clear old configuration */
...
...
...
CID 373790:  Null pointer dereferences  (FORWARD_NULL)
Dereferencing null pointer "pdev->class".

182     			pdev->class->de_init(pdev, pdev->dev_config);
183     			/* Set new configuration */
184     			pdev->dev_config = cfgidx;
185     			/* Set configuration and start the USB class */
186     			if (pdev->class->init(pdev, cfgidx) != 0U) {
187     				usb_core_ctl_error(pdev);
** CID 373789:  Control flow issues  (DEADCODE)
/drivers/usb/usb_device.c: 684 in usb_core_transmit()
________________________________________________________________________________________________________
*** CID 373789:  Control flow issues  (DEADCODE)
/drivers/usb/usb_device.c: 684 in usb_core_transmit()
678     	ep->is_in = true;
679     	ep->num = num;
680     
681     	if (num == 0U) {
682     		pdev->driver->ep0_start_xfer(hpcd->instance, ep);
683     	} else {
...
...
...
CID 373789:  Control flow issues  (DEADCODE)
Execution cannot reach this statement: "(*pdev->driver->ep_start_xf...".

684     		pdev->driver->ep_start_xfer(hpcd->instance, ep);
685     	}
686     
687     	return USBD_OK;
688     }
689
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...