NOTICE messages should require higher LOG_LEVEL than WARN, not the other way around.
Signed-off-by: Baruch Siach baruch@tkos.co.il Change-Id: Iba9c67cafed19be47e7d03198faa98fbf99a10ee ---
I still can't upload to review.trustedfirmware.org so I'm once again sending to the list instead.
https://lists.trustedfirmware.org/archives/list/tf-a@lists.trustedfirmware.o... --- tools/cert_create/include/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/cert_create/include/debug.h b/tools/cert_create/include/debug.h index ee8f1f51786f..8f7c62eefe2d 100644 --- a/tools/cert_create/include/debug.h +++ b/tools/cert_create/include/debug.h @@ -20,8 +20,8 @@
#define LOG_LEVEL_NONE 0 #define LOG_LEVEL_ERROR 10 -#define LOG_LEVEL_NOTICE 20 -#define LOG_LEVEL_WARNING 30 +#define LOG_LEVEL_WARNING 20 +#define LOG_LEVEL_NOTICE 30 #define LOG_LEVEL_INFO 40 #define LOG_LEVEL_VERBOSE 50
SAVE_KEYS is set to '0' by default, casing cert_create to show the 'Key filename not specified' message on each run even though this is perfectly normal. Show the message only in the VERBOSE log level.
Signed-off-by: Baruch Siach baruch@tkos.co.il Change-Id: I472cdec2670055ab0edd99d172f79d01ad575972 --- tools/cert_create/src/key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/cert_create/src/key.c b/tools/cert_create/src/key.c index 487777b67046..27ec979ebb7e 100644 --- a/tools/cert_create/src/key.c +++ b/tools/cert_create/src/key.c @@ -212,7 +212,7 @@ int key_load(key_t *key, unsigned int *err_code) *err_code = KEY_ERR_OPEN; } } else { - WARN("Key filename not specified\n"); + VERBOSE("Key filename not specified\n"); *err_code = KEY_ERR_FILENAME; }
Hi Baruch,
I have uploaded your patches to review.trustedfirmware.org and they are now in review: https://review.trustedfirmware.org/q/topic:%22cert-create%22+(status:open%20...).
Thanks! Lauren
-----Original Message----- From: Baruch Siach baruch@tkos.co.il Sent: Sunday, January 29, 2023 9:40 AM To: Sandrine Bailleux Sandrine.Bailleux@arm.com; Manish Badarkhe Manish.Badarkhe@arm.com; Lauren Wehrmeister Lauren.Wehrmeister@arm.com Cc: tf-a@lists.trustedfirmware.org; Baruch Siach baruch@tkos.co.il Subject: [PATCH 2/2] fix(cert-create): demote missing key filename message
SAVE_KEYS is set to '0' by default, casing cert_create to show the 'Key filename not specified' message on each run even though this is perfectly normal. Show the message only in the VERBOSE log level.
Signed-off-by: Baruch Siach baruch@tkos.co.il Change-Id: I472cdec2670055ab0edd99d172f79d01ad575972 --- tools/cert_create/src/key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/cert_create/src/key.c b/tools/cert_create/src/key.c index 487777b67046..27ec979ebb7e 100644 --- a/tools/cert_create/src/key.c +++ b/tools/cert_create/src/key.c @@ -212,7 +212,7 @@ int key_load(key_t *key, unsigned int *err_code) *err_code = KEY_ERR_OPEN; } } else { - WARN("Key filename not specified\n"); + VERBOSE("Key filename not specified\n"); *err_code = KEY_ERR_FILENAME; }
-- 2.39.0
tf-a@lists.trustedfirmware.org
-
Baruch Siach -
Lauren Wehrmeister