Hello Pankaj,
I reviewed most of the patches and posted my comments. Honestly, it is very hard to review these large commits.
It would have been very helpful if these were smaller incremental commits.
-Varun
From: Pankaj Gupta pankaj.gupta@nxp.com Sent: Tuesday, March 31, 2020 11:09 AM To: Varun Wadekar vwadekar@nvidia.com; Joanna Farley Joanna.Farley@arm.com Cc: tf-a@lists.trustedfirmware.org Subject: Re: [TF-A] [EXT] Patch-set review request: New NXP Platform LX2120ARDB support on TFA
External email: Use caution opening links or attachments
Hi Varun, Thanks for the initial review comments. Yes, I looking for review comments on entire patch series. Regards Pankaj From: Varun Wadekar Sent: Tuesday, 31 March, 22:55 Subject: RE: [TF-A] [EXT] Patch-set review request: New NXP Platform LX2120ARDB support on TFA To: Joanna Farley, Pankaj Gupta Cc: tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org
Caution: EXT Email Hello Pankaj,
Hope you are doing well.
The initial email point to one change, but I see that as the tip of a patch series. I reviewed https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3370https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-A%2Ftrusted-firmware-a%2F%2B%2F3370&data=02%7C01%7Cpankaj.gupta%40nxp.com%7C271ee35db3244cfec45308d7d59875c7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637212723105186437&sdata=o6SXfRVx2g2agX2KvUBSV7OIV2s6r%2FwmClQqxhVh%2F%2FA%3D&reserved=0 and left some comments, but did not review the complete patch series.
Are you requesting a review of the entire patch series?
-Varun
From: TF-A <tf-a-bounces@lists.trustedfirmware.orgmailto:tf-a-bounces@lists.trustedfirmware.org> On Behalf Of Joanna Farley via TF-A Sent: Tuesday, March 31, 2020 9:37 AM To: Pankaj Gupta <pankaj.gupta@nxp.commailto:pankaj.gupta@nxp.com>; tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org Subject: Re: [TF-A] [EXT] Patch-set review request: New NXP Platform LX2120ARDB support on TFA
External email: Use caution opening links or attachments
Hi Pankaj,
We will try, one of the arm team has done some +1 reviews and I have just kicked of a CI+2 run on the top of the patch stack. As you can imagine the Arm team is pressed for time the closer to the freeze date.
Other TF-A contributors you all have +1 rights so if folks have time assistance with further +1 reviews would be appreciated as that would help in accelerating confidence is getting +2 and merging.
Traditionally the project has relied on Arm folks but for some time now all contributors have had +1 rights on each other patches and the new project maintenance proposal is set up to take us in the direction of enabling all contributors helping each other.
Thanks
Joanna
From: TF-A <tf-a-bounces@lists.trustedfirmware.orgmailto:tf-a-bounces@lists.trustedfirmware.org> on behalf of Pankaj Gupta via TF-A <tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org> Reply to: Pankaj Gupta <pankaj.gupta@nxp.commailto:pankaj.gupta@nxp.com> Date: Monday, 30 March 2020 at 20:48 To: "tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org" <tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org> Subject: Re: [TF-A] [EXT] Patch-set review request: New NXP Platform LX2120ARDB support on TFA
Please find the link to the review request. https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3370https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-A%2Ftrusted-firmware-a%2F%2B%2F3370&data=02%7C01%7Cpankaj.gupta%40nxp.com%7C271ee35db3244cfec45308d7d59875c7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637212723105196428&sdata=ZGT%2B4XbowuquO9nIoK8u3v3lbOY2t17D8cwG3Nymibk%3D&reserved=0 Regards Pankaj From: Pankaj Gupta via TF-A Sent: Monday, 30 March, 22:57 Subject: [EXT] [TF-A] Patch-set review request: New NXP Platform LX2120ARDB support on TFA To: tf-a@lists.trustedfirmware.orgmailto:tf-a@lists.trustedfirmware.org Caution: EXT Email Hi All,
Please pick this review request so that code changes can be merged before code freeze.
Thanks.
Regards Pankaj IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.