Hi Sumit,
On 3/2/20 10:37 AM, Sumit Garg wrote:
I hope that I am able to address almost every comment with updated patch-set [1].
Thanks for reworking the patches, they look mostly good from my point of view. The last remaining item would be to address the MISRA violations that Coverity found, which I've copied & pasted for you on Gerrit in the top patch.
I know Soby might still have some concerns, he will let you know the details soon.
So, would it be possible to have this feature incorporated in upcoming TF-A v2.3 release?
I think this is a reasonable target.
One thing, though. I think it's fair to say that this patch stack is quite complex and interacts with lots of different parts of TF-A. I personally don't think I have the full picture in my head yet.
Also, this feature is only used on QEMU right now and I am not aware of anyone trying to enable it for their platforms just yet. Thus there is a risk we might have overlooked some issues that we'll discover at that time.
Furthermore, I know that you've done some testing of this feature on QEMU but this is not integrated into the CI loop right now. Thus, there is a risk that we might break it in the future and this will go unnoticed, unless you plan to test it regularly on your end.
For all these reasons, I would feel more comfortable if the feature was tagged as experimental for now. Would you be open to that?
We already have such experimental features in the tree like BTI, some part of PAuth, measured boot, DebugFS. Marking a feature as experimental mostly just lowers the users expectations, telling them that they are using this code at their own risks. It also means we don't provide any stability guarantees just yet and that we might break compatibility without any notice in order to make the interfaces and implementation evolve as we see fit.
Marking a feature as experimental is usually done by: * Saying so in the documentation. * Having the build system print a warning message when using the build flags enabling the experimental feature. * Saying so in the (upcoming) change log.
Regards, Sandrine