Re: [TF-M] FW: TF-Mv1.3.0-RC1 => build with IARARM 8.5.4 failed - TF-M

30 Mar 2021

      Hi Anton,
Is it these issues that is causing the problems?
---
In file included from 
..\platform\ext\accelerator\stm......\ext\target\stm\common\stm32l5xx\Device\Include\stm32l5xx.h:106:
..\platform\ext\accelerator\stm......\ext\target\stm\common\stm32l5xx\Device\Include/stm32l562xx.h:1808:13: 
warning: parameter 'pointer' not found in the function declaration 
[-Wdocumentation]
   * @param  pointer on the vector table containing the reset handler 
the function
             ^~~~~~~
..\platform\ext\accelerator\stm......\ext\target\stm\common\stm32l5xx\Device\Include/stm32l562xx.h:1808:13: 
note: did you mean 'VectorTableAddr'?
   * @param  pointer on the vector table containing the reset handler 
the function
             ^~~~~~~
             VectorTableAddr
..\platform\ext\target\stm\common\stm32l5xx\accelerator\rsa_alt.c:353:17: 
warning: parameter 'dP' not found in the function declaration 
[-Wdocumentation]
  * @param[in]   dP           pΓÇÖs CRT exponent
                 ^~
..\platform\ext\target\stm\common\stm32l5xx\accelerator\rsa_alt.c:353:17: 
note: did you mean 'dp'?
  * @param[in]   dP           pΓÇÖs CRT exponent
                 ^~
                 dp
..\platform\ext\target\stm\common\stm32l5xx\accelerator\rsa_alt.c:354:17: 
warning: parameter 'dQ' not found in the function declaration 
[-Wdocumentation]
  * @param[in]   dQ           qΓÇÖs CRT exponent
                 ^~
..\platform\ext\target\stm\common\stm32l5xx\accelerator\rsa_alt.c:354:17: 
note: did you mean 'dp'?
  * @param[in]   dQ           qΓÇÖs CRT exponent
                 ^~
                 dp
..\platform\ext\target\stm\common\stm32l5xx\accelerator\rsa_alt.c:1185:24: 
warning: unused parameter 'p_rng' [-Wunused-parameter]
                  void *p_rng,
                        ^
4 warnings generated.
---
This has nothing to do with my patch but seems related to:
PS 
C:\Users\thomasto\Projects\tf-m8\trusted-firmware-m\platform\ext\target\stm\common\stm32l5xx\accelerator> 
git log rsa_alt.c
commit 1ea82c0329f45204868df20a3bd8627286c0cdaa
Author: Michel Jaouen michel.jaouen@st.com
Date:   Mon Jan 25 15:18:21 2021 +0100
Platform: stm: Add crypto accelerator support
Change-Id: I7c0686c6f6470bebc7f258af125272d28bc4ce84
     Signed-off-by: Michel Jaouen michel.jaouen@st.com
If it is not that issue, then please elaborate as I get exactly the same 
result with or without my patch when building with armclang.
/Thomas
[
Den 2021-03-30 kl. 13:27, skrev Anton Komlev via TF-M:
...
Hi Michel, Thomas,
The fix 
https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/9455 
https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/9455fails 
for armclang. Please check the CI test.
If it’s important feature of the release then could you check and fix 
it? Let me know if we can progress with RC3 without waiting for the fix.
Thanks,
Anton
*From:*TF-M tf-m-bounces@lists.trustedfirmware.org *On Behalf Of 
*Michel JAOUEN via TF-M
*Sent:* Monday, March 29, 2021 9:08 PM
*To:* tf-m@lists.trustedfirmware.org
*Subject:* Re: [TF-M] FW: TF-Mv1.3.0-RC1 => build with IARARM 8.5.4 failed
Thanks , it solved.
Best Regards
Michel
*From:*TF-M <tf-m-bounces@lists.trustedfirmware.org 
mailto:tf-m-bounces@lists.trustedfirmware.org> *On Behalf Of *Thomas 
Törnblom via TF-M
*Sent:* lundi 29 mars 2021 17:37
*To:* tf-m@lists.trustedfirmware.org 
mailto:tf-m@lists.trustedfirmware.org
*Subject:* Re: [TF-M] FW: TF-Mv1.3.0-RC1 => build with IARARM 8.5.4 failed
Apparently I have not tested this before.
Check the fix at:
https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/9455 
https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/9455
/Thomas
Den 2021-03-29 kl. 16:35, skrev Michel JAOUEN via TF-M:
Sure

Variable $tfm_work point to trustedfirmware local dir.

Here is my command

cmake -S . -B build_dir  -G"Unix Makefiles"

-DTFM_PLATFORM=stm/stm32l562e_dk

-DTFM_TOOLCHAIN_FILE=$tfm_work/toolchain_IARARM.cmake

-DCMAKE_BUILD_TYPE=RelWithDebInfo

-DTEST_S=ON -DTEST_NS=ON -DTFM_PSA_API=ON -DTFM_ISOLATION_LEVEL=2

Best regards

Michel

*From:*TF-M <tf-m-bounces@lists.trustedfirmware.org
<mailto:tf-m-bounces@lists.trustedfirmware.org>> *On Behalf Of
*Thomas Törnblom via TF-M
*Sent:* lundi 29 mars 2021 16:06
*To:* tf-m@lists.trustedfirmware.org
<mailto:tf-m@lists.trustedfirmware.org>
*Subject:* Re: [TF-M] TF-Mv1.3.0-RC1 => build with IARARM 8.5.4 failed

Hi Michel,

Can you provide the cmake line and I'll have a look.

That argument looks like a gcc argument not recognized by the IAR
tools.

Cheers,
Thomas

Den 2021-03-29 kl. 15:34, skrev Michel JAOUEN via TF-M:

    Hello,

    I got the following build issue when I build with IARAR, it
    occurs when build mbed-crypto

      IAR ANSI C/C++ Compiler V8.50.4.261/W32 for ARM

       Copyright 1999-2020 IAR Systems AB.

       Network license: 10.157.2.156 (STD)

    Command line error: Unexpected command line arguments:

    -Wno-unused-parameter

    Does someone else reproduce the issue ?

    Best regards

-- 

*Thomas Törnblom*, /Product Engineer/
IAR Systems AB
Box 23051, Strandbodgatan 1
SE-750 23 Uppsala, SWEDEN
Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
E-mail: thomas.tornblom@iar.com
<mailto:thomas.tornblom@iar.com>Website: www.iar.com
<http://www.iar.com>
Twitter: www.twitter.com/iarsystems
<http://www.twitter.com/iarsystems>

--
*Thomas Törnblom*, /Product Engineer/
IAR Systems AB
Box 23051, Strandbodgatan 1
SE-750 23 Uppsala, SWEDEN
Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
E-mail: thomas.tornblom@iar.com 
mailto:thomas.tornblom@iar.comWebsite: www.iar.com http://www.iar.com
Twitter: www.twitter.com/iarsystems http://www.twitter.com/iarsystems
-- 

*Thomas Törnblom*, /Product Engineer/
IAR Systems AB
Box 23051, Strandbodgatan 1
SE-750 23 Uppsala, SWEDEN
Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
E-mail: thomas.tornblom@iar.com mailto:thomas.tornblom@iar.com 
Website: www.iar.com http://www.iar.com
Twitter: www.twitter.com/iarsystems http://www.twitter.com/iarsystems