Hmm, what startup code does this for armclang and gnuarm?

I don't see anything obvious in startup_psoc64_ns.[sS] for armclang or gnuarm.

If there's a difference, I'd like to fix it the same for IAR too.

Cheers, Thomas

Den 2021-03-01 kl. 06:52, skrev David Hu:

Hi Thomas,

It seems to be related to the startup assembly code. It was reported by Alamy.

Dual-cpu NS mailbox relies on some RTOS modules, which shall be initialized after RTX kernel starts. Armclang and GNUARM startup assembly code already calls kernel start function. Therefore the ordering of NS mailbox init and RTX kernel init doesn’t matter.

I guess IAR startup code doesn’t call the additional kernel start function.

This change has already included by the tf-m-tests version specified in TF-M configuration. Could you please update your TF-M version a bit?

Best regards,

Hu Ziji

*From:* Thomas Törnblom thomas.tornblom@iar.com *Sent:* Monday, March 1, 2021 12:52 PM *To:* David Hu David.Hu@arm.com *Cc:* tf-m@lists.trustedfirmware.org; nd nd@arm.com *Subject:* Re: [TF-M] Please update TFM_TEST_REPO_VERSION

Hi David,

It fixed a runtime problem with psoc64 when building with IAR.

I don’t understand why ARMCLANG and GNUARM builds seems to have been unaffected.

Cheers,

Thomas

1 mars 2021 kl. 03:35 skrev David Hu <david.hu@arm.com
<mailto:david.hu@arm.com>>:



Hi Thomas,

Sorry for the trouble.

Could you let me know whether this change brought some problems or
it fixed something?

Best regards,

Hu Ziji

*From:* TF-M <tf-m-bounces@lists.trustedfirmware.org
<mailto:tf-m-bounces@lists.trustedfirmware.org>> *On Behalf Of
*Thomas Törnblom via TF-M
*Sent:* Friday, February 26, 2021 6:03 PM
*To:* tf-m@lists.trustedfirmware.org
<mailto:tf-m@lists.trustedfirmware.org>
*Subject:* [TF-M] Please update TFM_TEST_REPO_VERSION

For some reason it seems that IAR is the only toolchain affected by:
https://git.trustedfirmware.org/TF-M/tf-m-tests.git/commit/app/main_ns.c?id=4ae00fe
<https://git.trustedfirmware.org/TF-M/tf-m-tests.git/commit/app/main_ns.c?id=4ae00fe>

Can we please update update the version to at least 4ae00fe?

Cheers,
Thomas

-- 

*Thomas Törnblom*, /Product Engineer/
IAR Systems AB
Box 23051, Strandbodgatan 1
SE-750 23 Uppsala, SWEDEN
Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
E-mail: thomas.tornblom@iar.com
<mailto:thomas.tornblom@iar.com>Website: www.iar.com
<http://www.iar.com>
Twitter: www.twitter.com/iarsystems
<http://www.twitter.com/iarsystems>

Thanks David,

I have added just early os initialization to CMSIS_5, see https://github.com/ARM-software/CMSIS_5/pull/1136

Unfortunately this will not help until it is integrated and used with tf-m.

Cheers, Thomas

Den 2021-03-01 kl. 09:42, skrev David Hu:

Hi Thomas,

I find out this reference: https://github.com/ARM-software/CMSIS_5/issues/718 https://github.com/ARM-software/CMSIS_5/issues/718.

As the page said, RTX osKernelInitialize() is already called at the very early stage before C main(), with Armclang and GCC toolchain. Therefore the ordering of osKernelInitialize() and NS mailbox init doesn’t matter in C main() with Armclang or GCC toolchain.

IMO, the issue was caused by the incorrect sequence of osKernelInitialize() and NS mailbox in the RTX example (my bad 😝 ). It is unnecessary to adjust anything for IAR.

It is a RTX specific implementation.

Best regards,

Hu Ziji

*From:* Thomas Törnblom thomas.tornblom@iar.com *Sent:* Monday, March 1, 2021 3:30 PM *To:* David Hu David.Hu@arm.com *Cc:* tf-m@lists.trustedfirmware.org; nd nd@arm.com *Subject:* Re: [TF-M] Please update TFM_TEST_REPO_VERSION

Hmm, what startup code does this for armclang and gnuarm?

I don't see anything obvious in startup_psoc64_ns.[sS] for armclang or gnuarm.

If there's a difference, I'd like to fix it the same for IAR too.

Cheers, Thomas

Den 2021-03-01 kl. 06:52, skrev David Hu:

Hi Thomas,

It seems to be related to the startup assembly code. It was
reported by Alamy.

Dual-cpu NS mailbox relies on some RTOS modules, which shall be
initialized after RTX kernel starts. Armclang and GNUARM startup
assembly code already calls kernel start function. Therefore the
ordering of NS mailbox init and RTX kernel init doesn’t matter.

I guess IAR startup code doesn’t call the additional kernel start
function.

This change has already included by the tf-m-tests version
specified in TF-M configuration. Could you please update your TF-M
version a bit?

Best regards,

Hu Ziji

*From:* Thomas Törnblom <thomas.tornblom@iar.com>
<mailto:thomas.tornblom@iar.com>
*Sent:* Monday, March 1, 2021 12:52 PM
*To:* David Hu <David.Hu@arm.com> <mailto:David.Hu@arm.com>
*Cc:* tf-m@lists.trustedfirmware.org
<mailto:tf-m@lists.trustedfirmware.org>; nd <nd@arm.com>
<mailto:nd@arm.com>
*Subject:* Re: [TF-M] Please update TFM_TEST_REPO_VERSION

Hi David,

It fixed a runtime problem with psoc64 when building with IAR.

I don’t understand why ARMCLANG and GNUARM builds seems to have
been unaffected.

Cheers,

Thomas




    1 mars 2021 kl. 03:35 skrev David Hu <david.hu@arm.com
    <mailto:david.hu@arm.com>>:

    

    Hi Thomas,

    Sorry for the trouble.

    Could you let me know whether this change brought some
    problems or it fixed something?

    Best regards,

    Hu Ziji

    *From:* TF-M <tf-m-bounces@lists.trustedfirmware.org
    <mailto:tf-m-bounces@lists.trustedfirmware.org>> *On Behalf Of
    *Thomas Törnblom via TF-M
    *Sent:* Friday, February 26, 2021 6:03 PM
    *To:* tf-m@lists.trustedfirmware.org
    <mailto:tf-m@lists.trustedfirmware.org>
    *Subject:* [TF-M] Please update TFM_TEST_REPO_VERSION

    For some reason it seems that IAR is the only toolchain
    affected by:
    https://git.trustedfirmware.org/TF-M/tf-m-tests.git/commit/app/main_ns.c?id=4ae00fe
    <https://git.trustedfirmware.org/TF-M/tf-m-tests.git/commit/app/main_ns.c?id=4ae00fe>

    Can we please update update the version to at least 4ae00fe?

    Cheers,
    Thomas

    -- 

    *Thomas Törnblom*, /Product Engineer/
    IAR Systems AB
    Box 23051, Strandbodgatan 1
    SE-750 23 Uppsala, SWEDEN
    Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
    E-mail: thomas.tornblom@iar.com
    <mailto:thomas.tornblom@iar.com>Website: www.iar.com
    <http://www.iar.com>
    Twitter: www.twitter.com/iarsystems
    <http://www.twitter.com/iarsystems>

--

*Thomas Törnblom*, /Product Engineer/ IAR Systems AB Box 23051, Strandbodgatan 1 SE-750 23 Uppsala, SWEDEN Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01 E-mail: thomas.tornblom@iar.com mailto:thomas.tornblom@iar.comWebsite: www.iar.com http://www.iar.com Twitter: www.twitter.com/iarsystems http://www.twitter.com/iarsystems

Hi David,

Yes, 4ae00fe fixes the issue for IAR.

Cheers, Thomas

2 mars 2021 kl. 13:31 skrev David Hu david.hu@arm.com:

 Hi Thomas,

Does the latest TF-M with tf-m-tests work in your use case, without the patch to CMSIS?

Best regards, Hu Ziji

From: Thomas Törnblom thomas.tornblom@iar.com Sent: Monday, March 1, 2021 9:29 PM To: David Hu David.Hu@arm.com Cc: tf-m@lists.trustedfirmware.org; nd nd@arm.com Subject: Re: [TF-M] Please update TFM_TEST_REPO_VERSION

Thanks David,

I have added just early os initialization to CMSIS_5, see https://github.com/ARM-software/CMSIS_5/pull/1136

Unfortunately this will not help until it is integrated and used with tf-m.

Cheers, Thomas Den 2021-03-01 kl. 09:42, skrev David Hu: Hi Thomas,

I find out this reference: https://github.com/ARM-software/CMSIS_5/issues/718. As the page said, RTX osKernelInitialize() is already called at the very early stage before C main(), with Armclang and GCC toolchain. Therefore the ordering of osKernelInitialize() and NS mailbox init doesn’t matter in C main() with Armclang or GCC toolchain.

IMO, the issue was caused by the incorrect sequence of osKernelInitialize() and NS mailbox in the RTX example (my bad 😝 ). It is unnecessary to adjust anything for IAR. It is a RTX specific implementation.

Best regards, Hu Ziji

From: Thomas Törnblom thomas.tornblom@iar.commailto:thomas.tornblom@iar.com Sent: Monday, March 1, 2021 3:30 PM To: David Hu David.Hu@arm.commailto:David.Hu@arm.com Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org; nd nd@arm.commailto:nd@arm.com Subject: Re: [TF-M] Please update TFM_TEST_REPO_VERSION

Hmm, what startup code does this for armclang and gnuarm?

I don't see anything obvious in startup_psoc64_ns.[sS] for armclang or gnuarm.

If there's a difference, I'd like to fix it the same for IAR too.

Cheers, Thomas Den 2021-03-01 kl. 06:52, skrev David Hu: Hi Thomas,

It seems to be related to the startup assembly code. It was reported by Alamy. Dual-cpu NS mailbox relies on some RTOS modules, which shall be initialized after RTX kernel starts. Armclang and GNUARM startup assembly code already calls kernel start function. Therefore the ordering of NS mailbox init and RTX kernel init doesn’t matter. I guess IAR startup code doesn’t call the additional kernel start function.

This change has already included by the tf-m-tests version specified in TF-M configuration. Could you please update your TF-M version a bit?

Best regards, Hu Ziji

From: Thomas Törnblom thomas.tornblom@iar.commailto:thomas.tornblom@iar.com Sent: Monday, March 1, 2021 12:52 PM To: David Hu David.Hu@arm.commailto:David.Hu@arm.com Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org; nd nd@arm.commailto:nd@arm.com Subject: Re: [TF-M] Please update TFM_TEST_REPO_VERSION

Hi David,

It fixed a runtime problem with psoc64 when building with IAR. I don’t understand why ARMCLANG and GNUARM builds seems to have been unaffected.

Cheers, Thomas

1 mars 2021 kl. 03:35 skrev David Hu <david.hu@arm.commailto:david.hu@arm.com>:  Hi Thomas,

Sorry for the trouble. Could you let me know whether this change brought some problems or it fixed something?

Best regards, Hu Ziji

From: TF-M <tf-m-bounces@lists.trustedfirmware.orgmailto:tf-m-bounces@lists.trustedfirmware.org> On Behalf Of Thomas Törnblom via TF-M Sent: Friday, February 26, 2021 6:03 PM To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: [TF-M] Please update TFM_TEST_REPO_VERSION

For some reason it seems that IAR is the only toolchain affected by: https://git.trustedfirmware.org/TF-M/tf-m-tests.git/commit/app/main_ns.c?id=...

Can we please update update the version to at least 4ae00fe?

Cheers, Thomas --

Thomas Törnblom, Product Engineer IAR Systems AB Box 23051, Strandbodgatan 1 SE-750 23 Uppsala, SWEDEN Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01 E-mail: thomas.tornblom@iar.commailto:thomas.tornblom@iar.com Website: www.iar.comhttp://www.iar.com Twitter: www.twitter.com/iarsystemshttp://www.twitter.com/iarsystems

--

Thomas Törnblom, Product Engineer IAR Systems AB Box 23051, Strandbodgatan 1 SE-750 23 Uppsala, SWEDEN Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01 E-mail: thomas.tornblom@iar.commailto:thomas.tornblom@iar.com Website: www.iar.comhttp://www.iar.com Twitter: www.twitter.com/iarsystemshttp://www.twitter.com/iarsystems

--

Thomas Törnblom, Product Engineer IAR Systems AB Box 23051, Strandbodgatan 1 SE-750 23 Uppsala, SWEDEN Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01 E-mail: thomas.tornblom@iar.commailto:thomas.tornblom@iar.com Website: www.iar.comhttp://www.iar.com Twitter: www.twitter.com/iarsystemshttp://www.twitter.com/iarsystems