Hi Chris,
It is an excellent suggestion.
Out-of-tree Secure Partition build can help integrate secure test service. Non-secure tests are a bit limited due to current tf-m-tests framework right now. Do you prefer to run platform-specific tests alone or still integrate platform-specific tests into TF-M regression tests?
Best regards, Hu Ziji
From: TF-M tf-m-bounces@lists.trustedfirmware.org On Behalf Of chris.brand--- via TF-M Sent: Tuesday, August 24, 2021 11:46 PM To: tf-m@lists.trustedfirmware.org Subject: Re: [TF-M] [RFC] Decoupling tf-m-tests from TF-M
Just wondering if any though has been given to supporting platform-specific tests?
Chris
From: TF-M <tf-m-bounces@lists.trustedfirmware.orgmailto:tf-m-bounces@lists.trustedfirmware.org> On Behalf Of David Hu via TF-M Sent: Tuesday, August 24, 2021 3:21 AM To: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: Re: [TF-M] [RFC] Decoupling tf-m-tests from TF-M
Caution: This e-mail originated outside Infineon Technologies. Do not click on links or open attachments unless you validate it is safehttps://intranet-content.infineon.com/explore/aboutinfineon/rules/informationsecurity/ug/SocialEngineering/Pages/SocialEngineeringElements_en.aspx.
Hi Andrej,
Thanks for the suggestion. Sure. I will track it in the backlog.
Currently Jianliang and I are more focusing on the structure level enhancement. But definitely later we will take more effort in the detailed optimizations.
Please let us know any time if any other potential issue shall be optimized.
Best regards, Hu Ziji
From: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Sent: Tuesday, August 24, 2021 6:15 PM To: David Hu <David.Hu@arm.commailto:David.Hu@arm.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
Hi Hu Zij,
Thank you for adding possibility to select test cases flexibly.
Also, there are about 10 "test" services/partitions in addition to the core PSA ones. But every instance allocates own resources, which can be shared. Guess, merging these 10 test services, which have a common structure, can save some memory.
Thank you, Andrej
From: David Hu <David.Hu@arm.commailto:David.Hu@arm.com> Sent: Tuesday, August 24, 2021 11:54 AM To: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
Hi Andrej,
Sorry for the trouble. It does be an issue when TF-M features and test cases are growing faster.
So now TF-M support to select a single test case or a subset of test cases to build and run. If running all the tests together costs too much memory, you can select some test cases or just a single one in one time. It is also helpful when you focus on a specific test in debug or development.
We are also considering other additional mechanisms to select test case flexibly.
Regarding "merging existing ones", do you mean that some test cases shall be disabled by default or combining the similar test cases? May I ask for some examples?
Best regards, Hu Ziji
From: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Sent: Tuesday, August 24, 2021 5:44 PM To: David Hu <David.Hu@arm.commailto:David.Hu@arm.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
Hi Hu Ziji,
BTW: The number of the testing partitions and services is growing consuming memory resources. So, we have to disable some tests for our memory constrained devices.
Please think about minimizing number of "testing" partitions/services, by merging existing ones, when it is possible.
Thank you,
Andrej Butok SW Tech Lead Edge Processing NXP Semiconductors
From: TF-M <tf-m-bounces@lists.trustedfirmware.orgmailto:tf-m-bounces@lists.trustedfirmware.org> On Behalf Of David Hu via TF-M Sent: Tuesday, August 24, 2021 11:33 AM To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Cc: nd <nd@arm.commailto:nd@arm.com> Subject: [TF-M] [RFC] Decoupling tf-m-tests from TF-M
Hi all,
As you may know, Jianliang and I are working to better decouple tf-m-tests from trusted-firmware-m repo. The purpose of the decoupling enhancement includes:
* Making it more easier to integrate TF-M and port tf-m-tests * Making it more easier to develop TF-M tests, to minimize the changes to TF-M source code or build system. * Making it more flexible to re-structure tf-m-tests and minimize the impact to TF-M
Previously Jianliang has decouple test case control and enable users to select single NS/S regression test case in build and test.
Currently we are focusing on decoupling tf-m-tests specific config setting from TF-M. So far we have proposed the following major changes:
* Decouple tf-m-tests specific config setting from trusted-firmware-m.
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F11167&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282391370%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=BA47iuxbPW8qZJwgqv5WGwU4ffWPiIr%2B0aDx%2BuBlSz4%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F11169%2F1&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282401330%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=tciYw4Vy5Wt4uBSU%2BeWcNtghtdHH2tr9djAqknBP5SI%3D&reserved=0]
* Move tf-m-tests specific configs to tf-m-tests repo from trusted-firmware-m
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F10647&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282411281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=0xZhh4GhSOWxgWv4AReRKAhG7Wts1sY%2Boh96ECdU2Gc%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F10556&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282411281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=LK0YBInNVb4gjfAwBTxU9n96te%2BQrx1V5isyPM7wO6M%3D&reserved=0] More patch sets for decoupling are under review as well.
* Decouple tf-m-tests secure log from non-secure log. Switch tf-m-tests secure log to TF-M SP log.
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F11153&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282411281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=xaXA5K3RKr9cb%2BVp%2BV3i3hsAanraYf12IOQMBPuVzAY%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F11131%2F3&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282421238%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=mMUq%2BIpVWHBjgTCSHkdtHxROpBYUopAkIC4q94zsDso%3D&reserved=0]
* Trigger secure regression tests in TF-M SPE in IPC model, to simplify multi-core development/tests
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F11181&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282421238%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=JK1xvWFyrtgM5QbP0bMAOxfEIvJwmen8AB3eTQbOhlw%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F11182&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282431192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=MaADzhBh%2F6sY%2F90E3hfqCLk7w6nipeEyP8GdAwTNaCw%3D&reserved=0]
I'd appreciate it if you can take a look at the patch sets above. Any suggestion or comment is welcome. If you have any specific requirement or suggestion of tf-m-tests enhancement, please feel free to contact Jianliang and me. Thanks in advance.
Best regards, Hu Ziji
From a very high-level perspective, it would be nice to have test/test_services/platform under which any platform-specific test services could live. More importantly, a platform-specific directory for tests under test/suites somewhere would be nice - there's already test/suites/platform, but that is aimed at testing the platform service itself. I imagine that there could be both platform-specific parts of the platform test as well as platform-specific test suites.
The key advantage of being able to upstream platform-specific tests is for regression testing to pick up breakages from changes made elsewhere (assuming the platform itself is integrated into the TFM CI loop).
Chris
From: David Hu David.Hu@arm.com Sent: Wednesday, August 25, 2021 1:18 AM To: Brand Chris (CSCA CSS ICW SW PSW 1) Chris.Brand@infineon.com; tf-m@lists.trustedfirmware.org Cc: nd nd@arm.com Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
Caution: This e-mail originated outside Infineon Technologies. Do not click on links or open attachments unless you validate it is safehttps://intranet-content.infineon.com/explore/aboutinfineon/rules/informationsecurity/ug/SocialEngineering/Pages/SocialEngineeringElements_en.aspx.
Hi Chris,
It is an excellent suggestion.
Out-of-tree Secure Partition build can help integrate secure test service. Non-secure tests are a bit limited due to current tf-m-tests framework right now. Do you prefer to run platform-specific tests alone or still integrate platform-specific tests into TF-M regression tests?
Best regards, Hu Ziji
From: TF-M <tf-m-bounces@lists.trustedfirmware.orgmailto:tf-m-bounces@lists.trustedfirmware.org> On Behalf Of chris.brand--- via TF-M Sent: Tuesday, August 24, 2021 11:46 PM To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: Re: [TF-M] [RFC] Decoupling tf-m-tests from TF-M
Just wondering if any though has been given to supporting platform-specific tests?
Chris
From: TF-M <tf-m-bounces@lists.trustedfirmware.orgmailto:tf-m-bounces@lists.trustedfirmware.org> On Behalf Of David Hu via TF-M Sent: Tuesday, August 24, 2021 3:21 AM To: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: Re: [TF-M] [RFC] Decoupling tf-m-tests from TF-M
Caution: This e-mail originated outside Infineon Technologies. Do not click on links or open attachments unless you validate it is safehttps://intranet-content.infineon.com/explore/aboutinfineon/rules/informationsecurity/ug/SocialEngineering/Pages/SocialEngineeringElements_en.aspx.
Hi Andrej,
Thanks for the suggestion. Sure. I will track it in the backlog.
Currently Jianliang and I are more focusing on the structure level enhancement. But definitely later we will take more effort in the detailed optimizations.
Please let us know any time if any other potential issue shall be optimized.
Best regards, Hu Ziji
From: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Sent: Tuesday, August 24, 2021 6:15 PM To: David Hu <David.Hu@arm.commailto:David.Hu@arm.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
Hi Hu Zij,
Thank you for adding possibility to select test cases flexibly.
Also, there are about 10 "test" services/partitions in addition to the core PSA ones. But every instance allocates own resources, which can be shared. Guess, merging these 10 test services, which have a common structure, can save some memory.
Thank you, Andrej
From: David Hu <David.Hu@arm.commailto:David.Hu@arm.com> Sent: Tuesday, August 24, 2021 11:54 AM To: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
Hi Andrej,
Sorry for the trouble. It does be an issue when TF-M features and test cases are growing faster.
So now TF-M support to select a single test case or a subset of test cases to build and run. If running all the tests together costs too much memory, you can select some test cases or just a single one in one time. It is also helpful when you focus on a specific test in debug or development.
We are also considering other additional mechanisms to select test case flexibly.
Regarding "merging existing ones", do you mean that some test cases shall be disabled by default or combining the similar test cases? May I ask for some examples?
Best regards, Hu Ziji
From: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Sent: Tuesday, August 24, 2021 5:44 PM To: David Hu <David.Hu@arm.commailto:David.Hu@arm.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
Hi Hu Ziji,
BTW: The number of the testing partitions and services is growing consuming memory resources. So, we have to disable some tests for our memory constrained devices.
Please think about minimizing number of "testing" partitions/services, by merging existing ones, when it is possible.
Thank you,
Andrej Butok SW Tech Lead Edge Processing NXP Semiconductors
From: TF-M <tf-m-bounces@lists.trustedfirmware.orgmailto:tf-m-bounces@lists.trustedfirmware.org> On Behalf Of David Hu via TF-M Sent: Tuesday, August 24, 2021 11:33 AM To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Cc: nd <nd@arm.commailto:nd@arm.com> Subject: [TF-M] [RFC] Decoupling tf-m-tests from TF-M
Hi all,
As you may know, Jianliang and I are working to better decouple tf-m-tests from trusted-firmware-m repo. The purpose of the decoupling enhancement includes:
* Making it more easier to integrate TF-M and port tf-m-tests * Making it more easier to develop TF-M tests, to minimize the changes to TF-M source code or build system. * Making it more flexible to re-structure tf-m-tests and minimize the impact to TF-M
Previously Jianliang has decouple test case control and enable users to select single NS/S regression test case in build and test.
Currently we are focusing on decoupling tf-m-tests specific config setting from TF-M. So far we have proposed the following major changes:
* Decouple tf-m-tests specific config setting from trusted-firmware-m.
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F11167&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282391370%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=BA47iuxbPW8qZJwgqv5WGwU4ffWPiIr%2B0aDx%2BuBlSz4%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F11169%2F1&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282401330%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=tciYw4Vy5Wt4uBSU%2BeWcNtghtdHH2tr9djAqknBP5SI%3D&reserved=0]
* Move tf-m-tests specific configs to tf-m-tests repo from trusted-firmware-m
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F10647&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282411281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=0xZhh4GhSOWxgWv4AReRKAhG7Wts1sY%2Boh96ECdU2Gc%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F10556&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282411281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=LK0YBInNVb4gjfAwBTxU9n96te%2BQrx1V5isyPM7wO6M%3D&reserved=0] More patch sets for decoupling are under review as well.
* Decouple tf-m-tests secure log from non-secure log. Switch tf-m-tests secure log to TF-M SP log.
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F11153&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282411281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=xaXA5K3RKr9cb%2BVp%2BV3i3hsAanraYf12IOQMBPuVzAY%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F11131%2F3&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282421238%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=mMUq%2BIpVWHBjgTCSHkdtHxROpBYUopAkIC4q94zsDso%3D&reserved=0]
* Trigger secure regression tests in TF-M SPE in IPC model, to simplify multi-core development/tests
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F11181&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282421238%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=JK1xvWFyrtgM5QbP0bMAOxfEIvJwmen8AB3eTQbOhlw%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F11182&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282431192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=MaADzhBh%2F6sY%2F90E3hfqCLk7w6nipeEyP8GdAwTNaCw%3D&reserved=0]
I'd appreciate it if you can take a look at the patch sets above. Any suggestion or comment is welcome. If you have any specific requirement or suggestion of tf-m-tests enhancement, please feel free to contact Jianliang and me. Thanks in advance.
Best regards, Hu Ziji
Hi Chris,
Thanks. The structure looks very promising. I suppose it won't be a ground-breaking change. Will propose a solution later.
Best regards, Hu Ziji
From: Chris.Brand@infineon.com Chris.Brand@infineon.com Sent: Thursday, August 26, 2021 1:27 AM To: David Hu David.Hu@arm.com; tf-m@lists.trustedfirmware.org Cc: nd nd@arm.com Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
From a very high-level perspective, it would be nice to have test/test_services/platform under which any platform-specific test services could live. More importantly, a platform-specific directory for tests under test/suites somewhere would be nice - there's already test/suites/platform, but that is aimed at testing the platform service itself. I imagine that there could be both platform-specific parts of the platform test as well as platform-specific test suites.
The key advantage of being able to upstream platform-specific tests is for regression testing to pick up breakages from changes made elsewhere (assuming the platform itself is integrated into the TFM CI loop).
Chris
From: David Hu <David.Hu@arm.commailto:David.Hu@arm.com> Sent: Wednesday, August 25, 2021 1:18 AM To: Brand Chris (CSCA CSS ICW SW PSW 1) <Chris.Brand@infineon.commailto:Chris.Brand@infineon.com>; tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Cc: nd <nd@arm.commailto:nd@arm.com> Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
Caution: This e-mail originated outside Infineon Technologies. Do not click on links or open attachments unless you validate it is safehttps://intranet-content.infineon.com/explore/aboutinfineon/rules/informationsecurity/ug/SocialEngineering/Pages/SocialEngineeringElements_en.aspx.
Hi Chris,
It is an excellent suggestion.
Out-of-tree Secure Partition build can help integrate secure test service. Non-secure tests are a bit limited due to current tf-m-tests framework right now. Do you prefer to run platform-specific tests alone or still integrate platform-specific tests into TF-M regression tests?
Best regards, Hu Ziji
From: TF-M <tf-m-bounces@lists.trustedfirmware.orgmailto:tf-m-bounces@lists.trustedfirmware.org> On Behalf Of chris.brand--- via TF-M Sent: Tuesday, August 24, 2021 11:46 PM To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: Re: [TF-M] [RFC] Decoupling tf-m-tests from TF-M
Just wondering if any though has been given to supporting platform-specific tests?
Chris
From: TF-M <tf-m-bounces@lists.trustedfirmware.orgmailto:tf-m-bounces@lists.trustedfirmware.org> On Behalf Of David Hu via TF-M Sent: Tuesday, August 24, 2021 3:21 AM To: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: Re: [TF-M] [RFC] Decoupling tf-m-tests from TF-M
Caution: This e-mail originated outside Infineon Technologies. Do not click on links or open attachments unless you validate it is safehttps://intranet-content.infineon.com/explore/aboutinfineon/rules/informationsecurity/ug/SocialEngineering/Pages/SocialEngineeringElements_en.aspx.
Hi Andrej,
Thanks for the suggestion. Sure. I will track it in the backlog.
Currently Jianliang and I are more focusing on the structure level enhancement. But definitely later we will take more effort in the detailed optimizations.
Please let us know any time if any other potential issue shall be optimized.
Best regards, Hu Ziji
From: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Sent: Tuesday, August 24, 2021 6:15 PM To: David Hu <David.Hu@arm.commailto:David.Hu@arm.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
Hi Hu Zij,
Thank you for adding possibility to select test cases flexibly.
Also, there are about 10 "test" services/partitions in addition to the core PSA ones. But every instance allocates own resources, which can be shared. Guess, merging these 10 test services, which have a common structure, can save some memory.
Thank you, Andrej
From: David Hu <David.Hu@arm.commailto:David.Hu@arm.com> Sent: Tuesday, August 24, 2021 11:54 AM To: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
Hi Andrej,
Sorry for the trouble. It does be an issue when TF-M features and test cases are growing faster.
So now TF-M support to select a single test case or a subset of test cases to build and run. If running all the tests together costs too much memory, you can select some test cases or just a single one in one time. It is also helpful when you focus on a specific test in debug or development.
We are also considering other additional mechanisms to select test case flexibly.
Regarding "merging existing ones", do you mean that some test cases shall be disabled by default or combining the similar test cases? May I ask for some examples?
Best regards, Hu Ziji
From: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com> Sent: Tuesday, August 24, 2021 5:44 PM To: David Hu <David.Hu@arm.commailto:David.Hu@arm.com> Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: RE: [RFC] Decoupling tf-m-tests from TF-M
Hi Hu Ziji,
BTW: The number of the testing partitions and services is growing consuming memory resources. So, we have to disable some tests for our memory constrained devices.
Please think about minimizing number of "testing" partitions/services, by merging existing ones, when it is possible.
Thank you,
Andrej Butok SW Tech Lead Edge Processing NXP Semiconductors
From: TF-M <tf-m-bounces@lists.trustedfirmware.orgmailto:tf-m-bounces@lists.trustedfirmware.org> On Behalf Of David Hu via TF-M Sent: Tuesday, August 24, 2021 11:33 AM To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Cc: nd <nd@arm.commailto:nd@arm.com> Subject: [TF-M] [RFC] Decoupling tf-m-tests from TF-M
Hi all,
As you may know, Jianliang and I are working to better decouple tf-m-tests from trusted-firmware-m repo. The purpose of the decoupling enhancement includes:
* Making it more easier to integrate TF-M and port tf-m-tests * Making it more easier to develop TF-M tests, to minimize the changes to TF-M source code or build system. * Making it more flexible to re-structure tf-m-tests and minimize the impact to TF-M
Previously Jianliang has decouple test case control and enable users to select single NS/S regression test case in build and test.
Currently we are focusing on decoupling tf-m-tests specific config setting from TF-M. So far we have proposed the following major changes:
* Decouple tf-m-tests specific config setting from trusted-firmware-m.
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F11167&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282391370%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=BA47iuxbPW8qZJwgqv5WGwU4ffWPiIr%2B0aDx%2BuBlSz4%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F11169%2F1&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282401330%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=tciYw4Vy5Wt4uBSU%2BeWcNtghtdHH2tr9djAqknBP5SI%3D&reserved=0]
* Move tf-m-tests specific configs to tf-m-tests repo from trusted-firmware-m
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F10647&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282411281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=0xZhh4GhSOWxgWv4AReRKAhG7Wts1sY%2Boh96ECdU2Gc%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F10556&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282411281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=LK0YBInNVb4gjfAwBTxU9n96te%2BQrx1V5isyPM7wO6M%3D&reserved=0] More patch sets for decoupling are under review as well.
* Decouple tf-m-tests secure log from non-secure log. Switch tf-m-tests secure log to TF-M SP log.
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F11153&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282411281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=xaXA5K3RKr9cb%2BVp%2BV3i3hsAanraYf12IOQMBPuVzAY%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F11131%2F3&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282421238%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=mMUq%2BIpVWHBjgTCSHkdtHxROpBYUopAkIC4q94zsDso%3D&reserved=0]
* Trigger secure regression tests in TF-M SPE in IPC model, to simplify multi-core development/tests
[TF-M patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F11181&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282421238%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=JK1xvWFyrtgM5QbP0bMAOxfEIvJwmen8AB3eTQbOhlw%3D&reserved=0][tf-m-tests patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftf-m-tests%2F%2B%2F11182&data=04%7C01%7Candrey.butok%40nxp.com%7C1a063e22dce1438b50b208d966e5101d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637653956282431192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=MaADzhBh%2F6sY%2F90E3hfqCLk7w6nipeEyP8GdAwTNaCw%3D&reserved=0]
I'd appreciate it if you can take a look at the patch sets above. Any suggestion or comment is welcome. If you have any specific requirement or suggestion of tf-m-tests enhancement, please feel free to contact Jianliang and me. Thanks in advance.
Best regards, Hu Ziji
tf-m@lists.trustedfirmware.org
-
Chris.Brand＠infineon.com -
David Hu