Hi,
I noticed this build warning with PSA_FRAMEWORK_HAS_MM_IOVEC enabled. runtime_defs.h need to be updated to add the `const` qualifier I think.
tfm/secure_fw/spm/core/psa_interface_thread_fn_call.c:287:33: warning: initialization of 'void * (*)(psa_handle_t, uint32_t)' {aka 'void * (*)(long int, long unsigned int)'} from incompatible pointer type 'const void * (*)(psa_handle_t, uint32_t)' {aka 'const void * (*)(long int, long unsigned int)'} [-Wincompatible-pointer-types] 287 | psa_map_invec_thread_fn_call, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /tfm/secure_fw/spm/core/psa_interface_thread_fn_call.c:287:33: note: (near initialization for 'psa_api_thread_fn_call.psa_map_invec')
Regards,
Brian Quach SimpleLink MCU Texas Instruments Inc.
Hi Brian,
Yes, the function pointer is declared with the incorrect type. I have made a fix here: https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/28595
Let me know if that works for you.
Kind regards, Jamie
From: Quach, Brian via TF-M tf-m@lists.trustedfirmware.org Sent: Friday, April 26, 2024 6:58 PM To: tf-m@lists.trustedfirmware.org Subject: [TF-M] build warning with PSA_FRAMEWORK_HAS_MM_IOVEC
Hi,
I noticed this build warning with PSA_FRAMEWORK_HAS_MM_IOVEC enabled. runtime_defs.h need to be updated to add the `const` qualifier I think.
tfm/secure_fw/spm/core/psa_interface_thread_fn_call.c:287:33: warning: initialization of 'void * (*)(psa_handle_t, uint32_t)' {aka 'void * (*)(long int, long unsigned int)'} from incompatible pointer type 'const void * (*)(psa_handle_t, uint32_t)' {aka 'const void * (*)(long int, long unsigned int)'} [-Wincompatible-pointer-types] 287 | psa_map_invec_thread_fn_call, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /tfm/secure_fw/spm/core/psa_interface_thread_fn_call.c:287:33: note: (near initialization for 'psa_api_thread_fn_call.psa_map_invec')
Regards,
Brian Quach SimpleLink MCU Texas Instruments Inc.
Hi Jamie,
That looks good. Thanks for fixing it.
Regards, Brian
From: Jamie Fox Jamie.Fox@arm.com Sent: Monday, April 29, 2024 11:07 AM To: Quach, Brian brian@ti.com; tf-m@lists.trustedfirmware.org Subject: [EXTERNAL] RE: build warning with PSA_FRAMEWORK_HAS_MM_IOVEC
Hi Brian, Yes, the function pointer is declared with the incorrect type. I have made a fix here: https: //review. trustedfirmware. org/c/TF-M/trusted-firmware-m/+/28595 Let me know if that works for you. Kind regards, Jamie From: Quach, Brian ZjQcmQRYFpfptBannerStart This message was sent from outside of Texas Instruments.
Do not click links or open attachments unless you recognize the source of this email and know the content is safe. If you wish to report this message to IT Security, please forward the message as an attachment to phishing@list.ti.commailto:phishing@list.ti.com
ZjQcmQRYFpfptBannerEnd Hi Brian,
Yes, the function pointer is declared with the incorrect type. I have made a fix here: https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/28595https://urldefense.com/v3/__https:/review.trustedfirmware.org/c/TF-M/trusted-firmware-m/*/28595__;Kw!!G3vK!VoHdsZcL2Tei_N6YpL28dBYe_xq4od79oTcHnsTbEKQRBm1kNNrAy4F4rwJOt4GvlTgMQrQO9Q$
Let me know if that works for you.
Kind regards, Jamie
From: Quach, Brian via TF-M <tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org> Sent: Friday, April 26, 2024 6:58 PM To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Subject: [TF-M] build warning with PSA_FRAMEWORK_HAS_MM_IOVEC
Hi,
I noticed this build warning with PSA_FRAMEWORK_HAS_MM_IOVEC enabled. runtime_defs.h need to be updated to add the `const` qualifier I think.
tfm/secure_fw/spm/core/psa_interface_thread_fn_call.c:287:33: warning: initialization of 'void * (*)(psa_handle_t, uint32_t)' {aka 'void * (*)(long int, long unsigned int)'} from incompatible pointer type 'const void * (*)(psa_handle_t, uint32_t)' {aka 'const void * (*)(long int, long unsigned int)'} [-Wincompatible-pointer-types] 287 | psa_map_invec_thread_fn_call, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /tfm/secure_fw/spm/core/psa_interface_thread_fn_call.c:287:33: note: (near initialization for 'psa_api_thread_fn_call.psa_map_invec')
Regards,
Brian Quach SimpleLink MCU Texas Instruments Inc.
tf-m@lists.trustedfirmware.org
-
Jamie Fox -
Quach, Brian