[Thread res-used, title renamed]
Hi all,
This is now happening - fully support non-CMake use of the manifest tool. Here is the patch: https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/15756
With this patch, the manifest tool takes build configurations from a config header file instead of replying on the build system. Please check the details in the patch. Any comments are welcome.
Best Regards, Kevin
-----Original Message----- From: Andrej Butok andrey.butok@nxp.com Sent: Thursday, May 12, 2022 2:49 PM To: Kevin Peng Kevin.Peng@arm.com; Raef Coles Raef.Coles@arm.com Cc: tf-m@lists.trustedfirmware.org Subject: RE: Any usage of environment variables in manifest lists
If there are strong requirements on supporting the non-cmake usecase
Yes, it is 😉
-----Original Message----- From: Kevin Peng via TF-M tf-m@lists.trustedfirmware.org Sent: Thursday, May 12, 2022 5:46 AM To: Kevin Peng Kevin.Peng@arm.com; Raef Coles Raef.Coles@arm.com; tf-m@lists.trustedfirmware.org Cc: nd nd@arm.com Subject: [TF-M] Re: Any usage of environment variables in manifest lists
Well, I think I figured out a way to decouple them. If there are strong requirements on supporting the non-cmake usecase, I can try to work it out.
Best Regards, Kevin
-----Original Message----- From: Kevin Peng via TF-M tf-m@lists.trustedfirmware.org Sent: Thursday, May 12, 2022 10:09 AM To: Raef Coles Raef.Coles@arm.com; tf-m@lists.trustedfirmware.org Cc: nd nd@arm.com Subject: [TF-M] Re: Any usage of environment variables in manifest lists
Yes. The manifest tool is now fully replying on CMake (it has been, since I introduced the conditional parsing of manifests around half a year ago). It needs to be aware of the build configurations.
Best Regards, Kevin
-----Original Message----- From: Raef Coles Raef.Coles@arm.com Sent: Wednesday, May 11, 2022 7:15 PM To: tf-m@lists.trustedfirmware.org; Kevin Peng Kevin.Peng@arm.com Cc: nd nd@arm.com Subject: Re: Any usage of environment variables in manifest lists
Hey Kevin
Does this mean that cmake will be required to generate the headers/etc from the manifests?
I believe in the past we deliberately supported the non-cmake usecase, as some people were building TF-M in alternate ways.
Raef
________________________________________ From: Kevin Peng via TF-M tf-m@lists.trustedfirmware.org Sent: 11 May 2022 09:24 To: tf-m@lists.trustedfirmware.org Cc: nd Subject: [TF-M] Any usage of environment variables in manifest lists
Hi,
Is there anyone using environment variables for the "manifest" attribute in out-of-tree manifest lists? I'm asking because I'm working to support configurable stack_size for Secure Partitionshttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F15155&data=05%7C01%7Candrey.butok%40nxp.com%7C59891c1aedad496db1ca08da33ca0d85%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637879240155943848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kE7GiN7rZuysYnzkaGY6kDl3mZliFjI8wrBhzt%2BSXUk%3D&reserved=0. In the patch the support of environment variables in manifest lists is removedhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F15155%2F1%2Ftools%2Ftfm_parse_manifest_list.py%23b256&data=05%7C01%7Candrey.butok%40nxp.com%7C59891c1aedad496db1ca08da33ca0d85%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637879240155943848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=hxdW7%2B8ai%2FGEfNxoAVWo3ChREbO%2B3BdEKEr10CQ9UAQ%3D&reserved=0. Because I have to call the CMake command configure_file to replace the stack_size symbols (CMake variableshttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F15155%2F1%2Fsecure_fw%2Fpartitions%2Fcrypto%2Ftfm_crypto.yaml%2315&data=05%7C01%7Candrey.butok%40nxp.com%7C59891c1aedad496db1ca08da33ca0d85%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637879240155943848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2B7qjxc%2Bs1sM2SLwM4vVmb%2FQeHVrpN0U8RrwiMKLSWJg%3D&reserved=0 surrounded with "@") with their values. While configure_file does not recognize environment variables.
If you do have environment variables in manifest list, there is an alternative: Replace the env. variables with CMake variables surrounded with "@" and set the value of the CMake variables in either config files or command line inputs.
Best Regards, Kevin
-- TF-M mailing list -- tf-m@lists.trustedfirmware.org To unsubscribe send an email to tf-m-leave@lists.trustedfirmware.org -- TF-M mailing list -- tf-m@lists.trustedfirmware.org To unsubscribe send an email to tf-m-leave@lists.trustedfirmware.org
Hi,
The patch has been merged.
From the users’ perspective, how the TF-M build system works is not changed.
For non-CMake users, please refer to the newly added user guidehttps://tf-m-user-guide.trustedfirmware.org/integration_guide/services/tfm_manifest_tool_user_guide.html for details.
Note that ongoing patches must be rebased to avoid CI failures because there is a dependency change in the test repo.
Best Regards,
Kevin
-----Original Message----- From: Kevin Peng via TF-M tf-m@lists.trustedfirmware.org Sent: Monday, July 4, 2022 11:01 AM To: tf-m@lists.trustedfirmware.org Subject: [TF-M] [RFC]Decoupling manifest tool with build system
[Thread res-used, title renamed]
Hi all,
This is now happening - fully support non-CMake use of the manifest tool.
Here is the patch:
https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/15756
With this patch, the manifest tool takes build configurations from a config header file instead of replying on the build system.
Please check the details in the patch.
Any comments are welcome.
Best Regards,
Kevin
-----Original Message-----
From: Andrej Butok <andrey.butok@nxp.commailto:andrey.butok@nxp.com>
Sent: Thursday, May 12, 2022 2:49 PM
To: Kevin Peng <Kevin.Peng@arm.commailto:Kevin.Peng@arm.com>; Raef Coles <Raef.Coles@arm.commailto:Raef.Coles@arm.com>
Cc: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org
Subject: RE: Any usage of environment variables in manifest lists
If there are strong requirements on supporting the non-cmake usecase
Yes, it is 😉
-----Original Message-----
From: Kevin Peng via TF-M <tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org>
Sent: Thursday, May 12, 2022 5:46 AM
To: Kevin Peng <Kevin.Peng@arm.commailto:Kevin.Peng@arm.com>; Raef Coles <Raef.Coles@arm.commailto:Raef.Coles@arm.com>; tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org
Cc: nd <nd@arm.commailto:nd@arm.com>
Subject: [TF-M] Re: Any usage of environment variables in manifest lists
Well, I think I figured out a way to decouple them.
If there are strong requirements on supporting the non-cmake usecase, I can try to work it out.
Best Regards,
Kevin
-----Original Message-----
From: Kevin Peng via TF-M <tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org>
Sent: Thursday, May 12, 2022 10:09 AM
To: Raef Coles <Raef.Coles@arm.commailto:Raef.Coles@arm.com>; tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org
Cc: nd <nd@arm.commailto:nd@arm.com>
Subject: [TF-M] Re: Any usage of environment variables in manifest lists
Yes.
The manifest tool is now fully replying on CMake (it has been, since I introduced the conditional parsing of manifests around half a year ago).
It needs to be aware of the build configurations.
Best Regards,
Kevin
-----Original Message-----
From: Raef Coles <Raef.Coles@arm.commailto:Raef.Coles@arm.com>
Sent: Wednesday, May 11, 2022 7:15 PM
To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org; Kevin Peng <Kevin.Peng@arm.commailto:Kevin.Peng@arm.com>
Cc: nd <nd@arm.commailto:nd@arm.com>
Subject: Re: Any usage of environment variables in manifest lists
Hey Kevin
Does this mean that cmake will be required to generate the headers/etc from the manifests?
I believe in the past we deliberately supported the non-cmake usecase, as some people were building TF-M in alternate ways.
Raef
________________________________________
From: Kevin Peng via TF-M <tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org>
Sent: 11 May 2022 09:24
To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org
Cc: nd
Subject: [TF-M] Any usage of environment variables in manifest lists
Hi,
Is there anyone using environment variables for the "manifest" attribute in out-of-tree manifest lists?
I'm asking because I'm working to support configurable stack_size for Secure Partitionshttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F15155&data=05%7C01%7Candrey.butok%40nxp.com%7C59891c1aedad496db1ca08da33ca0d85%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637879240155943848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kE7GiN7rZuysYnzkaGY6kDl3mZliFjI8wrBhzt%2BSXUk%3D&reserved=0.
In the patch the support of environment variables in manifest lists is removedhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F15155%2F1%2Ftools%2Ftfm_parse_manifest_list.py%23b256&data=05%7C01%7Candrey.butok%40nxp.com%7C59891c1aedad496db1ca08da33ca0d85%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637879240155943848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=hxdW7%2B8ai%2FGEfNxoAVWo3ChREbO%2B3BdEKEr10CQ9UAQ%3D&reserved=0.
Because I have to call the CMake command configure_file to replace the stack_size symbols (CMake variableshttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fc%2FTF-M%2Ftrusted-firmware-m%2F%2B%2F15155%2F1%2Fsecure_fw%2Fpartitions%2Fcrypto%2Ftfm_crypto.yaml%2315&data=05%7C01%7Candrey.butok%40nxp.com%7C59891c1aedad496db1ca08da33ca0d85%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637879240155943848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2B7qjxc%2Bs1sM2SLwM4vVmb%2FQeHVrpN0U8RrwiMKLSWJg%3D&reserved=0 surrounded with "@") with their values.
While configure_file does not recognize environment variables.
If you do have environment variables in manifest list, there is an alternative:
Replace the env. variables with CMake variables surrounded with "@" and set the value of the CMake variables in either config files or command line inputs.
Best Regards,
Kevin
--
TF-M mailing list -- tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org To unsubscribe send an email to tf-m-leave@lists.trustedfirmware.orgmailto:tf-m-leave@lists.trustedfirmware.org
--
TF-M mailing list -- tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org To unsubscribe send an email to tf-m-leave@lists.trustedfirmware.orgmailto:tf-m-leave@lists.trustedfirmware.org
--
TF-M mailing list -- tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org To unsubscribe send an email to tf-m-leave@lists.trustedfirmware.orgmailto:tf-m-leave@lists.trustedfirmware.org
tf-m@lists.trustedfirmware.org
-
Kevin Peng