Agree with David that a single rule is better than multiple exceptions. Thanks, Kevin for the good approach: Recommend to stay within 100 CPL everywhere but accept up to 140 if it really necessary.
Cheers, Anton
From: Kevin Peng <Kevin.Peng@arm.commailto:Kevin.Peng@arm.com> Sent: Wednesday, August 3, 2022 4:40 AM To: David Hu <David.Hu@arm.commailto:David.Hu@arm.com>; Ken Liu <Ken.Liu@arm.commailto:Ken.Liu@arm.com>; Anton Komlev <Anton.Komlev@arm.commailto:Anton.Komlev@arm.com>; tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Cc: nd <nd@arm.commailto:nd@arm.com> Subject: RE: Proposal for coding standard update: Increase chars per line 80-> 128.
How about setting to the limitation as large as possible and then having some recommendations/guidelines. For example, The limit is 140 for all - no exception. For SPM - recommend to keep in 100. For others - recommend to keep in 120.
I guess in most cases, developers wouldn't try to use up all the limitations. Sometimes, it's about being only over several characters that is very annoying.
Best Regards, Kevin
From: David Hu via TF-M <tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org> Sent: Wednesday, August 3, 2022 10:38 AM To: Ken Liu <Ken.Liu@arm.commailto:Ken.Liu@arm.com>; Anton Komlev <Anton.Komlev@arm.commailto:Anton.Komlev@arm.com>; tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Cc: nd <nd@arm.commailto:nd@arm.com> Subject: [TF-M] Re: Proposal for coding standard update: Increase chars per line 80-> 128.
Hi Anton, Ken,
It is a good idea to increase the line limit. I'd prefer to keep a single line limit in TF-M. Multiple limits may not be a good practice.
Can I suggest to set the limit to 100 chars right now, to fit both SPM and non-SPM part? Besides, in non-SPM part, exceptions can be accepted for 128 chars.
Best regards, Hu Ziji
From: Ken Liu via TF-M <tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org> Sent: Tuesday, August 2, 2022 7:16 PM To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Cc: nd <nd@arm.commailto:nd@arm.com> Subject: [TF-M] Re: Proposal for coding standard update: Increase chars per line 80-> 128.
No objections to making it a common guideline.
But I'd like to require SPM code to be in 80 as possible it could when review (In review comments) - as SPM contains some delicate logic, 80 columns would provide a better view in Gerrit to help the review.
/Ken
From: Anton Komlev via TF-M <tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org> Sent: Tuesday, August 2, 2022 6:17 PM To: tf-m@lists.trustedfirmware.orgmailto:tf-m@lists.trustedfirmware.org Cc: nd <nd@arm.commailto:nd@arm.com> Subject: [TF-M] Proposal for coding standard update: Increase chars per line 80-> 128.
Hi,
TF-M coding standardhttps://tf-m-user-guide.trustedfirmware.org/contributing/coding_guide.html mandates up to 80 characters per line. This looks a bit too restrictive nowadays with no punch cards or text terminals. I propose to increase this limit to 120 or 140 characters. Personally like 128.
Are there any thoughts or objections against it?
Thanks, Anton