Hi Kevin, Yes my email was meant to be on the mailing list. Added back on. Thanks Abhishek
-----Original Message----- From: Kevin Peng (Arm Technology China) Kevin.Peng@arm.com Sent: 21 November 2019 09:13 To: Abhishek Pandit Abhishek.Pandit@arm.com Subject: RE: Call for review on header include update
Hi Abhishek,
[I guess you are trying to reply to mailing list as well?] I think it's mostly about coding style. Most of the headers are included without any relative path in TF-M. So it's wired that lots of headers are included by a relative path, and relative to the project root make it even more unreasonable.
The reason I didn't explain it in detail is that I didn't find any documents about this code style. Of course I had discussions with some team members and they are feeling the same. So I'd like to hear more feedbacks first.
Best Regards, Kevin
-----Original Message----- From: Abhishek Pandit Abhishek.Pandit@arm.com Sent: Thursday, November 21, 2019 4:54 PM To: Kevin Peng (Arm Technology China) Kevin.Peng@arm.com Cc: nd nd@arm.com Subject: RE: Call for review on header include update
Hi Kevin, Is there something that explains why this is required? Thanks Abhishek
-----Original Message----- From: TF-M tf-m-bounces@lists.trustedfirmware.org On Behalf Of Kevin Peng (Arm Technology China) via TF-M Sent: 21 November 2019 08:38 To: tf-m@lists.trustedfirmware.org Cc: nd nd@arm.com Subject: [TF-M] Call for review on header include update
Hi,
I've proposed some patches to update the header includes in TF-M: https://review.trustedfirmware.org/q/topic:%22include_path_update%22+(status...) The idea is to remove the relative paths to TF-M root and add the necessary paths to include search list.
Any kinds of comments are welcome.
Best Regards, Kevin
-- TF-M mailing list TF-M@lists.trustedfirmware.org https://lists.trustedfirmware.org/mailman/listinfo/tf-m