Thanks for the feedback Manish. Next time I will wait a little longer before pinging reviewers on the mailing list.
On Wed, Oct 13, 2021 at 4:22 AM Manish Pandey2 Manish.Pandey2@arm.com wrote:
Hi John,
The process for getting a patch merged is mentioned https://trustedfirmware-a.readthedocs.io/en/latest/process/code-review-guide...
Regarding your patches, i ran CI yesterday and there were some static failures which you have fixed in latest version. The CI now passed and i have provided MR votes. CoR was provided by Haojian on older version of patch which needs to be provided again. Just to let you know that It is quite common that reviewers may take few days to review it again.
The guideline is, you request reviewers on gerrit first(and wait for few days) and if you don't get any replies then you can use mailing list to escalate it.
Thanks Manish
*From:* TF-A tf-a-bounces@lists.trustedfirmware.org on behalf of Jorge Troncoso via TF-A tf-a@lists.trustedfirmware.org *Sent:* 13 October 2021 01:57 *To:* John Stultz john.stultz@linaro.org *Cc:* Anand Saminathan anans@google.com; tf-a@lists.trustedfirmware.org tf-a@lists.trustedfirmware.org; John Powell John.Powell@arm.com *Subject:* Re: [TF-A] [RFC]: UFS patches
Hello! Gentle reminder, what are the next steps for getting these changes submitted?
On Mon, Oct 11, 2021 at 4:40 PM Jorge Troncoso jatron@google.com wrote:
Hi all,
Thanks for your input on the patches! I received Code-Owner-Review+1 from Haojian on all three patches. What are the next steps for getting these changes submitted?
On Wed, Oct 6, 2021 at 7:25 PM John Stultz john.stultz@linaro.org wrote:
On Wed, Oct 6, 2021 at 8:01 AM Jorge Troncoso jatron@google.com wrote:
Thanks Olivier and John for your feedback on the patches! I addressed
your comments in the CLs. Let me know if you have additional questions.
Regarding testing, we verified these changes on our own board, but I
would love to hear how your HiKey960 tests fair. Let me know if there is anything I can do to help in this area.
Yea. I'm sorry, it will be a bit of effort to get the build environment up and going and then I have to flash and test the three variants I have. I'm not sure how you can help unless you have a HiKey960.
As a next step, can I get code review from the UFS owner for the patches
linked above? Haojian?
I believe its Golden Week this week, so Haojian may be out until next week (I don't know for sure though).
thanks -john