Re: [TF-A] [PATCHv8 3/3] arm-virt: add secure pl061 for reset/power down

On Wed, 20 Jan 2021 at 09:27, Maxim Uvarov maxim.uvarov@linaro.org wrote:

Add secure pl061 for reset/power down machine from the secure world (Arm Trusted Firmware). Connect it with gpio-pwr driver.

Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org

A nit, which I raise only because you'll need a respin anyway:

• /* connect secure pl061 to gpio-pwr */
• qdev_connect_gpio_out(pl061_dev, SECURE_GPIO_REBOOT,

•                      qdev_get_gpio_in_named(gpio_pwr_dev, "reset", 0));
  

• qemu_fdt_add_subnode(vms->fdt, "/gpio-restart");

We have three different names for the same thing here: 'reboot', 'reset' and 'restart'. If we name the GPIO line SECURE_GPIO_RESET we can at least get that down to two.

thanks -- PMM