On 10/07/2019 00:15, Julius Werner wrote:
Regarding the name, `share` is a bit too generic IMO. How about the name `export` which brings in a bit more context regarding the contents in the folder ?
Yes, `export` is good as well. Uploaded a new version with that: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/1207
I realized that the AARCH32 problem can be solved the same way as the __ASSEMBLY__ problem, because there are also pre-defined macros for architectures (e.g. __aarch64__). I think doing it that way is easier that splitting it up into separate files for a one-line difference. Let me know what you think!
Thanks Julius for the patches. When I had checked this sometime ago, there was this confusion whether arm64 or aarch64 will defined various toolchain and the reasoning for a custom one. It seems now that __aarch64__ is the standardized macro for both GCC and LLVM (and armclang as well) which is pretty much all of the toolchains we care about currently. Not sure about the MSFT compiler but TF-A doesn't build using that compiler.
I cannot forsee any potential problem with making the change but would like more feedback regarding this (especially from the platform maintainers). I will try reviewing the patch series during the week.
Best Regards Soby Mathew