On 29.09.20 08:11, Kostya Porotchkin wrote:
Hi, Jan,
-----Original Message----- From: Jan Kiszka jan.kiszka@web.de Sent: Monday, September 28, 2020 22:55 To: tf-a@lists.trustedfirmware.org; Kostya Porotchkin kostap@marvell.com Subject: [EXT] a80x0_mcbin doesn't build with recommended mv-ddr- marvell
External Email
Hi all,
docs/plat/marvell/armada/build.rst says that you should use branch mv_ddr- armada-atf-mainline from [1]. But that no longer works with tf-a master. The mv-ddr-devel branch builds fine (didn't run the result, though).
What kind of error you get?
Those kind of:
plat/marvell/armada/a8k/a80x0_mcbin/board/dram_port.c:51:2: error: ‘NOT_COMBINED’ undeclared here (not in a function) 51 | NOT_COMBINED, /* ddr twin-die combined*/ | ^~~~~~~~~~~~ plat/marvell/armada/a8k/a80x0_mcbin/board/dram_port.c:52:2: error: braces around scalar initializer [-Werror] 52 | { {0} }, /* raw spd data */ | ^ plat/marvell/armada/a8k/a80x0_mcbin/board/dram_port.c:52:2: note: (near initialization for ‘board_topology_map.timing_data[0]’) plat/marvell/armada/a8k/a80x0_mcbin/board/dram_port.c:55:3: error: braces around scalar initializer [-Werror] 55 | { /* memory electrical configuration */ | ^ plat/marvell/armada/a8k/a80x0_mcbin/board/dram_port.c:55:3: note: (near initialization for ‘board_topology_map.electrical_data[0]’) plat/marvell/armada/a8k/a80x0_mcbin/board/dram_port.c:57:4: error: braces around scalar initializer [-Werror] 57 | { | ^ plat/marvell/armada/a8k/a80x0_mcbin/board/dram_port.c:57:4: note: (near initialization for ‘board_topology_map.electrical_data[0]’) plat/marvell/armada/a8k/a80x0_mcbin/board/dram_port.c:59:5: error: excess elements in scalar initializer [-Werror] 59 | MV_DDR_RTT_NOM_PARK_RZQ_DIV1 /* rtt_park 2cs */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ plat/marvell/armada/a8k/a80x0_mcbin/board/dram_port.c:59:5: note: (near initialization for ‘board_topology_map.electrical_data[0]’) plat/marvell/armada/a8k/a80x0_mcbin/board/dram_port.c:28:56: error: missing braces around initializer [-Werror=missing-braces] 28 | static struct mv_ddr_topology_map board_topology_map = { | ^ ...... 53 | {0}, /* timing parameters */ | {} ...
make CROSS_COMPILE=aarch64-linux-gnu- PLAT=a80x0_mcbin \ USE_COHERENT_MEM=0 MV_DDR_PATH=.../mv-ddr-marvell/ \ SCP_BL2=.../mrvl_scp_bl2.img
Have you tried to use full path for MV_DDR_PATH and SCP_BL2?
Just abbreviated here, those were lengthy absolute paths.
Have you defined your BL33?
When building fip, yes. For building bl31.bin, it's not needed.
Jan
PS: There are also some warnings issued:
CC drivers/arm/gic/common/gic_common.c drivers/arm/gic/common/gic_common.c:7:9: note: #pragma message: drivers/arm/gic/common/gic_common.c is deprecated, use gicv2.mk instead 7 | #pragma message __FILE__ " is deprecated, use gicv2.mk instead" | ^~~~~~~
...
In file included from drivers/marvell/comphy/phy-comphy-cp110.c:27: drivers/marvell/comphy/phy-default-porting-layer.h:14:2: warning: #warning "Using default comphy params - you may need to suit them to your board" [-Wcpp] 14 | #warning "Using default comphy params - you may need to suit them to your board" | ^~~~~~~
PPS:
AR /data/trusted-firmware-a/build/a80x0_mcbin/release/lib/libc.a \nBuilding DRAM driver ^^^
Seems like an echo without '-e'.