Hi Jorge,
I left few comments.
I think the main question is how do you test those changes?
The only board supported in TF-A which has an UFS device on PCB is the Hikey960. I assume you have your own board against which you test those changes?
As the changes are related to sensitive timings at init / identification (and changing the logic from an infinite poll loop to a finite counting loop) I sense there may be a lot of variation from one board to another, or even one flash chip to another (also depends on flash vendor). So while this may work with one particular configuration, it's difficult to tell if it scales stable to a variable number of configurations. I'll let the Hikey960 / UFS maintainer comment more if need be.
Regards, Olivier.
________________________________________ From: TF-A tf-a-bounces@lists.trustedfirmware.org on behalf of Jorge Troncoso via TF-A tf-a@lists.trustedfirmware.org Sent: 04 October 2021 17:00 To: tf-a@lists.trustedfirmware.org; Soby Mathew; Louis Mayencourt; John Stultz; Haojian Zhuang; John Powell; Anand Saminathan Subject: Re: [TF-A] [RFC]: UFS patches
Hello! Gentle reminder, can I get code review for the patches linked above?
On Fri, Oct 1, 2021 at 8:00 AM Jorge Troncoso <jatron@google.commailto:jatron@google.com> wrote: Hi all,
We made a few changes to the UFS driver. The proposed patches are posted here: https://review.trustedfirmware.org/q/topic:%22ufs_patches%22+(status:open%20...).
The patches mainly consist of the below changes: 1. Delete asserts. Return error values instead. 2. Add retry logic and timeouts. 3. Reuse ufshc_send_uic_cmd() for DME_GET and DME_SET commands.
Any feedback/comments on these patches would be greatly appreciated.
Thanks! Jorge Troncoso