Commit ef30482b4ad6 ("plat-vexpress: FF-A: update secondary core init") updated secondary core init for the vexpress platform. In the process, it used FFA_SECONDARY_EP_REGISTER with FID 0xC4000084 based on the ALP0 ABI of the spec and the TF-A upstream implementation at the time with a note that the function ID needs to updated to the one finalied in the spec and the TF-A implementation.
Assuming it is all finalised now, let us update the same with correct/ updated FID 0xC4000087.
Cc: Jens Wiklander jens.wiklander@linaro.org Cc: Olivier Deprez olivier.deprez@arm.com Cc: Balint Dobszay balint.dobszay@arm.com Signed-off-by: Sudeep Holla sudeep.holla@arm.com --- core/arch/arm/include/ffa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/core/arch/arm/include/ffa.h b/core/arch/arm/include/ffa.h index 20a009cacabd..b0d68173bf80 100644 --- a/core/arch/arm/include/ffa.h +++ b/core/arch/arm/include/ffa.h @@ -69,7 +69,7 @@ #define FFA_MEM_RECLAIM U(0x84000077) #define FFA_MEM_FRAG_RX U(0x8400007A) #define FFA_MEM_FRAG_TX U(0x8400007B) -#define FFA_SECONDARY_EP_REGISTER_64 U(0xC4000084) +#define FFA_SECONDARY_EP_REGISTER_64 U(0xC4000087)
/* Special value for traffic targeted to the Hypervisor or SPM */ #define FFA_TARGET_INFO_MBZ U(0x0)
Hi Sudeep,
On 9/24/21 6:31 PM, Sudeep Holla wrote:
Commit ef30482b4ad6 ("plat-vexpress: FF-A: update secondary core init") updated secondary core init for the vexpress platform. In the process, it used FFA_SECONDARY_EP_REGISTER with FID 0xC4000084 based on the ALP0 ABI of the spec and the TF-A upstream implementation at the time with a note that the function ID needs to updated to the one finalied in the spec and the TF-A implementation.
Assuming it is all finalised now, let us update the same with correct/ updated FID 0xC4000087.
Cc: Jens Wiklander jens.wiklander@linaro.org Cc: Olivier Deprez olivier.deprez@arm.com Cc: Balint Dobszay balint.dobszay@arm.com Signed-off-by: Sudeep Holla sudeep.holla@arm.com
core/arch/arm/include/ffa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/core/arch/arm/include/ffa.h b/core/arch/arm/include/ffa.h index 20a009cacabd..b0d68173bf80 100644 --- a/core/arch/arm/include/ffa.h +++ b/core/arch/arm/include/ffa.h @@ -69,7 +69,7 @@ #define FFA_MEM_RECLAIM U(0x84000077) #define FFA_MEM_FRAG_RX U(0x8400007A) #define FFA_MEM_FRAG_TX U(0x8400007B) -#define FFA_SECONDARY_EP_REGISTER_64 U(0xC4000084) +#define FFA_SECONDARY_EP_REGISTER_64 U(0xC4000087) /* Special value for traffic targeted to the Hypervisor or SPM */ #define FFA_TARGET_INFO_MBZ U(0x0)
Thanks for the patch. We normally don't take patches on the mailing list but via GitHub Pull Requests instead. Nevertheless, I have created PR 4886 [1] with this patch which is trivial enough that I can handle it myself I suppose (i.e., apply review/ack tags and merge if acceptable).
[1] https://github.com/OP-TEE/optee_os/pull/4886
Hi Jerome,
On Mon, Sep 27, 2021 at 01:19:40PM +0200, Jerome Forissier wrote:
Hi Sudeep,
Thanks for the patch. We normally don't take patches on the mailing list but via GitHub Pull Requests instead. Nevertheless, I have created PR 4886 [1] with this patch which is trivial enough that I can handle it myself I suppose (i.e., apply review/ack tags and merge if acceptable).
Thanks! I realised that just after sending the patch. I waited to get confirmation but you made it easy for me by creating the pull request. I will make sure to remember and do that myself next time.
Thanks again.
op-tee@lists.trustedfirmware.org
-
Jerome Forissier -
Sudeep Holla