Qualcomm platforms with a discrete TPM (dTPM) talked to it directly over a non-secure SPI channel from the kernel. Arm's Base Boot Security Requirements (BBSR) v1.4 require that access to go through TrustZone instead, so on affected Qualcomm platforms the TPM 2.0 instance is now fronted by a Trusted Application (TA) running inside Qualcomm's Trusted Execution Environment (QTEE), which talks to the dTPM (or implements an fTPM) on the kernel's behalf.
This series adds a kernel driver for that TA, built on the QCOMTEE object-IPC transport (drivers/tee/qcomtee/) already used to reach other QTEE services.
This patch series functionally depends on below(first 5 changes specially) for qtee service discovery. - https://lore.kernel.org/lkml/20261015-qcom_uefisecapp_migrate_qcomtee-v5-0-1...
Tested on Glymur-crd target with tpm2-tools utility.
Validations: - Get capabilities - Random number generator - RSA key creation, encryption and decryption.
Signed-off-by: Kuldeep Singh kuldeep.singh@oss.qualcomm.com --- Changes in v4: - Add new line before goto label(Jarkko). - Link to v3: https://patch.msgid.link/20261015-tpm_qcom_driver-v3-0-247c8e50250e@qti.qual...
Changes in v3: - Merge tpm_qcom.h into tpm_qcom.c(Amir comments) - Update return values of functions and drop certain error prints. - Define locality_arg as default value. - Add Jarkko's tag on all but drop from 2/3 as significant changes done. - Link to v2: https://patch.msgid.link/20260907-tpm_qcom_driver-v2-0-71a6b1752da8@oss.qual...
Changes in v2: - Use QCOMTEE_TPM_UID as 81 for service discovery in patch 1. - Use FIELD_GET, zero initialised array and log improvement (Konrad) - Improve commit title and other fixes (Jarkko) - Split MAINTAINERS entry as separate patch. - Link to v1: https://patch.msgid.link/20260831-tpm_qcom_driver-v1-0-6f16fa6924fa@oss.qual...
To: Amirreza Zarrabi amirreza.zarrabi@oss.qualcomm.com To: Jens Wiklander jenswi@kernel.org To: Sumit Garg sumit.garg@kernel.org To: Peter Huewe peterhuewe@gmx.de To: Jarkko Sakkinen jarkko@kernel.org To: Jason Gunthorpe jgg@ziepe.ca To: Kuldeep Singh kuldeep.singh@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org Cc: op-tee@lists.trustedfirmware.org Cc: linux-kernel@vger.kernel.org Cc: linux-integrity@vger.kernel.org
--- Kuldeep Singh (3): tee: qcomtee: Register qcom.tz.tpm service for discovery tpm: Introduce Qualcomm TPM driver MAINTAINERS: Add Qualcomm TPM driver entry
MAINTAINERS | 6 + drivers/char/tpm/Kconfig | 9 + drivers/char/tpm/Makefile | 1 + drivers/char/tpm/tpm_qcom.c | 414 ++++++++++++++++++++++++++++++++++++++ drivers/tee/qcomtee/call.c | 4 +- drivers/tee/qcomtee/qcomtee_msg.h | 2 + 6 files changed, 435 insertions(+), 1 deletion(-) --- base-commit: 2efb7a11f1aa4d2dc285fe2680cca22cb9f72f64 change-id: 20260831-tpm_qcom_driver-d21c720e73b2 prerequisite-change-id: 20260408-qcom_uefisecapp_migrate_qcomtee-13869d45e014:v5 prerequisite-patch-id: faf4520d818abf0d7533f71d9c8b9a8aade34626 prerequisite-patch-id: b487dfe2fbc076f4815dc6c73b9e68b0b78c961f prerequisite-patch-id: 9f2c4ee37ba173bdc860f253d44974379f2cf125 prerequisite-patch-id: e86905ac6289821db30fd9a17f73e276e0a88363 prerequisite-patch-id: 8777bfa2ef8344715bf972d049acb0a6ef49b136 prerequisite-patch-id: 1c7f946e770a1cbc1599f9571282c9265a6af9cd prerequisite-patch-id: 7be993abea2ca36057d9352381a5890f50996dda
Best regards, -- Kuldeep Singh kuldeep.singh@oss.qualcomm.com
Add "qcom.tz.tpm" (QCOMTEE_TPM_UID) to qtee_services[] so the TPM TA is enumerated as a TEE-bus device, allowing a client driver to bind to it via its generated UUID.
Reviewed-by: Jarkko Sakkinen jarkko@kernel.org Signed-off-by: Kuldeep Singh kuldeep.singh@oss.qualcomm.com --- drivers/tee/qcomtee/call.c | 4 +++- drivers/tee/qcomtee/qcomtee_msg.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/tee/qcomtee/call.c b/drivers/tee/qcomtee/call.c index 47d8a4f9a159..1b887da83341 100644 --- a/drivers/tee/qcomtee/call.c +++ b/drivers/tee/qcomtee/call.c @@ -747,7 +747,9 @@ static const uuid_t qtee_service_uuid_ns = UUID_INIT(0xe1b48857, 0x6154, 0x49f9,
static const struct qtee_service qtee_services[] = { { "qcom.tz.uefisecapp", - QCOMTEE_UEFI_SEC_UID } + QCOMTEE_UEFI_SEC_UID }, + { "qcom.tz.tpm", + QCOMTEE_TPM_UID } };
static void qtee_release_service(struct device *dev) diff --git a/drivers/tee/qcomtee/qcomtee_msg.h b/drivers/tee/qcomtee/qcomtee_msg.h index 9278a361dc70..9fff9dc5fffb 100644 --- a/drivers/tee/qcomtee/qcomtee_msg.h +++ b/drivers/tee/qcomtee/qcomtee_msg.h @@ -106,6 +106,8 @@ union qcomtee_msg_arg { #define QTEE_VERSION_GET_PATCH(x) ((x) >> 0 & 0xfffU)
#define QCOMTEE_UEFI_SEC_UID 413 +#define QCOMTEE_TPM_UID 81 + /* Response types as returned from qcomtee_object_invoke_ctx_invoke(). */
/* The message contains a callback request. */
On 10/19/2026 8:21 PM, Kuldeep Singh wrote:
Add "qcom.tz.tpm" (QCOMTEE_TPM_UID) to qtee_services[] so the TPM TA is enumerated as a TEE-bus device, allowing a client driver to bind to it via its generated UUID.
Reviewed-by: Jarkko Sakkinen jarkko@kernel.org Signed-off-by: Kuldeep Singh kuldeep.singh@oss.qualcomm.com
Looks fine to me.
Reviewed-by: Amirreza Zarrabi amirreza.zarrabi@oss.qualcomm.com
- Amir
drivers/tee/qcomtee/call.c | 4 +++- drivers/tee/qcomtee/qcomtee_msg.h | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/tee/qcomtee/call.c b/drivers/tee/qcomtee/call.c index 47d8a4f9a159..1b887da83341 100644 --- a/drivers/tee/qcomtee/call.c +++ b/drivers/tee/qcomtee/call.c @@ -747,7 +747,9 @@ static const uuid_t qtee_service_uuid_ns = UUID_INIT(0xe1b48857, 0x6154, 0x49f9, static const struct qtee_service qtee_services[] = { { "qcom.tz.uefisecapp",
QCOMTEE_UEFI_SEC_UID }
QCOMTEE_UEFI_SEC_UID },- { "qcom.tz.tpm",
QCOMTEE_TPM_UID }}; static void qtee_release_service(struct device *dev) diff --git a/drivers/tee/qcomtee/qcomtee_msg.h b/drivers/tee/qcomtee/qcomtee_msg.h index 9278a361dc70..9fff9dc5fffb 100644 --- a/drivers/tee/qcomtee/qcomtee_msg.h +++ b/drivers/tee/qcomtee/qcomtee_msg.h @@ -106,6 +106,8 @@ union qcomtee_msg_arg { #define QTEE_VERSION_GET_PATCH(x) ((x) >> 0 & 0xfffU) #define QCOMTEE_UEFI_SEC_UID 413 +#define QCOMTEE_TPM_UID 81
/* Response types as returned from qcomtee_object_invoke_ctx_invoke(). */ /* The message contains a callback request. */
Add a TPM chip driver for platforms where a TPM 2.0 instance is implemented by a Trusted Application (TA) running in Qualcomm's Trusted Execution Environment (QTEE), reachable over the QCOMTEE object-IPC transport.
The driver discovers the qcom.tz.tpm TEE-bus device, opens a session with the TPM TA, and register with tpm interface. This exposes the TA through the standard /dev/tpm interface and the existing tpm2 command layer. OS need not be aware underlying TPM instance is dTPM or fTPM.
Signed-off-by: Kuldeep Singh kuldeep.singh@oss.qualcomm.com --- drivers/char/tpm/Kconfig | 9 + drivers/char/tpm/Makefile | 1 + drivers/char/tpm/tpm_qcom.c | 414 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 424 insertions(+)
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig index 5f672f2c01b0..05d704ed3632 100644 --- a/drivers/char/tpm/Kconfig +++ b/drivers/char/tpm/Kconfig @@ -243,6 +243,15 @@ config TCG_FTPM_TEE help This driver proxies for firmware TPM running in TEE.
+config TCG_QCOM + tristate "Qualcomm TEE based TPM Interface" + depends on QCOMTEE + help + This driver provides interface to run TPM instances with Trustzone + having Qualcomm TPM TA running in Qualcomm TEE. + The mechanism uses the object-IPC based transport provided by + QCOMTEE. + config TCG_SVSM tristate "SNP SVSM vTPM interface" depends on AMD_MEM_ENCRYPT diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile index 5b5cdc0d32e4..471cbf49afd2 100644 --- a/drivers/char/tpm/Makefile +++ b/drivers/char/tpm/Makefile @@ -45,5 +45,6 @@ obj-$(CONFIG_TCG_CRB) += tpm_crb.o obj-$(CONFIG_TCG_ARM_CRB_FFA) += tpm_crb_ffa.o obj-$(CONFIG_TCG_VTPM_PROXY) += tpm_vtpm_proxy.o obj-$(CONFIG_TCG_FTPM_TEE) += tpm_ftpm_tee.o +obj-$(CONFIG_TCG_QCOM) += tpm_qcom.o obj-$(CONFIG_TCG_SVSM) += tpm_svsm.o obj-$(CONFIG_TCG_LOONGSON) += tpm_loongson.o diff --git a/drivers/char/tpm/tpm_qcom.c b/drivers/char/tpm/tpm_qcom.c new file mode 100644 index 000000000000..e9e4746f0004 --- /dev/null +++ b/drivers/char/tpm/tpm_qcom.c @@ -0,0 +1,414 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + * + */ + +#include <linux/bitfield.h> +#include <linux/mm.h> +#include <linux/slab.h> +#include <linux/tee.h> +#include <linux/tee_drv.h> +#include <linux/tpm.h> +#include <linux/uuid.h> + +#include "tpm.h" + +#define QCOMTEE_ROOT_OP_REG_WITH_CREDENTIALS 5 +#define QCOMTEE_OP_CLIENT_ENV_OPEN 0 +#define QCOMTEE_MSG_OBJECT_OP_MASK GENMASK(15, 0) +#define QCOMTEE_MSG_OBJECT_OP_RELEASE (QCOMTEE_MSG_OBJECT_OP_MASK - 0) + +#define QCOMTEE_TPM_OP_SEND_COMMAND 0 + +/* UID of the "qcom.tz.tpm" service */ +#define QCOMTEE_TPM_UID 81 + +/* Max buffer size supported by TPM TA */ +#define TPM_QCOM_MAX_COMMAND_SIZE SZ_4K +#define TPM_QCOM_MAX_RESPONSE_SIZE SZ_4K + +#define QCOMTEE_TPM_GET_TA_VERSION_ID 0x0001000 +#define QCOMTEE_TPM_TA_VERSION_MAJOR GENMASK(31, 16) +#define QCOMTEE_TPM_TA_VERSION_MINOR GENMASK(15, 0) + +struct tpm_qcom_ta_version_req { + u32 command_id; +} __packed; + +struct tpm_qcom_ta_version_resp { + u32 status; + u32 command_id; + u32 version_num; +} __packed; + +#define QCOMTEE_TPM_TYPE_ID 0x0080000 +#define QCOMTEE_TPM_TYPE_DTPM 0x6454504dU +#define QCOMTEE_TPM_TYPE_FTPM 0x6654504dU +#define QCOMTEE_TPM_TYPE_NONE 0x4e6f6e65U + +struct tpm_qcom_type_req { + u32 command_id; +} __packed; + +struct tpm_qcom_type_resp { + u32 command_id; + u32 status; + u32 tpm_type; +} __packed; + +/* + * dTPM SPI transfer optimization: + * TRANSFER_START before a burst of commands, TRANSFER_END once done. + */ +#define QCOMTEE_TPM_TRANSFER_ID 0x0000002 +#define QCOMTEE_TPM_TRANSFER_END 0 +#define QCOMTEE_TPM_TRANSFER_START 1 + +struct tpm_qcom_transfer_req { + u32 command_id; + u32 transfer_state; +} __packed; + +struct tpm_qcom_transfer_resp { + u32 command_id; + u32 status; +} __packed; + +struct tpm_qcom_private { + struct tpm_chip *chip; + struct device *dev; + struct tee_context *ctx; + struct tee_param_objref tpm_svc_obj; + bool is_dtpm; +}; + +/* UUID of the QTEE-bus device representing the TPM TA. */ +static const uuid_t tpm_qcom_uuid = + UUID_INIT(0xaabcb593, 0x7083, 0x5536, + 0xac, 0x27, 0x3d, 0x2d, 0x89, 0x41, 0x9d, 0xdb); + +static void tpm_qcom_release_object(struct tee_context *ctx, + struct tee_param_objref object) +{ + struct tee_ioctl_object_invoke_arg inv_arg = {}; + + inv_arg.id = object.id; + inv_arg.op = QCOMTEE_MSG_OBJECT_OP_RELEASE; + inv_arg.num_params = 0; + + tee_client_object_invoke_func(ctx, &inv_arg, NULL); +} + +static int tpm_qcom_get_client_env_obj(struct device *dev, + struct tee_context *ctx, + struct tee_param_objref *client_env_obj) +{ + struct tee_ioctl_object_invoke_arg inv_arg = {}; + struct tee_param param[2] = {}; + int ret; + + inv_arg.id = TEE_OBJREF_NULL; + inv_arg.op = QCOMTEE_ROOT_OP_REG_WITH_CREDENTIALS; + inv_arg.num_params = 2; + + param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF_INPUT; + param[0].u.objref.id = TEE_OBJREF_NULL; + param[1].attr = TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF_OUTPUT; + + ret = tee_client_object_invoke_func(ctx, &inv_arg, param); + if (ret < 0 || inv_arg.ret != 0) { + dev_err(dev, "get client env obj failed: ret=%d, invoke_ret=0x%x\n", + ret, inv_arg.ret); + return -EINVAL; + } + + *client_env_obj = param[1].u.objref; + return 0; +} + +static int tpm_qcom_get_svc_obj(struct device *dev, + struct tee_context *ctx, + struct tee_param_objref client_env_obj, + struct tee_param_objref *tpm_svc_obj) +{ + struct tee_ioctl_object_invoke_arg inv_arg = {}; + struct tee_param param[2] = {}; + u32 tpm_uid = QCOMTEE_TPM_UID; + int ret; + + inv_arg.id = client_env_obj.id; + inv_arg.op = QCOMTEE_OP_CLIENT_ENV_OPEN; + inv_arg.num_params = 2; + + param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_INPUT; + param[0].u.ubuf = (struct tee_param_ubuf){ .addr = &tpm_uid, + .size = sizeof(tpm_uid) }; + param[1].attr = TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF_OUTPUT; + + ret = tee_client_object_invoke_func(ctx, &inv_arg, param); + if (ret < 0 || inv_arg.ret != 0) { + dev_err(dev, "get TPM service obj failed: ret=%d, invoke_ret=0x%x\n", + ret, inv_arg.ret); + return -EINVAL; + } + + *tpm_svc_obj = param[1].u.objref; + return 0; +} + +static int tpm_qcom_send_command(struct tpm_qcom_private *pvt_data, + void *req, size_t req_len, void *resp, + size_t *resp_len) +{ + struct tee_ioctl_object_invoke_arg inv_arg = {}; + struct tee_param param[3] = {}; + u8 locality_arg = 0; + int ret; + + inv_arg.id = pvt_data->tpm_svc_obj.id; + inv_arg.op = QCOMTEE_TPM_OP_SEND_COMMAND; + inv_arg.num_params = 3; + + param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_INPUT; + param[0].u.ubuf = (struct tee_param_ubuf){ .addr = &locality_arg, + .size = sizeof(locality_arg) }; + param[1].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_INPUT; + param[1].u.ubuf = (struct tee_param_ubuf){ .addr = req, .size = req_len }; + param[2].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_OUTPUT; + param[2].u.ubuf = (struct tee_param_ubuf){ .addr = resp, .size = *resp_len }; + + ret = tee_client_object_invoke_func(pvt_data->ctx, &inv_arg, param); + if (ret < 0 || inv_arg.ret != 0) { + dev_err(pvt_data->dev, + "send_command invoke ret: %d, err: 0x%x\n", + ret, inv_arg.ret); + return ret ?: -EINVAL; + } + + *resp_len = param[2].u.ubuf.size; + + return 0; +} + +static int tpm_qcom_get_ta_details(struct tpm_qcom_private *pvt_data) +{ + struct tpm_qcom_ta_version_req ver_req = { + .command_id = QCOMTEE_TPM_GET_TA_VERSION_ID, + }; + struct tpm_qcom_ta_version_resp ver_resp; + size_t resp_len = sizeof(ver_resp); + struct tpm_qcom_type_req type_req = { + .command_id = QCOMTEE_TPM_TYPE_ID, + }; + struct tpm_qcom_type_resp type_resp; + int ret; + + ret = tpm_qcom_send_command(pvt_data, &ver_req, sizeof(ver_req), + &ver_resp, &resp_len); + if (ret < 0 || resp_len < sizeof(ver_resp) || ver_resp.status != 0) + return ret ?: -EIO; + + dev_info(pvt_data->dev, "TPM TA version %u.%u\n", + FIELD_GET(QCOMTEE_TPM_TA_VERSION_MAJOR, ver_resp.version_num), + FIELD_GET(QCOMTEE_TPM_TA_VERSION_MINOR, ver_resp.version_num)); + + resp_len = sizeof(type_resp); + ret = tpm_qcom_send_command(pvt_data, &type_req, sizeof(type_req), + &type_resp, &resp_len); + if (ret < 0 || resp_len < sizeof(type_resp) || type_resp.status != 0) + return ret ?: -EIO; + + switch (type_resp.tpm_type) { + case QCOMTEE_TPM_TYPE_FTPM: + dev_info(pvt_data->dev, "TPM type: fTPM\n"); + pvt_data->is_dtpm = false; + break; + case QCOMTEE_TPM_TYPE_DTPM: + dev_info(pvt_data->dev, "TPM type: dTPM\n"); + pvt_data->is_dtpm = true; + break; + default: + dev_err(pvt_data->dev, "unsupported TPM type: 0x%08x\n", + type_resp.tpm_type); + return -EIO; + } + + return 0; +} + +/* fTPM does not implement this command and to be invoked via dtpm only. */ +static void tpm_qcom_transfer(struct tpm_qcom_private *pvt_data, + u32 transfer_state) +{ + struct tpm_qcom_transfer_req req = { + .command_id = QCOMTEE_TPM_TRANSFER_ID, + .transfer_state = transfer_state, + }; + struct tpm_qcom_transfer_resp resp; + size_t resp_len = sizeof(resp); + + tpm_qcom_send_command(pvt_data, &req, sizeof(req), &resp, &resp_len); +} + +static int tpm_qcom_cmd_ready(struct tpm_chip *chip) +{ + struct tpm_qcom_private *pvt_data = dev_get_drvdata(chip->dev.parent); + + if (pvt_data->is_dtpm) + tpm_qcom_transfer(pvt_data, QCOMTEE_TPM_TRANSFER_START); + + return 0; +} + +static int tpm_qcom_go_idle(struct tpm_chip *chip) +{ + struct tpm_qcom_private *pvt_data = dev_get_drvdata(chip->dev.parent); + + if (pvt_data->is_dtpm) + tpm_qcom_transfer(pvt_data, QCOMTEE_TPM_TRANSFER_END); + + return 0; +} + +/* + * The raw TPM2 command in @buf is sent directly as send_command's UBUF-in + * param and the raw TPM2 response is read back from its UBUF-out param. + */ +static int tpm_qcom_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz, + size_t cmd_len) +{ + struct tpm_qcom_private *pvt_data = dev_get_drvdata(chip->dev.parent); + struct tpm_header *header = (struct tpm_header *)buf; + size_t resp_len = PAGE_ALIGN(TPM_QCOM_MAX_RESPONSE_SIZE); + size_t copy_len; + int ret; + + if (cmd_len > TPM_QCOM_MAX_COMMAND_SIZE) { + dev_err(&chip->dev, "len=%zd exceeds TPM_QCOM_MAX_COMMAND_SIZE\n", + cmd_len); + return -EIO; + } + + u8 *response __free(kfree) = kzalloc(resp_len, GFP_KERNEL); + if (!response) + return -ENOMEM; + + ret = tpm_qcom_send_command(pvt_data, buf, cmd_len, response, &resp_len); + if (ret < 0) { + dev_err(&chip->dev, "TPM command failed: cmd_len=%zu, tpm_cc=0x%08x, ret:%d\n", + cmd_len, be32_to_cpu(header->ordinal), ret); + return ret; + } + + copy_len = min_t(size_t, bufsiz, resp_len); + memcpy(buf, response, copy_len); + + return copy_len; +} + +static const struct tpm_class_ops tpm_qcom_ops = { + .flags = TPM_OPS_AUTO_STARTUP, + .send = tpm_qcom_send, + .cmd_ready = tpm_qcom_cmd_ready, + .go_idle = tpm_qcom_go_idle, +}; + +static int tpm_qcom_ctx_match(struct tee_ioctl_version_data *ver, + const void *data) +{ + return (ver->impl_id == TEE_IMPL_ID_QTEE); +} + +static int tpm_qcom_probe(struct tee_client_device *tee_dev) +{ + struct device *dev = &tee_dev->dev; + struct tpm_qcom_private *pvt_data; + struct tee_param_objref client_env_obj; + struct tee_param_objref tpm_svc_obj; + struct tpm_chip *chip; + int err; + + pvt_data = devm_kzalloc(dev, sizeof(*pvt_data), GFP_KERNEL); + if (!pvt_data) + return -ENOMEM; + + dev_set_drvdata(dev, pvt_data); + + pvt_data->ctx = tee_client_open_context(NULL, tpm_qcom_ctx_match, NULL, NULL); + if (IS_ERR(pvt_data->ctx)) + return -ENODEV; + + err = tpm_qcom_get_client_env_obj(dev, pvt_data->ctx, &client_env_obj); + if (err) + goto out_ctx; + + err = tpm_qcom_get_svc_obj(dev, pvt_data->ctx, client_env_obj, &tpm_svc_obj); + /* Release client_env object irrespective of service obj return status */ + tpm_qcom_release_object(pvt_data->ctx, client_env_obj); + if (err) + goto out_ctx; + + pvt_data->tpm_svc_obj = tpm_svc_obj; + pvt_data->dev = dev; + + err = tpm_qcom_get_ta_details(pvt_data); + if (err) + goto out_svc_obj; + + chip = tpmm_chip_alloc(dev, &tpm_qcom_ops); + if (IS_ERR(chip)) { + dev_err(dev, "tpmm_chip_alloc failed\n"); + err = PTR_ERR(chip); + goto out_svc_obj; + } + + pvt_data->chip = chip; + dev_set_drvdata(dev, pvt_data); + pvt_data->chip->flags |= TPM_CHIP_FLAG_TPM2 | TPM_CHIP_FLAG_SYNC; + + err = tpm_chip_register(pvt_data->chip); + if (err) { + dev_err(dev, "tpm_chip_register failed with rc=%d\n", err); + goto out_svc_obj; + } + + return 0; + +out_svc_obj: + tpm_qcom_release_object(pvt_data->ctx, tpm_svc_obj); + +out_ctx: + tee_client_close_context(pvt_data->ctx); + return err; +} + +static void tpm_qcom_remove(struct tee_client_device *tee_dev) +{ + struct tpm_qcom_private *pvt_data = dev_get_drvdata(&tee_dev->dev); + + tpm_chip_unregister(pvt_data->chip); + tpm_qcom_release_object(pvt_data->ctx, pvt_data->tpm_svc_obj); + tee_client_close_context(pvt_data->ctx); +} + +static const struct tee_client_device_id tpm_qcom_id_table[] = { + { tpm_qcom_uuid }, + {} +}; +MODULE_DEVICE_TABLE(tee, tpm_qcom_id_table); + +static struct tee_client_driver tpm_qcom_driver = { + .id_table = tpm_qcom_id_table, + .probe = tpm_qcom_probe, + .remove = tpm_qcom_remove, + .driver = { + .name = "tpm_qcom", + }, +}; + +module_tee_client_driver(tpm_qcom_driver); + +MODULE_DESCRIPTION("TPM driver for Qualcomm TPM TA"); +MODULE_AUTHOR("Kuldeep Singh kuldeep.singh@oss.qualcomm.com"); +MODULE_LICENSE("GPL");
On Mon, Oct 19, 2026 at 02:51:47PM +0530, Kuldeep Singh wrote:
Add a TPM chip driver for platforms where a TPM 2.0 instance is implemented by a Trusted Application (TA) running in Qualcomm's Trusted Execution Environment (QTEE), reachable over the QCOMTEE object-IPC transport.
The driver discovers the qcom.tz.tpm TEE-bus device, opens a session with the TPM TA, and register with tpm interface. This exposes the TA through the standard /dev/tpm interface and the existing tpm2 command layer. OS need not be aware underlying TPM instance is dTPM or fTPM.
Signed-off-by: Kuldeep Singh kuldeep.singh@oss.qualcomm.com
drivers/char/tpm/Kconfig | 9 + drivers/char/tpm/Makefile | 1 + drivers/char/tpm/tpm_qcom.c | 414 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 424 insertions(+)
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig index 5f672f2c01b0..05d704ed3632 100644 --- a/drivers/char/tpm/Kconfig +++ b/drivers/char/tpm/Kconfig @@ -243,6 +243,15 @@ config TCG_FTPM_TEE help This driver proxies for firmware TPM running in TEE. +config TCG_QCOM
- tristate "Qualcomm TEE based TPM Interface"
- depends on QCOMTEE
- help
This driver provides interface to run TPM instances with Trustzonehaving Qualcomm TPM TA running in Qualcomm TEE.The mechanism uses the object-IPC based transport provided byQCOMTEE.config TCG_SVSM tristate "SNP SVSM vTPM interface" depends on AMD_MEM_ENCRYPT diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile index 5b5cdc0d32e4..471cbf49afd2 100644 --- a/drivers/char/tpm/Makefile +++ b/drivers/char/tpm/Makefile @@ -45,5 +45,6 @@ obj-$(CONFIG_TCG_CRB) += tpm_crb.o obj-$(CONFIG_TCG_ARM_CRB_FFA) += tpm_crb_ffa.o obj-$(CONFIG_TCG_VTPM_PROXY) += tpm_vtpm_proxy.o obj-$(CONFIG_TCG_FTPM_TEE) += tpm_ftpm_tee.o +obj-$(CONFIG_TCG_QCOM) += tpm_qcom.o obj-$(CONFIG_TCG_SVSM) += tpm_svsm.o obj-$(CONFIG_TCG_LOONGSON) += tpm_loongson.o diff --git a/drivers/char/tpm/tpm_qcom.c b/drivers/char/tpm/tpm_qcom.c new file mode 100644 index 000000000000..e9e4746f0004 --- /dev/null +++ b/drivers/char/tpm/tpm_qcom.c @@ -0,0 +1,414 @@ +// SPDX-License-Identifier: GPL-2.0 +/*
- Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
- */
+#include <linux/bitfield.h> +#include <linux/mm.h> +#include <linux/slab.h> +#include <linux/tee.h> +#include <linux/tee_drv.h> +#include <linux/tpm.h> +#include <linux/uuid.h>
+#include "tpm.h"
+#define QCOMTEE_ROOT_OP_REG_WITH_CREDENTIALS 5 +#define QCOMTEE_OP_CLIENT_ENV_OPEN 0 +#define QCOMTEE_MSG_OBJECT_OP_MASK GENMASK(15, 0) +#define QCOMTEE_MSG_OBJECT_OP_RELEASE (QCOMTEE_MSG_OBJECT_OP_MASK - 0)
+#define QCOMTEE_TPM_OP_SEND_COMMAND 0
+/* UID of the "qcom.tz.tpm" service */ +#define QCOMTEE_TPM_UID 81
+/* Max buffer size supported by TPM TA */ +#define TPM_QCOM_MAX_COMMAND_SIZE SZ_4K +#define TPM_QCOM_MAX_RESPONSE_SIZE SZ_4K
+#define QCOMTEE_TPM_GET_TA_VERSION_ID 0x0001000 +#define QCOMTEE_TPM_TA_VERSION_MAJOR GENMASK(31, 16) +#define QCOMTEE_TPM_TA_VERSION_MINOR GENMASK(15, 0)
+struct tpm_qcom_ta_version_req {
- u32 command_id;
+} __packed;
+struct tpm_qcom_ta_version_resp {
- u32 status;
- u32 command_id;
- u32 version_num;
+} __packed;
+#define QCOMTEE_TPM_TYPE_ID 0x0080000 +#define QCOMTEE_TPM_TYPE_DTPM 0x6454504dU +#define QCOMTEE_TPM_TYPE_FTPM 0x6654504dU +#define QCOMTEE_TPM_TYPE_NONE 0x4e6f6e65U
+struct tpm_qcom_type_req {
- u32 command_id;
+} __packed;
+struct tpm_qcom_type_resp {
- u32 command_id;
- u32 status;
- u32 tpm_type;
+} __packed;
+/*
- dTPM SPI transfer optimization:
- TRANSFER_START before a burst of commands, TRANSFER_END once done.
- */
+#define QCOMTEE_TPM_TRANSFER_ID 0x0000002 +#define QCOMTEE_TPM_TRANSFER_END 0 +#define QCOMTEE_TPM_TRANSFER_START 1
+struct tpm_qcom_transfer_req {
- u32 command_id;
- u32 transfer_state;
+} __packed;
+struct tpm_qcom_transfer_resp {
- u32 command_id;
- u32 status;
+} __packed;
+struct tpm_qcom_private {
- struct tpm_chip *chip;
- struct device *dev;
- struct tee_context *ctx;
- struct tee_param_objref tpm_svc_obj;
- bool is_dtpm;
+};
+/* UUID of the QTEE-bus device representing the TPM TA. */ +static const uuid_t tpm_qcom_uuid =
- UUID_INIT(0xaabcb593, 0x7083, 0x5536,
0xac, 0x27, 0x3d, 0x2d, 0x89, 0x41, 0x9d, 0xdb);+static void tpm_qcom_release_object(struct tee_context *ctx,
struct tee_param_objref object)+{
- struct tee_ioctl_object_invoke_arg inv_arg = {};
- inv_arg.id = object.id;
- inv_arg.op = QCOMTEE_MSG_OBJECT_OP_RELEASE;
- inv_arg.num_params = 0;
- tee_client_object_invoke_func(ctx, &inv_arg, NULL);
+}
+static int tpm_qcom_get_client_env_obj(struct device *dev,
struct tee_context *ctx,struct tee_param_objref *client_env_obj)+{
- struct tee_ioctl_object_invoke_arg inv_arg = {};
- struct tee_param param[2] = {};
- int ret;
- inv_arg.id = TEE_OBJREF_NULL;
- inv_arg.op = QCOMTEE_ROOT_OP_REG_WITH_CREDENTIALS;
- inv_arg.num_params = 2;
- param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF_INPUT;
- param[0].u.objref.id = TEE_OBJREF_NULL;
- param[1].attr = TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF_OUTPUT;
- ret = tee_client_object_invoke_func(ctx, &inv_arg, param);
- if (ret < 0 || inv_arg.ret != 0) {
dev_err(dev, "get client env obj failed: ret=%d, invoke_ret=0x%x\n",ret, inv_arg.ret);return -EINVAL;- }
- *client_env_obj = param[1].u.objref;
- return 0;
+}
+static int tpm_qcom_get_svc_obj(struct device *dev,
struct tee_context *ctx,struct tee_param_objref client_env_obj,struct tee_param_objref *tpm_svc_obj)+{
- struct tee_ioctl_object_invoke_arg inv_arg = {};
- struct tee_param param[2] = {};
- u32 tpm_uid = QCOMTEE_TPM_UID;
- int ret;
- inv_arg.id = client_env_obj.id;
- inv_arg.op = QCOMTEE_OP_CLIENT_ENV_OPEN;
- inv_arg.num_params = 2;
- param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_INPUT;
- param[0].u.ubuf = (struct tee_param_ubuf){ .addr = &tpm_uid,
.size = sizeof(tpm_uid) };- param[1].attr = TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF_OUTPUT;
- ret = tee_client_object_invoke_func(ctx, &inv_arg, param);
- if (ret < 0 || inv_arg.ret != 0) {
dev_err(dev, "get TPM service obj failed: ret=%d, invoke_ret=0x%x\n",ret, inv_arg.ret);return -EINVAL;- }
- *tpm_svc_obj = param[1].u.objref;
- return 0;
+}
+static int tpm_qcom_send_command(struct tpm_qcom_private *pvt_data,
void *req, size_t req_len, void *resp,size_t *resp_len)+{
- struct tee_ioctl_object_invoke_arg inv_arg = {};
- struct tee_param param[3] = {};
- u8 locality_arg = 0;
- int ret;
- inv_arg.id = pvt_data->tpm_svc_obj.id;
- inv_arg.op = QCOMTEE_TPM_OP_SEND_COMMAND;
- inv_arg.num_params = 3;
- param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_INPUT;
- param[0].u.ubuf = (struct tee_param_ubuf){ .addr = &locality_arg,
.size = sizeof(locality_arg) };- param[1].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_INPUT;
- param[1].u.ubuf = (struct tee_param_ubuf){ .addr = req, .size = req_len };
- param[2].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_OUTPUT;
- param[2].u.ubuf = (struct tee_param_ubuf){ .addr = resp, .size = *resp_len };
- ret = tee_client_object_invoke_func(pvt_data->ctx, &inv_arg, param);
- if (ret < 0 || inv_arg.ret != 0) {
dev_err(pvt_data->dev,"send_command invoke ret: %d, err: 0x%x\n",ret, inv_arg.ret);return ret ?: -EINVAL;- }
- *resp_len = param[2].u.ubuf.size;
- return 0;
+}
+static int tpm_qcom_get_ta_details(struct tpm_qcom_private *pvt_data) +{
- struct tpm_qcom_ta_version_req ver_req = {
.command_id = QCOMTEE_TPM_GET_TA_VERSION_ID,- };
- struct tpm_qcom_ta_version_resp ver_resp;
- size_t resp_len = sizeof(ver_resp);
- struct tpm_qcom_type_req type_req = {
.command_id = QCOMTEE_TPM_TYPE_ID,- };
- struct tpm_qcom_type_resp type_resp;
- int ret;
- ret = tpm_qcom_send_command(pvt_data, &ver_req, sizeof(ver_req),
&ver_resp, &resp_len);- if (ret < 0 || resp_len < sizeof(ver_resp) || ver_resp.status != 0)
return ret ?: -EIO;- dev_info(pvt_data->dev, "TPM TA version %u.%u\n",
FIELD_GET(QCOMTEE_TPM_TA_VERSION_MAJOR, ver_resp.version_num),FIELD_GET(QCOMTEE_TPM_TA_VERSION_MINOR, ver_resp.version_num));- resp_len = sizeof(type_resp);
- ret = tpm_qcom_send_command(pvt_data, &type_req, sizeof(type_req),
&type_resp, &resp_len);- if (ret < 0 || resp_len < sizeof(type_resp) || type_resp.status != 0)
return ret ?: -EIO;- switch (type_resp.tpm_type) {
- case QCOMTEE_TPM_TYPE_FTPM:
dev_info(pvt_data->dev, "TPM type: fTPM\n");pvt_data->is_dtpm = false;break;- case QCOMTEE_TPM_TYPE_DTPM:
dev_info(pvt_data->dev, "TPM type: dTPM\n");pvt_data->is_dtpm = true;break;- default:
dev_err(pvt_data->dev, "unsupported TPM type: 0x%08x\n",type_resp.tpm_type);return -EIO;- }
- return 0;
+}
+/* fTPM does not implement this command and to be invoked via dtpm only. */ +static void tpm_qcom_transfer(struct tpm_qcom_private *pvt_data,
u32 transfer_state)+{
- struct tpm_qcom_transfer_req req = {
.command_id = QCOMTEE_TPM_TRANSFER_ID,.transfer_state = transfer_state,- };
- struct tpm_qcom_transfer_resp resp;
- size_t resp_len = sizeof(resp);
- tpm_qcom_send_command(pvt_data, &req, sizeof(req), &resp, &resp_len);
+}
+static int tpm_qcom_cmd_ready(struct tpm_chip *chip) +{
- struct tpm_qcom_private *pvt_data = dev_get_drvdata(chip->dev.parent);
- if (pvt_data->is_dtpm)
tpm_qcom_transfer(pvt_data, QCOMTEE_TPM_TRANSFER_START);- return 0;
+}
+static int tpm_qcom_go_idle(struct tpm_chip *chip) +{
- struct tpm_qcom_private *pvt_data = dev_get_drvdata(chip->dev.parent);
- if (pvt_data->is_dtpm)
tpm_qcom_transfer(pvt_data, QCOMTEE_TPM_TRANSFER_END);- return 0;
+}
+/*
- The raw TPM2 command in @buf is sent directly as send_command's UBUF-in
- param and the raw TPM2 response is read back from its UBUF-out param.
- */
+static int tpm_qcom_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz,
size_t cmd_len)+{
- struct tpm_qcom_private *pvt_data = dev_get_drvdata(chip->dev.parent);
- struct tpm_header *header = (struct tpm_header *)buf;
- size_t resp_len = PAGE_ALIGN(TPM_QCOM_MAX_RESPONSE_SIZE);
- size_t copy_len;
- int ret;
- if (cmd_len > TPM_QCOM_MAX_COMMAND_SIZE) {
dev_err(&chip->dev, "len=%zd exceeds TPM_QCOM_MAX_COMMAND_SIZE\n",cmd_len);return -EIO;- }
- u8 *response __free(kfree) = kzalloc(resp_len, GFP_KERNEL);
- if (!response)
return -ENOMEM;- ret = tpm_qcom_send_command(pvt_data, buf, cmd_len, response, &resp_len);
- if (ret < 0) {
dev_err(&chip->dev, "TPM command failed: cmd_len=%zu, tpm_cc=0x%08x, ret:%d\n",cmd_len, be32_to_cpu(header->ordinal), ret);return ret;- }
- copy_len = min_t(size_t, bufsiz, resp_len);
- memcpy(buf, response, copy_len);
- return copy_len;
+}
+static const struct tpm_class_ops tpm_qcom_ops = {
- .flags = TPM_OPS_AUTO_STARTUP,
- .send = tpm_qcom_send,
- .cmd_ready = tpm_qcom_cmd_ready,
- .go_idle = tpm_qcom_go_idle,
+};
+static int tpm_qcom_ctx_match(struct tee_ioctl_version_data *ver,
const void *data)+{
- return (ver->impl_id == TEE_IMPL_ID_QTEE);
+}
+static int tpm_qcom_probe(struct tee_client_device *tee_dev) +{
- struct device *dev = &tee_dev->dev;
- struct tpm_qcom_private *pvt_data;
- struct tee_param_objref client_env_obj;
- struct tee_param_objref tpm_svc_obj;
- struct tpm_chip *chip;
- int err;
- pvt_data = devm_kzalloc(dev, sizeof(*pvt_data), GFP_KERNEL);
- if (!pvt_data)
return -ENOMEM;- dev_set_drvdata(dev, pvt_data);
- pvt_data->ctx = tee_client_open_context(NULL, tpm_qcom_ctx_match, NULL, NULL);
- if (IS_ERR(pvt_data->ctx))
return -ENODEV;- err = tpm_qcom_get_client_env_obj(dev, pvt_data->ctx, &client_env_obj);
- if (err)
goto out_ctx;- err = tpm_qcom_get_svc_obj(dev, pvt_data->ctx, client_env_obj, &tpm_svc_obj);
- /* Release client_env object irrespective of service obj return status */
- tpm_qcom_release_object(pvt_data->ctx, client_env_obj);
- if (err)
goto out_ctx;- pvt_data->tpm_svc_obj = tpm_svc_obj;
- pvt_data->dev = dev;
- err = tpm_qcom_get_ta_details(pvt_data);
- if (err)
goto out_svc_obj;- chip = tpmm_chip_alloc(dev, &tpm_qcom_ops);
- if (IS_ERR(chip)) {
dev_err(dev, "tpmm_chip_alloc failed\n");err = PTR_ERR(chip);goto out_svc_obj;- }
- pvt_data->chip = chip;
- dev_set_drvdata(dev, pvt_data);
- pvt_data->chip->flags |= TPM_CHIP_FLAG_TPM2 | TPM_CHIP_FLAG_SYNC;
- err = tpm_chip_register(pvt_data->chip);
- if (err) {
dev_err(dev, "tpm_chip_register failed with rc=%d\n", err);goto out_svc_obj;- }
- return 0;
+out_svc_obj:
- tpm_qcom_release_object(pvt_data->ctx, tpm_svc_obj);
+out_ctx:
- tee_client_close_context(pvt_data->ctx);
- return err;
+}
+static void tpm_qcom_remove(struct tee_client_device *tee_dev) +{
- struct tpm_qcom_private *pvt_data = dev_get_drvdata(&tee_dev->dev);
- tpm_chip_unregister(pvt_data->chip);
- tpm_qcom_release_object(pvt_data->ctx, pvt_data->tpm_svc_obj);
- tee_client_close_context(pvt_data->ctx);
+}
+static const struct tee_client_device_id tpm_qcom_id_table[] = {
- { tpm_qcom_uuid },
- {}
+}; +MODULE_DEVICE_TABLE(tee, tpm_qcom_id_table);
+static struct tee_client_driver tpm_qcom_driver = {
- .id_table = tpm_qcom_id_table,
- .probe = tpm_qcom_probe,
- .remove = tpm_qcom_remove,
- .driver = {
.name = "tpm_qcom",- },
+};
+module_tee_client_driver(tpm_qcom_driver);
+MODULE_DESCRIPTION("TPM driver for Qualcomm TPM TA"); +MODULE_AUTHOR("Kuldeep Singh kuldeep.singh@oss.qualcomm.com"); +MODULE_LICENSE("GPL");
-- 2.34.1
Reviewed-by: Jarkko Sakkinen jarkko@kernel.org
Br, Jarkko
Hi Kuldeep,
On 10/19/2026 8:21 PM, Kuldeep Singh wrote:
Add a TPM chip driver for platforms where a TPM 2.0 instance is implemented by a Trusted Application (TA) running in Qualcomm's Trusted Execution Environment (QTEE), reachable over the QCOMTEE object-IPC transport.
The driver discovers the qcom.tz.tpm TEE-bus device, opens a session with the TPM TA, and register with tpm interface. This exposes the TA through the standard /dev/tpm interface and the existing tpm2 command layer. OS need not be aware underlying TPM instance is dTPM or fTPM.
Signed-off-by: Kuldeep Singh kuldeep.singh@oss.qualcomm.com
drivers/char/tpm/Kconfig | 9 + drivers/char/tpm/Makefile | 1 + drivers/char/tpm/tpm_qcom.c | 414 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 424 insertions(+)
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig index 5f672f2c01b0..05d704ed3632 100644 --- a/drivers/char/tpm/Kconfig +++ b/drivers/char/tpm/Kconfig @@ -243,6 +243,15 @@ config TCG_FTPM_TEE help This driver proxies for firmware TPM running in TEE. +config TCG_QCOM
- tristate "Qualcomm TEE based TPM Interface"
- depends on QCOMTEE
- help
This driver provides interface to run TPM instances with Trustzonehaving Qualcomm TPM TA running in Qualcomm TEE.The mechanism uses the object-IPC based transport provided byQCOMTEE.config TCG_SVSM tristate "SNP SVSM vTPM interface" depends on AMD_MEM_ENCRYPT diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile index 5b5cdc0d32e4..471cbf49afd2 100644 --- a/drivers/char/tpm/Makefile +++ b/drivers/char/tpm/Makefile @@ -45,5 +45,6 @@ obj-$(CONFIG_TCG_CRB) += tpm_crb.o obj-$(CONFIG_TCG_ARM_CRB_FFA) += tpm_crb_ffa.o obj-$(CONFIG_TCG_VTPM_PROXY) += tpm_vtpm_proxy.o obj-$(CONFIG_TCG_FTPM_TEE) += tpm_ftpm_tee.o +obj-$(CONFIG_TCG_QCOM) += tpm_qcom.o obj-$(CONFIG_TCG_SVSM) += tpm_svsm.o obj-$(CONFIG_TCG_LOONGSON) += tpm_loongson.o diff --git a/drivers/char/tpm/tpm_qcom.c b/drivers/char/tpm/tpm_qcom.c new file mode 100644 index 000000000000..e9e4746f0004 --- /dev/null +++ b/drivers/char/tpm/tpm_qcom.c @@ -0,0 +1,414 @@ +// SPDX-License-Identifier: GPL-2.0 +/*
- Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
- */
+#include <linux/bitfield.h> +#include <linux/mm.h> +#include <linux/slab.h> +#include <linux/tee.h> +#include <linux/tee_drv.h> +#include <linux/tpm.h> +#include <linux/uuid.h>
+#include "tpm.h"
+#define QCOMTEE_ROOT_OP_REG_WITH_CREDENTIALS 5 +#define QCOMTEE_OP_CLIENT_ENV_OPEN 0 +#define QCOMTEE_MSG_OBJECT_OP_MASK GENMASK(15, 0) +#define QCOMTEE_MSG_OBJECT_OP_RELEASE (QCOMTEE_MSG_OBJECT_OP_MASK - 0)
+#define QCOMTEE_TPM_OP_SEND_COMMAND 0
+/* UID of the "qcom.tz.tpm" service */ +#define QCOMTEE_TPM_UID 81
+/* Max buffer size supported by TPM TA */ +#define TPM_QCOM_MAX_COMMAND_SIZE SZ_4K +#define TPM_QCOM_MAX_RESPONSE_SIZE SZ_4K
I also mentioned it in V2, why using different naming convention across different macros. Why not QCOMTEE_TPM_MAX_COMMAND_SIZE?
+#define QCOMTEE_TPM_GET_TA_VERSION_ID 0x0001000
nipik: For constant either use 0x00001000 or 0x1000. not 28-bit. Why not U like others just for consistency.
+#define QCOMTEE_TPM_TA_VERSION_MAJOR GENMASK(31, 16) +#define QCOMTEE_TPM_TA_VERSION_MINOR GENMASK(15, 0)
+struct tpm_qcom_ta_version_req {
- u32 command_id;
+} __packed;
+struct tpm_qcom_ta_version_resp {
- u32 status;
- u32 command_id;
- u32 version_num;
+} __packed;
+#define QCOMTEE_TPM_TYPE_ID 0x0080000 +#define QCOMTEE_TPM_TYPE_DTPM 0x6454504dU +#define QCOMTEE_TPM_TYPE_FTPM 0x6654504dU +#define QCOMTEE_TPM_TYPE_NONE 0x4e6f6e65U
This is an unused macro.
+struct tpm_qcom_type_req {
- u32 command_id;
+} __packed;
+struct tpm_qcom_type_resp {
- u32 command_id;
- u32 status;
- u32 tpm_type;
+} __packed;
+/*
- dTPM SPI transfer optimization:
- TRANSFER_START before a burst of commands, TRANSFER_END once done.
- */
+#define QCOMTEE_TPM_TRANSFER_ID 0x0000002 +#define QCOMTEE_TPM_TRANSFER_END 0 +#define QCOMTEE_TPM_TRANSFER_START 1
+struct tpm_qcom_transfer_req {
- u32 command_id;
- u32 transfer_state;
+} __packed;
+struct tpm_qcom_transfer_resp {
- u32 command_id;
- u32 status;
+} __packed;
+struct tpm_qcom_private {
- struct tpm_chip *chip;
- struct device *dev;
- struct tee_context *ctx;
- struct tee_param_objref tpm_svc_obj;
- bool is_dtpm;
+};
+/* UUID of the QTEE-bus device representing the TPM TA. */ +static const uuid_t tpm_qcom_uuid =
- UUID_INIT(0xaabcb593, 0x7083, 0x5536,
0xac, 0x27, 0x3d, 0x2d, 0x89, 0x41, 0x9d, 0xdb);+static void tpm_qcom_release_object(struct tee_context *ctx,
struct tee_param_objref object)+{
- struct tee_ioctl_object_invoke_arg inv_arg = {};
- inv_arg.id = object.id;
- inv_arg.op = QCOMTEE_MSG_OBJECT_OP_RELEASE;
- inv_arg.num_params = 0;
- tee_client_object_invoke_func(ctx, &inv_arg, NULL);
+}
+static int tpm_qcom_get_client_env_obj(struct device *dev,
struct tee_context *ctx,struct tee_param_objref *client_env_obj)+{
- struct tee_ioctl_object_invoke_arg inv_arg = {};
- struct tee_param param[2] = {};
- int ret;
- inv_arg.id = TEE_OBJREF_NULL;
- inv_arg.op = QCOMTEE_ROOT_OP_REG_WITH_CREDENTIALS;
- inv_arg.num_params = 2;
- param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF_INPUT;
- param[0].u.objref.id = TEE_OBJREF_NULL;
- param[1].attr = TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF_OUTPUT;
- ret = tee_client_object_invoke_func(ctx, &inv_arg, param);
- if (ret < 0 || inv_arg.ret != 0) {
dev_err(dev, "get client env obj failed: ret=%d, invoke_ret=0x%x\n",ret, inv_arg.ret);return -EINVAL;- }
- *client_env_obj = param[1].u.objref;
- return 0;
+}
+static int tpm_qcom_get_svc_obj(struct device *dev,
struct tee_context *ctx,struct tee_param_objref client_env_obj,struct tee_param_objref *tpm_svc_obj)+{
- struct tee_ioctl_object_invoke_arg inv_arg = {};
- struct tee_param param[2] = {};
- u32 tpm_uid = QCOMTEE_TPM_UID;
- int ret;
- inv_arg.id = client_env_obj.id;
- inv_arg.op = QCOMTEE_OP_CLIENT_ENV_OPEN;
- inv_arg.num_params = 2;
- param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_INPUT;
- param[0].u.ubuf = (struct tee_param_ubuf){ .addr = &tpm_uid,
.size = sizeof(tpm_uid) };- param[1].attr = TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF_OUTPUT;
- ret = tee_client_object_invoke_func(ctx, &inv_arg, param);
- if (ret < 0 || inv_arg.ret != 0) {
dev_err(dev, "get TPM service obj failed: ret=%d, invoke_ret=0x%x\n",ret, inv_arg.ret);return -EINVAL;- }
- *tpm_svc_obj = param[1].u.objref;
- return 0;
+}
+static int tpm_qcom_send_command(struct tpm_qcom_private *pvt_data,
void *req, size_t req_len, void *resp,size_t *resp_len)+{
- struct tee_ioctl_object_invoke_arg inv_arg = {};
- struct tee_param param[3] = {};
- u8 locality_arg = 0;
- int ret;
- inv_arg.id = pvt_data->tpm_svc_obj.id;
- inv_arg.op = QCOMTEE_TPM_OP_SEND_COMMAND;
- inv_arg.num_params = 3;
- param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_INPUT;
- param[0].u.ubuf = (struct tee_param_ubuf){ .addr = &locality_arg,
.size = sizeof(locality_arg) };- param[1].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_INPUT;
- param[1].u.ubuf = (struct tee_param_ubuf){ .addr = req, .size = req_len };
- param[2].attr = TEE_IOCTL_PARAM_ATTR_TYPE_UBUF_OUTPUT;
- param[2].u.ubuf = (struct tee_param_ubuf){ .addr = resp, .size = *resp_len };
- ret = tee_client_object_invoke_func(pvt_data->ctx, &inv_arg, param);
- if (ret < 0 || inv_arg.ret != 0) {
dev_err(pvt_data->dev,"send_command invoke ret: %d, err: 0x%x\n",ret, inv_arg.ret);return ret ?: -EINVAL;- }
- *resp_len = param[2].u.ubuf.size;
- return 0;
+}
+static int tpm_qcom_get_ta_details(struct tpm_qcom_private *pvt_data) +{
- struct tpm_qcom_ta_version_req ver_req = {
.command_id = QCOMTEE_TPM_GET_TA_VERSION_ID,- };
- struct tpm_qcom_ta_version_resp ver_resp;
- size_t resp_len = sizeof(ver_resp);
- struct tpm_qcom_type_req type_req = {
.command_id = QCOMTEE_TPM_TYPE_ID,- };
- struct tpm_qcom_type_resp type_resp;
- int ret;
- ret = tpm_qcom_send_command(pvt_data, &ver_req, sizeof(ver_req),
&ver_resp, &resp_len);- if (ret < 0 || resp_len < sizeof(ver_resp) || ver_resp.status != 0)
return ret ?: -EIO;- dev_info(pvt_data->dev, "TPM TA version %u.%u\n",
FIELD_GET(QCOMTEE_TPM_TA_VERSION_MAJOR, ver_resp.version_num),FIELD_GET(QCOMTEE_TPM_TA_VERSION_MINOR, ver_resp.version_num));
Just to confirm, Are you sure this does not produce compile time warning. Check it. I belive GENMASK generate "unsigned long" and %u is not correct?
- resp_len = sizeof(type_resp);
- ret = tpm_qcom_send_command(pvt_data, &type_req, sizeof(type_req),
&type_resp, &resp_len);- if (ret < 0 || resp_len < sizeof(type_resp) || type_resp.status != 0)
return ret ?: -EIO;- switch (type_resp.tpm_type) {
- case QCOMTEE_TPM_TYPE_FTPM:
dev_info(pvt_data->dev, "TPM type: fTPM\n");pvt_data->is_dtpm = false;break;- case QCOMTEE_TPM_TYPE_DTPM:
dev_info(pvt_data->dev, "TPM type: dTPM\n");pvt_data->is_dtpm = true;break;- default:
dev_err(pvt_data->dev, "unsupported TPM type: 0x%08x\n",type_resp.tpm_type);return -EIO;- }
- return 0;
+}
+/* fTPM does not implement this command and to be invoked via dtpm only. */ +static void tpm_qcom_transfer(struct tpm_qcom_private *pvt_data,
u32 transfer_state)+{
- struct tpm_qcom_transfer_req req = {
.command_id = QCOMTEE_TPM_TRANSFER_ID,.transfer_state = transfer_state,- };
- struct tpm_qcom_transfer_resp resp;
- size_t resp_len = sizeof(resp);
- tpm_qcom_send_command(pvt_data, &req, sizeof(req), &resp, &resp_len);
+}
+static int tpm_qcom_cmd_ready(struct tpm_chip *chip) +{
- struct tpm_qcom_private *pvt_data = dev_get_drvdata(chip->dev.parent);
- if (pvt_data->is_dtpm)
tpm_qcom_transfer(pvt_data, QCOMTEE_TPM_TRANSFER_START);- return 0;
+}
+static int tpm_qcom_go_idle(struct tpm_chip *chip) +{
- struct tpm_qcom_private *pvt_data = dev_get_drvdata(chip->dev.parent);
- if (pvt_data->is_dtpm)
tpm_qcom_transfer(pvt_data, QCOMTEE_TPM_TRANSFER_END);- return 0;
+}
+/*
- The raw TPM2 command in @buf is sent directly as send_command's UBUF-in
- param and the raw TPM2 response is read back from its UBUF-out param.
- */
+static int tpm_qcom_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz,
size_t cmd_len)+{
- struct tpm_qcom_private *pvt_data = dev_get_drvdata(chip->dev.parent);
- struct tpm_header *header = (struct tpm_header *)buf;
- size_t resp_len = PAGE_ALIGN(TPM_QCOM_MAX_RESPONSE_SIZE);
Why PAGE_ALIGN? Why not using TPM_QCOM_MAX_RESPONSE_SIZE directly? In 16K page, it increases the size to 16K, is it what you want?
- size_t copy_len;
- int ret;
- if (cmd_len > TPM_QCOM_MAX_COMMAND_SIZE) {
dev_err(&chip->dev, "len=%zd exceeds TPM_QCOM_MAX_COMMAND_SIZE\n",cmd_len);return -EIO;- }
- u8 *response __free(kfree) = kzalloc(resp_len, GFP_KERNEL);
- if (!response)
return -ENOMEM;- ret = tpm_qcom_send_command(pvt_data, buf, cmd_len, response, &resp_len);
- if (ret < 0) {
dev_err(&chip->dev, "TPM command failed: cmd_len=%zu, tpm_cc=0x%08x, ret:%d\n",cmd_len, be32_to_cpu(header->ordinal), ret);return ret;- }
- copy_len = min_t(size_t, bufsiz, resp_len);
Does this min_t means the result turncation and discarding is acceptable!? Should not we do the min_t at the allocation time:
size_t resp_len = min_t(TPM_QCOM_MAX_RESPONSE_SIZE, bufsiz);
- memcpy(buf, response, copy_len);
- return copy_len;
+}
+static const struct tpm_class_ops tpm_qcom_ops = {
- .flags = TPM_OPS_AUTO_STARTUP,
- .send = tpm_qcom_send,
- .cmd_ready = tpm_qcom_cmd_ready,
- .go_idle = tpm_qcom_go_idle,
+};
+static int tpm_qcom_ctx_match(struct tee_ioctl_version_data *ver,
const void *data)+{
- return (ver->impl_id == TEE_IMPL_ID_QTEE);
+}
+static int tpm_qcom_probe(struct tee_client_device *tee_dev) +{
- struct device *dev = &tee_dev->dev;
- struct tpm_qcom_private *pvt_data;
- struct tee_param_objref client_env_obj;
- struct tee_param_objref tpm_svc_obj;
- struct tpm_chip *chip;
- int err;
- pvt_data = devm_kzalloc(dev, sizeof(*pvt_data), GFP_KERNEL);
- if (!pvt_data)
return -ENOMEM;- dev_set_drvdata(dev, pvt_data);
This line is duplicated!? It is also bellow.
- Amir
- pvt_data->ctx = tee_client_open_context(NULL, tpm_qcom_ctx_match, NULL, NULL);
- if (IS_ERR(pvt_data->ctx))
return -ENODEV;- err = tpm_qcom_get_client_env_obj(dev, pvt_data->ctx, &client_env_obj);
- if (err)
goto out_ctx;- err = tpm_qcom_get_svc_obj(dev, pvt_data->ctx, client_env_obj, &tpm_svc_obj);
- /* Release client_env object irrespective of service obj return status */
- tpm_qcom_release_object(pvt_data->ctx, client_env_obj);
- if (err)
goto out_ctx;- pvt_data->tpm_svc_obj = tpm_svc_obj;
- pvt_data->dev = dev;
- err = tpm_qcom_get_ta_details(pvt_data);
- if (err)
goto out_svc_obj;- chip = tpmm_chip_alloc(dev, &tpm_qcom_ops);
- if (IS_ERR(chip)) {
dev_err(dev, "tpmm_chip_alloc failed\n");err = PTR_ERR(chip);goto out_svc_obj;- }
- pvt_data->chip = chip;
- dev_set_drvdata(dev, pvt_data);
- pvt_data->chip->flags |= TPM_CHIP_FLAG_TPM2 | TPM_CHIP_FLAG_SYNC;
- err = tpm_chip_register(pvt_data->chip);
- if (err) {
dev_err(dev, "tpm_chip_register failed with rc=%d\n", err);goto out_svc_obj;- }
- return 0;
+out_svc_obj:
- tpm_qcom_release_object(pvt_data->ctx, tpm_svc_obj);
+out_ctx:
- tee_client_close_context(pvt_data->ctx);
- return err;
+}
+static void tpm_qcom_remove(struct tee_client_device *tee_dev) +{
- struct tpm_qcom_private *pvt_data = dev_get_drvdata(&tee_dev->dev);
- tpm_chip_unregister(pvt_data->chip);
- tpm_qcom_release_object(pvt_data->ctx, pvt_data->tpm_svc_obj);
- tee_client_close_context(pvt_data->ctx);
+}
+static const struct tee_client_device_id tpm_qcom_id_table[] = {
- { tpm_qcom_uuid },
- {}
+}; +MODULE_DEVICE_TABLE(tee, tpm_qcom_id_table);
+static struct tee_client_driver tpm_qcom_driver = {
- .id_table = tpm_qcom_id_table,
- .probe = tpm_qcom_probe,
- .remove = tpm_qcom_remove,
- .driver = {
.name = "tpm_qcom",- },
+};
+module_tee_client_driver(tpm_qcom_driver);
+MODULE_DESCRIPTION("TPM driver for Qualcomm TPM TA"); +MODULE_AUTHOR("Kuldeep Singh kuldeep.singh@oss.qualcomm.com"); +MODULE_LICENSE("GPL");
Add a dedicated MAINTAINERS entry for the Qualcomm TPM driver, which uses the Qualcomm TEE interface (qcomtee) to communicate with a TPM Trusted Application running in TrustZone.
Reviewed-by: Jarkko Sakkinen jarkko@kernel.org Signed-off-by: Kuldeep Singh kuldeep.singh@oss.qualcomm.com --- MAINTAINERS | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS index fb43b8e46158..bb86a7c024e4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -23160,6 +23160,12 @@ S: Maintained F: Documentation/tee/qtee.rst F: drivers/tee/qcomtee/
+QUALCOMM TPM DRIVER +M: Kuldeep Singh kuldeep.singh@oss.qualcomm.com +L: linux-arm-msm@vger.kernel.org +S: Maintained +F: drivers/char/tpm/tpm_qcom.c + QUALCOMM TRUST ZONE MEMORY ALLOCATOR M: Bartosz Golaszewski brgl@kernel.org L: linux-arm-msm@vger.kernel.org
On Mon, Oct 19, 2026 at 02:51:45PM +0530, Kuldeep Singh wrote:
Qualcomm platforms with a discrete TPM (dTPM) talked to it directly over a non-secure SPI channel from the kernel. Arm's Base Boot Security Requirements (BBSR) v1.4 require that access to go through TrustZone instead, so on affected Qualcomm platforms the TPM 2.0 instance is now fronted by a Trusted Application (TA) running inside Qualcomm's Trusted Execution Environment (QTEE), which talks to the dTPM (or implements an fTPM) on the kernel's behalf.
This series adds a kernel driver for that TA, built on the QCOMTEE object-IPC transport (drivers/tee/qcomtee/) already used to reach other QTEE services.
This patch series functionally depends on below(first 5 changes specially) for qtee service discovery.
Tested on Glymur-crd target with tpm2-tools utility.
Validations:
- Get capabilities
- Random number generator
- RSA key creation, encryption and decryption.
Signed-off-by: Kuldeep Singh kuldeep.singh@oss.qualcomm.com
Changes in v4:
- Add new line before goto label(Jarkko).
- Link to v3: https://patch.msgid.link/20261015-tpm_qcom_driver-v3-0-247c8e50250e@qti.qual...
Changes in v3:
- Merge tpm_qcom.h into tpm_qcom.c(Amir comments)
- Update return values of functions and drop certain error prints.
- Define locality_arg as default value.
- Add Jarkko's tag on all but drop from 2/3 as significant changes done.
- Link to v2: https://patch.msgid.link/20260907-tpm_qcom_driver-v2-0-71a6b1752da8@oss.qual...
Changes in v2:
- Use QCOMTEE_TPM_UID as 81 for service discovery in patch 1.
- Use FIELD_GET, zero initialised array and log improvement (Konrad)
- Improve commit title and other fixes (Jarkko)
- Split MAINTAINERS entry as separate patch.
- Link to v1: https://patch.msgid.link/20260831-tpm_qcom_driver-v1-0-6f16fa6924fa@oss.qual...
To: Amirreza Zarrabi amirreza.zarrabi@oss.qualcomm.com To: Jens Wiklander jenswi@kernel.org To: Sumit Garg sumit.garg@kernel.org To: Peter Huewe peterhuewe@gmx.de To: Jarkko Sakkinen jarkko@kernel.org To: Jason Gunthorpe jgg@ziepe.ca To: Kuldeep Singh kuldeep.singh@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org Cc: op-tee@lists.trustedfirmware.org Cc: linux-kernel@vger.kernel.org Cc: linux-integrity@vger.kernel.org
Kuldeep Singh (3): tee: qcomtee: Register qcom.tz.tpm service for discovery tpm: Introduce Qualcomm TPM driver MAINTAINERS: Add Qualcomm TPM driver entry
MAINTAINERS | 6 + drivers/char/tpm/Kconfig | 9 + drivers/char/tpm/Makefile | 1 + drivers/char/tpm/tpm_qcom.c | 414 ++++++++++++++++++++++++++++++++++++++ drivers/tee/qcomtee/call.c | 4 +- drivers/tee/qcomtee/qcomtee_msg.h | 2 + 6 files changed, 435 insertions(+), 1 deletion(-)
base-commit: 2efb7a11f1aa4d2dc285fe2680cca22cb9f72f64 change-id: 20260831-tpm_qcom_driver-d21c720e73b2 prerequisite-change-id: 20260408-qcom_uefisecapp_migrate_qcomtee-13869d45e014:v5 prerequisite-patch-id: faf4520d818abf0d7533f71d9c8b9a8aade34626 prerequisite-patch-id: b487dfe2fbc076f4815dc6c73b9e68b0b78c961f prerequisite-patch-id: 9f2c4ee37ba173bdc860f253d44974379f2cf125 prerequisite-patch-id: e86905ac6289821db30fd9a17f73e276e0a88363 prerequisite-patch-id: 8777bfa2ef8344715bf972d049acb0a6ef49b136 prerequisite-patch-id: 1c7f946e770a1cbc1599f9571282c9265a6af9cd prerequisite-patch-id: 7be993abea2ca36057d9352381a5890f50996dda
Best regards,
Kuldeep Singh kuldeep.singh@oss.qualcomm.com
Applying this pulls tons of TEE patches:
Applying: tee: qcomtee: Track the object invocation context Applying: tee: Add kernel client object invoke helper Applying: tee: qcomtee: Allow object invokes from kernel clients Applying: tee: Export uuidv5 generation for TEE backends Applying: tee: qcomtee: Add support for registering QTEE services on TEE bus Applying: firmware: qcom: Add support for TEE based EFI-var client driver Applying: arm64: defconfig: Enable UefiSecApp TEE client driver for Qualcomm SoCs Applying: tee: qcomtee: Register qcom.tz.tpm service for discovery Applying: tpm: Introduce Qualcomm TPM driver Applying: MAINTAINERS: Add Qualcomm TPM driver entry
Br, Jarkko
Applying this pulls tons of TEE patches:
Applying: tee: qcomtee: Track the object invocation context Applying: tee: Add kernel client object invoke helper Applying: tee: qcomtee: Allow object invokes from kernel clients Applying: tee: Export uuidv5 generation for TEE backends Applying: tee: qcomtee: Add support for registering QTEE services on TEE bus Applying: firmware: qcom: Add support for TEE based EFI-var client driver Applying: arm64: defconfig: Enable UefiSecApp TEE client driver for Qualcomm SoCs Applying: tee: qcomtee: Register qcom.tz.tpm service for discovery Applying: tpm: Introduce Qualcomm TPM driver Applying: MAINTAINERS: Add Qualcomm TPM driver entry
Yes, first 5 are tee patches prerequisite for tpm series as mentioned in cover letter too and this series can only be merged once Jens can pick dependent series[1] in linux-next.
Since, v7.4 merge window going to start soon so i doubt Jens can pick for v7.4.
Jens, Any plan/timeline you are aiming to pick series[1]? I see it's mostly reviewed with no other relevant feedback to be addressed.
[1] https://lore.kernel.org/lkml/20261015-qcom_uefisecapp_migrate_qcomtee-v5-0-1...
On Wed, Oct 21, 2026 at 11:21:33AM +0530, Kuldeep Singh wrote:
Applying this pulls tons of TEE patches:
Applying: tee: qcomtee: Track the object invocation context Applying: tee: Add kernel client object invoke helper Applying: tee: qcomtee: Allow object invokes from kernel clients Applying: tee: Export uuidv5 generation for TEE backends Applying: tee: qcomtee: Add support for registering QTEE services on TEE bus Applying: firmware: qcom: Add support for TEE based EFI-var client driver Applying: arm64: defconfig: Enable UefiSecApp TEE client driver for Qualcomm SoCs Applying: tee: qcomtee: Register qcom.tz.tpm service for discovery Applying: tpm: Introduce Qualcomm TPM driver Applying: MAINTAINERS: Add Qualcomm TPM driver entry
Yes, first 5 are tee patches prerequisite for tpm series as mentioned in cover letter too and this series can only be merged once Jens can pick dependent series[1] in linux-next.
Since, v7.4 merge window going to start soon so i doubt Jens can pick for v7.4.
Jens, Any plan/timeline you are aiming to pick series[1]? I see it's mostly reviewed with no other relevant feedback to be addressed.
Maybe it is better to pick also TPM patches through your tree when you choose to so that this will go in-sync.
[1] https://lore.kernel.org/lkml/20261015-qcom_uefisecapp_migrate_qcomtee-v5-0-1...
-- Regards Kuldeep
Br, Jarkko
Hi,
On 21/10/2026 09.49, Jarkko Sakkinen wrote:
On Wed, Oct 21, 2026 at 11:21:33AM +0530, Kuldeep Singh wrote:
Applying this pulls tons of TEE patches:
Applying: tee: qcomtee: Track the object invocation context Applying: tee: Add kernel client object invoke helper Applying: tee: qcomtee: Allow object invokes from kernel clients Applying: tee: Export uuidv5 generation for TEE backends Applying: tee: qcomtee: Add support for registering QTEE services on TEE bus Applying: firmware: qcom: Add support for TEE based EFI-var client driver Applying: arm64: defconfig: Enable UefiSecApp TEE client driver for Qualcomm SoCs Applying: tee: qcomtee: Register qcom.tz.tpm service for discovery Applying: tpm: Introduce Qualcomm TPM driver Applying: MAINTAINERS: Add Qualcomm TPM driver entry
Yes, first 5 are tee patches prerequisite for tpm series as mentioned in cover letter too and this series can only be merged once Jens can pick dependent series[1] in linux-next.
Since, v7.4 merge window going to start soon so i doubt Jens can pick for v7.4.
Jens, Any plan/timeline you are aiming to pick series[1]? I see it's mostly reviewed with no other relevant feedback to be addressed.
I'm sorry for the delay, I lost control over my inbox for a while. Looking at [1] it appears some more is needed before it's ready.
Maybe it is better to pick also TPM patches through your tree when you choose to so that this will go in-sync.
Yes, that makes sense.
[1] https://lore.kernel.org/lkml/20261015-qcom_uefisecapp_migrate_qcomtee-v5-0-1...
-- Regards Kuldeep
Br, Jarkko
Cheers, Jens
op-tee@lists.trustedfirmware.org
-
Amirreza Zarrabi -
Jarkko Sakkinen -
Jens Wiklander -
Kuldeep Singh