If build kernel without "O=dir", below error will be seen:
In file included from drivers/tee/optee/optee_trace.h:67, from drivers/tee/optee/call.c:18: ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ^ compilation terminated.
Fix it by adding below line to Makefile: CFLAGS_call.o := -I$(src)
Tested with and without "O=dir", both can build successfully.
Reported-by: Guenter Roeck linux@roeck-us.net Suggested-by: Steven Rostedt rostedt@goodmis.org Signed-off-by: Jisheng Zhang Jisheng.Zhang@synaptics.com --- drivers/tee/optee/Makefile | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/tee/optee/Makefile b/drivers/tee/optee/Makefile index 56263ae3b1d7..3aa33ea9e6a6 100644 --- a/drivers/tee/optee/Makefile +++ b/drivers/tee/optee/Makefile @@ -6,3 +6,6 @@ optee-objs += rpc.o optee-objs += supp.o optee-objs += shm_pool.o optee-objs += device.o + +# for tracing framework to find optee_trace.h +CFLAGS_call.o := -I$(src)
If build kernel without "O=dir", below error will be seen:
In file included from drivers/tee/optee/optee_trace.h:67, from drivers/tee/optee/call.c:18: ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ^ compilation terminated.
Fix it by adding below line to Makefile: CFLAGS_call.o := -I$(src)
Tested with and without "O=dir", both can build successfully.
Reported-by: Guenter Roeck linux@roeck-us.net Suggested-by: Steven Rostedt rostedt@goodmis.org Signed-off-by: Jisheng Zhang Jisheng.Zhang@synaptics.com
Fixes: 0101947dbcc3 ("tee: optee: add invoke_fn tracepoints") Tested-by: Heiko Thiery heiko.thiery@gmail.com
drivers/tee/optee/Makefile | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/tee/optee/Makefile b/drivers/tee/optee/Makefile index 56263ae3b1d7..3aa33ea9e6a6 100644 --- a/drivers/tee/optee/Makefile +++ b/drivers/tee/optee/Makefile @@ -6,3 +6,6 @@ optee-objs += rpc.o optee-objs += supp.o optee-objs += shm_pool.o optee-objs += device.o
+# for tracing framework to find optee_trace.h
+CFLAGS_call.o := -I$(src)
2.31.0
Thank you.
On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
If build kernel without "O=dir", below error will be seen:
In file included from drivers/tee/optee/optee_trace.h:67, from drivers/tee/optee/call.c:18: ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ^ compilation terminated.
Fix it by adding below line to Makefile: CFLAGS_call.o := -I$(src)
Tested with and without "O=dir", both can build successfully.
Reported-by: Guenter Roeck linux@roeck-us.net Suggested-by: Steven Rostedt rostedt@goodmis.org Signed-off-by: Jisheng Zhang Jisheng.Zhang@synaptics.com
I've picked up this.
Thanks, Jens
Hi Jens,
Am Di., 30. März 2021 um 10:26 Uhr schrieb Jens Wiklander jens.wiklander@linaro.org:
On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
If build kernel without "O=dir", below error will be seen:
In file included from drivers/tee/optee/optee_trace.h:67, from drivers/tee/optee/call.c:18: ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ^ compilation terminated.
Fix it by adding below line to Makefile: CFLAGS_call.o := -I$(src)
Tested with and without "O=dir", both can build successfully.
Reported-by: Guenter Roeck linux@roeck-us.net Suggested-by: Steven Rostedt rostedt@goodmis.org Signed-off-by: Jisheng Zhang Jisheng.Zhang@synaptics.com
I've picked up this.
For what tree did you pick this? I still see this build failure on the latest next tree (next-20210401).
Thanks, Jens
Thank you, Heiko
Hi Heiko,
[+Arnd]
On Tue, Apr 6, 2021 at 12:38 PM Heiko Thiery heiko.thiery@gmail.com wrote:
Hi Jens,
Am Di., 30. März 2021 um 10:26 Uhr schrieb Jens Wiklander jens.wiklander@linaro.org:
On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
If build kernel without "O=dir", below error will be seen:
In file included from drivers/tee/optee/optee_trace.h:67, from drivers/tee/optee/call.c:18: ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ^ compilation terminated.
Fix it by adding below line to Makefile: CFLAGS_call.o := -I$(src)
Tested with and without "O=dir", both can build successfully.
Reported-by: Guenter Roeck linux@roeck-us.net Suggested-by: Steven Rostedt rostedt@goodmis.org Signed-off-by: Jisheng Zhang Jisheng.Zhang@synaptics.com
I've picked up this.
For what tree did you pick this? I still see this build failure on the latest next tree (next-20210401).
The next tree hasn't been updated since 1th of April so it's not unexpected. The fix is supposed to be on its way to https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=arm/drive... , I can't see it there yet though.
Cheers, Jens
Hi Jens,
Am Di., 6. Apr. 2021 um 14:30 Uhr schrieb Jens Wiklander jens.wiklander@linaro.org:
Hi Heiko,
[+Arnd]
On Tue, Apr 6, 2021 at 12:38 PM Heiko Thiery heiko.thiery@gmail.com wrote:
Hi Jens,
Am Di., 30. März 2021 um 10:26 Uhr schrieb Jens Wiklander jens.wiklander@linaro.org:
On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
If build kernel without "O=dir", below error will be seen:
In file included from drivers/tee/optee/optee_trace.h:67, from drivers/tee/optee/call.c:18: ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ^ compilation terminated.
Fix it by adding below line to Makefile: CFLAGS_call.o := -I$(src)
Tested with and without "O=dir", both can build successfully.
Reported-by: Guenter Roeck linux@roeck-us.net Suggested-by: Steven Rostedt rostedt@goodmis.org Signed-off-by: Jisheng Zhang Jisheng.Zhang@synaptics.com
I've picked up this.
For what tree did you pick this? I still see this build failure on the latest next tree (next-20210401).
The next tree hasn't been updated since 1th of April so it's not unexpected. The fix is supposed to be on its way to https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=arm/drive... , I can't see it there yet though.
Ah I see. Now it has been landed in the actual next tree.
Thank you, Heiko
op-tee@lists.trustedfirmware.org
-
Heiko Thiery -
Jens Wiklander -
Jisheng Zhang