On Thu, Aug 19, 2021 at 08:21:27PM -0700, CGEL wrote:

From: jing yangyang jing.yangyang@zte.com.cn

sizeof when applied to a pointer typed expression gives the size of the pointer.

./drivers/tee/optee/shm_pool.c:38:28-34: ERROR application of sizeof to pointer

This issue was detected with the help of Coccinelle.

Reported-by: Zeal Robot zealci@zte.com.cn Signed-off-by: jing yangyang jing.yangyang@zte.com.cn

This should not affect code generation since both pages and *pages are pointers but the change looks good to me.

Reviewed-by: Daniel Thompson daniel.thompson@linaro.org

---

drivers/tee/optee/shm_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tee/optee/shm_pool.c b/drivers/tee/optee/shm_pool.c index c41a9a5..d167039 100644 --- a/drivers/tee/optee/shm_pool.c +++ b/drivers/tee/optee/shm_pool.c @@ -35,7 +35,7 @@ static int pool_op_alloc(struct tee_shm_pool_mgr *poolm, unsigned int nr_pages = 1 << order, i; struct page **pages;

• pages = kcalloc(nr_pages, sizeof(pages), GFP_KERNEL);
  

• pages = kcalloc(nr_pages, sizeof(*pages), GFP_KERNEL);
  

  if (!pages) { rc = -ENOMEM; goto err;

-- 1.8.3.1