Re: [PATCH v3 2/3] tpm: Introduce Qualcomm TPM driver

...

• err = tpm_chip_register(pvt_data->chip);
• if (err) {

• dev_err(dev, "tpm_chip_register failed with rc=%d\n", err);
  

• goto out_svc_obj;
  

• }
• return 0;

+out_svc_obj:

• tpm_qcom_release_object(pvt_data->ctx, tpm_svc_obj);

This is very cleanly laid out driver. This goes perhaps unhealthy levels of nitpicking but we usually tend to have newline before the next label.

No worries!! I'll add new line before out_ctx and post next version. Let me check any other goto usage and update that one too.