Hi Eric,
On 14-11-2026 03:26 am, Eric Biggers wrote:
On Wed, Nov 11, 2026 at 07:47:04PM +0530, Harshal Dev wrote:
module_tee_client_driver(qcom_ice_tee_driver);
[...]
+module_platform_driver(qcom_ice_plat_driver);
So is this a tee_client_driver or is it a platform_driver? It can't be both.
This patch feels like a workaround for issues that could be solved by folding this driver's functionality into the existing qcom_ice driver. Is there any reason why qcom_ice shouldn't just make the OP-TEE calls directly?
So this is an attempt at solving the problem I described in the commit message of patch 4/6. Basically, if the ICE driver is built and probed, it needs to know that: 1. A TZ is available on the Qualcomm platform. (qcom_scm_is_available) 2. Whether the TZ supports an ICE secure service. (qcom_scm_ice_is_available)
With OP-TEE, there is no way actively check via an API for 1 and 2. Instead the TEE client driver model probes a driver only if the secure service is supported by OP-TEE. Which means that you only get notified of the presence of the secure service, not of its absence.
So currently if you boot with OP-TEE and register a back-end ICE TEE client driver, and the OP-TEE build doesn't support a secure ICE service, the ICE driver calling a corresponding qcom_tee_is_available() API on the back-end driver would forever defer probe.
I suggested another approach for this on a reply on commit 4, where we register the back-end OPTEE device on the TEE bus once it has registered all its secure services on the TEE bus, and then the ICE TEE client driver can be probed when that happens, and subsequently attempt a tee_client_open_session() call to the ICE secure service, failing which it would have concrete knowledge that the current OP-TEE build doesn't support the ICE service and so we can continue storage initialization without inline encryption support.
At the core of it, we have two device-tree probed independent drivers, ICE and OPTEE that need to talk to each other the way ICE and SCM drivers do. The right approach here needs debate and alignment.
Regards, Harshal
- Eric