Hi Abhishek & all
Sorry for late input.
I would like to come back to the point I raised in BKK: guidance for coding style application for platform specific code.
The TF-M coding style includes a "##Consistent style "statement that indicates "The code needs to be consistent with itself, so if existing code in the file violates listed coding style rules then it is better to follow existing style in the file and not break consistency by following the rules listed here" , we propose to precise it applies typically for platform specific code and to add a requirement to put platform specific code (e.g HAL code) in a single folder.
To illustrate this in case of a ST STM32 platform:
-STM32 Platform specific HAL code will be in a single folder located under /platform<https://git.trustedfirmware.org/trusted-firmware-m.git/tree/platform>/ext<https://git.trustedfirmware.org/trusted-firmware-m.git/tree/platform/ext>/target<https://git.trustedfirmware.org/trusted-firmware-m.git/tree/platform/ext/ta…>
-Code using the STM32 HAL :
- Is matching the indentation style.
- Function calls to STM32 HAL are CamelCase to fit with STM32 HAL functions
Regards,
Eric Finco
[Description: Description: Description: Description: Description: Description: Description: Description: Description: Description: Description: Description: Description: logo_big5]
Eric FINCO | Tel: +33 (0)2 4402 7154
MDG/MCD | Technical Specialist
From: TSC <tsc-bounces(a)lists.trustedfirmware.org> On Behalf Of Abhishek Pandit via TSC
Sent: jeudi 2 mai 2019 16:39
To: tsc(a)lists.trustedfirmware.org
Cc: nd <nd(a)arm.com>
Subject: [TF-TSC] Next TSC meeting & Agenda
Hi All,
We didn't get to discuss the next meeting slot in our previous meeting but I would like to suggest Thursday 16th May 16:00 UK time. Hope that works.
>From June onwards, we can setup a regular call e.g. on every 2nd Thursday of the month. Let's discuss and finalize in the next call.
Any Agenda items that you would like to add for next meeting?
Thanks,
Abhishek
Hi TF TSC
This is a v0.2 update to the proposed tf.org security incident handling process, which I sent before the last TSC, incorporating comments I've had since then.
Changes since then:
* Clarified use of PGP.
* Clarified how ESSs get included in the process
* Other minor edits.
I've included some comment/rationale in square brackets to aid discussion. All comments welcome.
I've also jotted down the key points in the attached slides, which might be easier to digest. Hopefully we can discuss this more at Thursday TSC meeting.
Regards
Dan.
----
This security incident handling process proposal is broadly based on the kernel process [1], with influence from the existing TF-A [2] and OP-TEE [3] processes.
[DH: Note the contrast with the kernel process: mailto:security@kernel.org is exclusively about fixing the vulnerability; disclosure is delegated to mailto:linux-distros@vs.openwall.org [4]. This proposal combines these activities.]
Reporting
=========
If you think you have found a security vulnerability, then please send an email to the Trusted Firmware security team at mailto:security@trustedfirmware.org. This is a private team of security officers who will help verify the security vulnerability, develop and release a fix, and disclose the vulnerability details responsibly. Please give us time to implement the disclosure plan described in the next section before going public. We do our best to respond and fix any issues as soon as possible.
As with any bug, the more information you provide, the easier it is to diagnose and fix. If you already have a fix, please include it with your report, as that can speed up the process considerably. Any exploit code is very helpful. The security team may bring in extra help from area maintainers to understand and fix the vulnerability. The security team may share any information you provide with trusted third parties and eventually the public unless you request otherwise.
[DH: Note, mailto:security@kernel.org provides stronger confidentiality guarantees because it is only interested in fixes, not disclosure. In practice, I'd expect members of the security team to be sensitive with confidential information as with any other open source interactions, and to get explicit approval from the reporter for disclosure of sensitive information, e.g. identity, organization, product information,...]
You may using this PGP/GPG key [insert link] for encrypting the vulnerability information. This key is also available at http://keyserver.pgp.com and LDAP port 389 of the same server. The fingerprint for this key is:
[Insert Fingerprint]
If you would like replies to be encrypted, please provide your public key. Please note the Trusted Firmware security team cannot guarantee that encrypted information will remain encrypted when shared with trusted third parties.
[DH: Is this acceptable? It allows reporters to use encryption without adding too much admin burden on the security team. The alternative is to force everyone receiving embargoed information to provide an encryption key and decrypt/re-encrypt as information is passed around. I think this adds too much overhead without significant security benefit.]
If the security team consider the bug not to be a security vulnerability, you will be informed and the bug directed to the standard bug fixing process.
Disclosure
==========
The general security vulnerability disclosure plan is as follows:
1. For confirmed security vulnerabilities, develop a robust fix as soon as possible. During this time, information is only shared with the reporter, those needed to develop the fix and Especially Sensitive Stakeholders (ESSes). See the "ESS and Trusted Stakeholder registration" section below for more information about ESSes.
2. After a robust fix becomes available, our preference is to publicly release it as soon as possible. This will automatically happen if the vulnerability is already publicly known. However, release may be deferred if the reporter or an ESS requests it within 1 calendar day of the fix becoming available, and the security team agree the criticality of the vulnerability requires more time. The requested deferral period should be as short as possible and no more than 14 calendar days after the fix becomes available. The only valid reason for this release deferral is to accommodate deployment of the fix by ESSes. If it is immediately clear that ESSes are unaffected by the vulnerability then this stage is skipped. This 0-14 day deferral is the primary embargo period.
[DH: Note, this stage is only relevant for TF-A currently.]
[DH: I removed the nuance between 7 and 14 days used in the kernel process. I don't think it essentially changes the process.]
[DH: Note, this assumes that ESS security teams operate 7 days a week.]
3. After the primary embargo period, the fix and relevant vulnerability information are shared with registered Trusted Stakeholders (see below section). Fix release may be deferred further if a Trusted Stakeholder requests it within 1 working day (Monday to Friday) of being notified, and the security team agree the criticality of the vulnerability requires more time. The requested deferral period should be as short as possible and no more than 14 calendar days after the Trusted Stakeholder receives it. The only valid reason for this further release deferral is to accommodate deployment of the fix by a Trusted Stakeholder. This further 1-14 day deferral is the secondary embargo period.
Note, security fixes contain the minimum information required to fix the bug. The accompanying vulnerability details are disclosed later.
[DH: Note, I've slightly relaxed the Trusted Stakeholder required response time to 1 working day, as oppose to 1 calendar day. Is this reasonable?]
[DH: Note, this aggressive release of security fixes is aligned with the kernel process. The existing TF-A process allows for early release of fixes, which we generally do in practice, but that process doesn't really specify a fix embargo period. However it does specify a 4 week embargo on the subsequent security advisory. Also note that OP-TEE's fix embargo period is 90 days, which is aligned with Google's policy.]
4. After the fix is released, details of the security vulnerability are consolidated into a security advisory. This includes a CVE number and the security team will request one if not already done by the reporter. It also includes credit to the reporter unless they indicate otherwise. Drafts of the security advisory are circulated with the reporter, ESSes and Trusted Stakeholders as they become available.
[DH: Note, the existing TF-A process only shares information with Trusted Stakeholders in the form of security advisories. This proposal is more aligned with the kernel process and means we can focus on fix development by sharing raw vulnerability information in the early stages.]
5. 90 days after the vulnerability was reported, the security advisory is made public at https://www.trustedfirmware.org/. This 90 day window is the public embargo period.
[DH: This public embargo period aligns with Google and OP-TEE processes, although this proposal releases fixes earlier.]
In exceptional cases, the above disclosure plan may be extended in consultation with the reporter, ESSes and Trusted Stakeholders, for example if it is very difficult to develop or deploy a fix, or wider industry consultation is needed.
[DH: I'm accommodating for the Spectre/Meltdown case here]
Handling embargoed information
==============================
On receipt of embargoed information, you must not disclose any of the provided information beyond the group of people in your organization that need to know about it. During the primary and secondary embargo periods, that group of people should be limited to those entrusted to assess the impact of the vulnerability on your organization and deploy fixes to your products. After the secondary embargo period but during the public embargo period, that group of people may be expanded in order to prepare your organization's public response. The embargoed information must not be shared outside your organization during the public embargo period under any circumstances. If you think another individual/organization requires access to the embargoed information, then please ask them to register as a Trusted Stakeholder (see next section). If you believe there has been a leak of embargoed information then please notify the security team immediately.
[DH: This section is stronger than the existing TF-A and OP-TEE processes, but not as strong as the linux distros policy [4]. I hope I've struck the right balance here.]
The security team welcomes feedback on embargoed information at any time.
ESS and Trusted Stakeholder registration
========================================
[DH: This is broadly based on the OP-TEE policy.]
The security team maintains a vetted list of organizations and individuals who are considered ESSes and Trusted Stakeholders of Trusted Firmware security vulnerabilities. Contact <mailto:security@trustedfirmware.org> if you wish to be added to one of the lists, providing the following information:
1. Which list you want to be on. This will almost always be the Trusted Stakeholder list.
2. A justification of why you should be on the list. That is, why you should know about security vulnerabilities and have access to security fixes before they are made public. A valid reason to be on the Trusted Stakeholder list for example, is that you use Trusted Firmware in a deployed product. The ESS list is strictly limited to those organizations with large scale deployments of Trusted Firmware, providing bare-metal access on multi-tenancy systems.
3. An organization email address (not gmail, yahoo or similar addresses). It is preferable for each organization to provide an email alias that you can manage yourselves rather than providing a long list of individual addresses.
4. Confirmation that the individuals in your organization will handle embargoed information responsibly as described in the previous section.
Note, the security team reserves the right to deny registration or revoke membership to the Trusted Stakeholders list, for example if it has concerns about the confidentiality of embargoed information.
[DH: Note, becoming a Trusted Stakeholder in the current TF-A process requires having a valid NDA with Arm and requesting to be added via Arm account management. I propose that Arm send a mail to all existing stakeholders to invite them to register for the new process. Any objections?]
[DH: Note, I expect each TF project to maintain its own ESS/Trusted Stakeholder lists.]
[DH: Note, I've not included severity scoring in this proposal, as I think the only value of a score is helping to determine whether a bug is a security vulnerability or not, which in the end has a subjective element. I'm open to the idea of adding this to the process but I'd prefer it to be optional and aligned with CVSSv3 as used by CVE.]
[1] https://www.kernel.org/doc/html/latest/admin-guide/security-bugs.html
[2] https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/about/docs/secu…
[3] https://optee.readthedocs.io/general/disclosure.html
[4] https://oss-security.openwall.org/wiki/mailing-lists/distros#how-to-use-the…
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
I'm good with either 16:00 or 17:00.
Thanks,
Christian.
________________________________
From: TSC <tsc-bounces(a)lists.trustedfirmware.org> on behalf of Abhishek Pandit via TSC <tsc(a)lists.trustedfirmware.org>
Sent: Wednesday, May 8, 2019 3:08 AM
To: Julius Werner; tsc(a)lists.trustedfirmware.org
Cc: nd
Subject: Re: [TF-TSC] Next TSC meeting & Agenda
I am okay with 17:00 but let's wait another day. If we don't hear any other preference for time then we can schedule at 17:00.
Thanks,
Abhishek
-----Original Message-----
From: Julius Werner <jwerner(a)google.com>
Sent: 02 May 2019 21:00
To: Abhishek Pandit <Abhishek.Pandit(a)arm.com>
Cc: tsc(a)lists.trustedfirmware.org; nd <nd(a)arm.com>
Subject: Re: [TF-TSC] Next TSC meeting & Agenda
> We didn’t get to discuss the next meeting slot in our previous meeting but I would like to suggest Thursday 16th May 16:00 UK time. Hope that works.
Any chance we could keep this at 17:00 like the previous calls?
Otherwise it becomes really early in California.
--
TSC mailing list
TSC(a)lists.trustedfirmware.org
https://lists.trustedfirmware.org/mailman/listinfo/tsc
This message and any attachments may contain confidential information from Cypress or its subsidiaries. If it has been received in error, please advise the sender and immediately delete this message.
> We didn’t get to discuss the next meeting slot in our previous meeting but I would like to suggest Thursday 16th May 16:00 UK time. Hope that works.
Any chance we could keep this at 17:00 like the previous calls?
Otherwise it becomes really early in California.
On Thu, May 02, 2019 at 02:38:40PM +0000, Abhishek Pandit via TSC wrote:
>We didn’t get to discuss the next meeting slot in our previous meeting but I
>would like to suggest Thursday 16^th May 16:00 UK time. Hope that works.
>
>From June onwards, we can setup a regular call e.g. on every 2^nd Thursday of
>the month. Let’s discuss and finalize in the next call.
This time regularly works for me, although on the 16th I will be at
the ICMC19 conference, and won't be able to attend.
David
Hi All,
We didn't get to discuss the next meeting slot in our previous meeting but I would like to suggest Thursday 16th May 16:00 UK time. Hope that works.
>From June onwards, we can setup a regular call e.g. on every 2nd Thursday of the month. Let's discuss and finalize in the next call.
Any Agenda items that you would like to add for next meeting?
Thanks,
Abhishek
Hi Paul, all,
I think this is a good proposal. As a side note, we've just completed that
exercise for the OP-TEE project [1] and in general it seems like most
people appreciate the change. One thing where our process differs compared
to what you've proposed is that we are still using GitHub for everything
and that is connected directly to https://readthedocs.io using webhooks,
which has the nifty feature that as soon as a patch (pull request) has been
merged at GitHub, readthedocs will automatically be notified (webhooks) and
will immediately rebuild the documentation and publish it. I.e., we always
have the latest version available and published and there is no extra cost
involved in manually having to deploy the "_build/*" stuff. I'm not sure if
that is doable with existing TF infrastructure, but I think it's worth
investigating whether someone like that is possible to do, since it saves
us from doing "unnecessary" work.
[1] https://optee.readthedocs.io/ and https://github.com/OP-TEE/optee_docs/
Regards,
Joakim
On Tue, 30 Apr 2019 at 11:18, Paul Beesley via TSC <
tsc(a)lists.trustedfirmware.org> wrote:
> Hi all,
>
>
>
> Please find attached a set of slides detailing proposed formats and
> processes for TF-M documentation; these proposals cover both existing
> documentation and documents produced for the purpose of design review.
> Abhishek previously presented a version of these slides to the TSC and we
> are now circulating them via the mailing list.
>
>
>
> Though it is not explicitly mentioned in the slides, we will look to
> implement similar changes in Trusted Firmware-A as well, aligning the two
> projects where possible.
>
>
>
> As always, comments and feedback on these proposed changes are welcome.
>
>
>
> Thanks,
>
> Paul
> --
> TSC mailing list
> TSC(a)lists.trustedfirmware.org
> https://lists.trustedfirmware.org/mailman/listinfo/tsc
>
Hi all,
Please find attached a set of slides detailing proposed formats and processes for TF-M documentation; these proposals cover both existing documentation and documents produced for the purpose of design review. Abhishek previously presented a version of these slides to the TSC and we are now circulating them via the mailing list.
Though it is not explicitly mentioned in the slides, we will look to implement similar changes in Trusted Firmware-A as well, aligning the two projects where possible.
As always, comments and feedback on these proposed changes are welcome.
Thanks,
Paul
Attendees
Abhishek - Arm
Kumar - Linaro
MarkG - TI
RemiD - Linaro
DaveP - Linaro
Eric - ST
MatteoC - Arm
ShebuK - Arm
BillM - TI
Christian -Cypress
DonH - Linaro
SobyM - Arm
Joakim - Linaro
DavidB - Linaro
BillF - Linaro Community Projects
Pending action items
CI discussion - slides circulated
Security incident handling - postponed as DanH cannot attend
Notes
Won’t use TSC-private mailing list any more (will be reactivated if needed)
Attestation script home - Arm team will upstream initial patch.
Dean to send test cases running on MPS2. Dean is going to do some
deployment today (or ASAP). Follow up with Christian if nothing comes from
Dean
Proposal from documentation - Abhishek to send out initial proposal. Will
be circulated after Connect.
TF-A Roadmap
JB: Will the roadmap be circulated publicly?
MC: Would make sense to circulate a version publicly. For now this is the
Arm roadmap. Would be a combination of contributions from project, other
parties and infrastructure plans from Arm. Don’t know if advance which
platforms are coming in from Partners
JB: Not exactly clear what should publish. Maybe some kind of lightweight
roadmap.
SK: Have always published cut down version in TF-M dashboard.
(MC shows slides from monthly report on tf.org)
(MC shows “Trusted Firmware-A Evolution” #5 slide - this slide will be
circulated afterwards). Data is public so follow-up discussions can happen
on a public list.
Arm & Google discussing to have Hafnium as secure EL2 firmware
EF: Any assumption in terms of architecture?
MC: v8 systems 32 & 64 bit. Not maintaining v7 TF.
MC: Code is moving from GitHub to tf.org git/gerrit
JB: Functional safety (2020?)
MC: Good topic for TF. Happy to have a discussion on MISRA-C etc. Can’t
certify with Arm toolchain linker. Partners need to do own platform port.
(SV shows “TF-M v1.0-Beta @ Embedded World’19” - slide, backlog & Roadmap)
SV: All work items public under Phabricator. Have 4 engineers working under
tf.org.
AP: Platform support? Worth to have something along with the roadmap to
show which platforms are planned to be upstream.
CD: List of platforms that will be supported? All for that.
EF: We can create ticket when we work on an upstream platform. Would be
easier than putting this in a public roadmap. Should discuss what are the
coding rules and what we plan to put in /platform/x/target (?). Action Eric
to make a proposal on upstream platforms & tickets
AP: Stay away from complete freedom to put code conforming to any code
convention in one of the directories.
KG: Anyone looking at infrastructure for the project? MISRA, Coverity?
(question open)
LAVA topic
(slides LAVA Remote Labs - previously shared)
CD: raised question about having local master to help admin overhead.
RD: Linaro believes that it’s better to have from local IT point of view to
have single master. Currently lava has either admin or submitter. Linaro
working on adding mid-level. It’s a shared master with multiple admins.
CD: Already have lava setup internally (with local master?)
DP: Remote worker model is not necessarily for everyone.
CD: Less shared management is a good proposition if you don’t have already
that in place.
DP: Provided further input on this.
KG: How the hardware is done has impact on adding something in the CI loop
Original use case is companies wanting to put device in LAVA without
shipping device to a central lab. Different model for sharing open CI with
all projects vs making it easier within the companies.
After some further discussion we decided to put a pin on this for
discussing offline.
--
EMEA Field Engineering
Linaro Ltd
Harston Mill CB22 7GG
Cambridge UK
+44 7833 498336 <+44%207833%20498336>
LAVA Remote Labs slides
Best regards
Bill
On Wed, 3 Apr 2019 at 08:42, Bill Fletcher via TSC <
tsc(a)lists.trustedfirmware.org> wrote:
> As part of the action on CI infrastructure I have the action to describing
> a proposal for a distributed CI instance called Remote Labs.
>
> Regards
>
> Bill
>
> On Wed, 3 Apr 2019 at 08:05, Abhishek Pandit via TSC <
> tsc(a)lists.trustedfirmware.org> wrote:
>
> > Hi All,
> >
> > Any agenda items for this week's TSC meeting?
> >
> > Currently this is what I have for the agenda:
> >
> >
> > * Pending action items
> > * Major roadmap items for the next quarter
> > * Next meeting
> >
> > Thanks
> > Abhishek
> >
> > --
> > TSC mailing list
> > TSC(a)lists.trustedfirmware.org
> > https://lists.trustedfirmware.org/mailman/listinfo/tsc
> >
>
>
> --
>
>
> EMEA Field Engineering
> Linaro Ltd
> Harston Mill CB22 7GG
> Cambridge UK
> +44 7833 498336 <+44%207833%20498336>
> --
> TSC mailing list
> TSC(a)lists.trustedfirmware.org
> https://lists.trustedfirmware.org/mailman/listinfo/tsc
>
--
EMEA Field Engineering
Linaro Ltd
Harston Mill CB22 7GG
Cambridge UK
+44 7833 498336 <+44%207833%20498336>
