On Mon, Aug 11, 2025 at 11:11:24AM +0530, Sumit Garg via OP-TEE wrote:

On Wed, Aug 06, 2025 at 12:47:35PM +0000, Sungbae Yoo wrote:

Add some commit description.

Will add the commit description like this :

Fixes optee_ffa_api_is_compatbile() to optee_ffa_api_is_compatible() because compatbile is a typo of compatible.

...

Fix: commit 4615e5a34b95 ("optee: add FF-A support")

Correct fixes tag, should be instead:

Fixes: 4615e5a34b95 ("optee: add FF-A support")

Thank you for correcting this!

-Sumit

...

Signed-off-by: Sungbae Yoo sungbaey@nvidia.com

diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c index f9ef7d94cebd..a963eed70c1d 100644 --- a/drivers/tee/optee/ffa_abi.c +++ b/drivers/tee/optee/ffa_abi.c @@ -657,7 +657,7 @@ static int optee_ffa_do_call_with_arg(struct tee_context *ctx,

• with a matching configuration.

*/

-static bool optee_ffa_api_is_compatbile(struct ffa_device *ffa_dev, +static bool optee_ffa_api_is_compatible(struct ffa_device *ffa_dev, const struct ffa_ops *ops) { const struct ffa_msg_ops *msg_ops = ops->msg_ops; @@ -908,7 +908,7 @@ static int optee_ffa_probe(struct ffa_device *ffa_dev) ffa_ops = ffa_dev->ops; notif_ops = ffa_ops->notifier_ops;

•   if (!optee_ffa_api_is_compatbile(ffa_dev, ffa_ops))
  

•   if (!optee_ffa_api_is_compatible(ffa_dev, ffa_ops))
            return -EINVAL;
  
    if (!optee_ffa_exchange_caps(ffa_dev, ffa_ops, &sec_caps,
  

-- 2.34.1

On Mon, Aug 11, 2025 at 10:00:17AM +0000, Sungbae Yoo wrote:

Fixes optee_ffa_api_is_compatbile() to optee_ffa_api_is_compatible() because compatbile is a typo of compatible.

Fixes: 4615e5a34b95 ("optee: add FF-A support")

This blank line should be dropped.

Signed-off-by: Sungbae Yoo sungbaey@nvidia.com

With that fixed, feel free to apply:

Reviewed-by: Sumit Garg sumit.garg@oss.qualcomm.com

-Sumit

diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c index f9ef7d94cebd..a963eed70c1d 100644 --- a/drivers/tee/optee/ffa_abi.c +++ b/drivers/tee/optee/ffa_abi.c @@ -657,7 +657,7 @@ static int optee_ffa_do_call_with_arg(struct tee_context *ctx,

• with a matching configuration.

*/

-static bool optee_ffa_api_is_compatbile(struct ffa_device *ffa_dev, +static bool optee_ffa_api_is_compatible(struct ffa_device *ffa_dev, const struct ffa_ops *ops) { const struct ffa_msg_ops *msg_ops = ops->msg_ops; @@ -908,7 +908,7 @@ static int optee_ffa_probe(struct ffa_device *ffa_dev) ffa_ops = ffa_dev->ops; notif_ops = ffa_ops->notifier_ops;

• if (!optee_ffa_api_is_compatbile(ffa_dev, ffa_ops))

• if (!optee_ffa_api_is_compatible(ffa_dev, ffa_ops)) return -EINVAL;

  if (!optee_ffa_exchange_caps(ffa_dev, ffa_ops, &sec_caps,

-- 2.34.1