Initialize result to 0 so the error path doesn't read it uninitialized when the invoke fails. Fixes a Smatch warning.
Reported-by: Dan Carpenter dan.carpenter@linaro.org Closes: https://lore.kernel.org/op-tee/7c1e0de2-7d42-4c6b-92fe-0e4fe5d650b5@oss.qual... Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver") Signed-off-by: Amirreza Zarrabi amirreza.zarrabi@oss.qualcomm.com --- Changes in v2: - Update subject to tee: qcomtee:. - Link to v1: https://lore.kernel.org/r/20251110-qcom-tee-fix-warning-v1-1-d962f99f385d@os... --- drivers/tee/qcomtee/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tee/qcomtee/core.c b/drivers/tee/qcomtee/core.c index b6715ada7700..ecd04403591c 100644 --- a/drivers/tee/qcomtee/core.c +++ b/drivers/tee/qcomtee/core.c @@ -82,7 +82,7 @@ static void qcomtee_do_release_qtee_object(struct work_struct *work) { struct qcomtee_object *object; struct qcomtee *qcomtee; - int ret, result; + int ret, result = 0;
/* RELEASE does not require any argument. */ struct qcomtee_arg args[] = { { .type = QCOMTEE_ARG_TYPE_INV } };
--- base-commit: ab40c92c74c6b0c611c89516794502b3a3173966 change-id: 20251110-qcom-tee-fix-warning-3d58d74a22d8
Best regards,
On 11/14/25 4:38 AM, Amirreza Zarrabi wrote:
Initialize result to 0 so the error path doesn't read it uninitialized when the invoke fails. Fixes a Smatch warning.
Reported-by: Dan Carpenter dan.carpenter@linaro.org Closes: https://lore.kernel.org/op-tee/7c1e0de2-7d42-4c6b-92fe-0e4fe5d650b5@oss.qual... Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver") Signed-off-by: Amirreza Zarrabi amirreza.zarrabi@oss.qualcomm.com
Reviewed-by: Konrad Dybcio konrad.dybcio@oss.qualcomm.com
Konrad
On Thu, Nov 13, 2025 at 07:38:42PM -0800, Amirreza Zarrabi wrote:
Initialize result to 0 so the error path doesn't read it uninitialized when the invoke fails. Fixes a Smatch warning.
Reported-by: Dan Carpenter dan.carpenter@linaro.org Closes: https://lore.kernel.org/op-tee/7c1e0de2-7d42-4c6b-92fe-0e4fe5d650b5@oss.qual... Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver") Signed-off-by: Amirreza Zarrabi amirreza.zarrabi@oss.qualcomm.com
Changes in v2:
- Update subject to tee: qcomtee:.
- Link to v1: https://lore.kernel.org/r/20251110-qcom-tee-fix-warning-v1-1-d962f99f385d@os...
drivers/tee/qcomtee/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Sumit Garg sumit.garg@oss.qualcomm.com
-Sumit
diff --git a/drivers/tee/qcomtee/core.c b/drivers/tee/qcomtee/core.c index b6715ada7700..ecd04403591c 100644 --- a/drivers/tee/qcomtee/core.c +++ b/drivers/tee/qcomtee/core.c @@ -82,7 +82,7 @@ static void qcomtee_do_release_qtee_object(struct work_struct *work) { struct qcomtee_object *object; struct qcomtee *qcomtee;
- int ret, result;
- int ret, result = 0;
/* RELEASE does not require any argument. */ struct qcomtee_arg args[] = { { .type = QCOMTEE_ARG_TYPE_INV } };
base-commit: ab40c92c74c6b0c611c89516794502b3a3173966 change-id: 20251110-qcom-tee-fix-warning-3d58d74a22d8
Best regards,
Amirreza Zarrabi amirreza.zarrabi@oss.qualcomm.com
On Fri, Nov 14, 2025 at 4:38 AM Amirreza Zarrabi amirreza.zarrabi@oss.qualcomm.com wrote:
Initialize result to 0 so the error path doesn't read it uninitialized when the invoke fails. Fixes a Smatch warning.
Reported-by: Dan Carpenter dan.carpenter@linaro.org Closes: https://lore.kernel.org/op-tee/7c1e0de2-7d42-4c6b-92fe-0e4fe5d650b5@oss.qual... Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver") Signed-off-by: Amirreza Zarrabi amirreza.zarrabi@oss.qualcomm.com
Changes in v2:
- Update subject to tee: qcomtee:.
- Link to v1: https://lore.kernel.org/r/20251110-qcom-tee-fix-warning-v1-1-d962f99f385d@os...
drivers/tee/qcomtee/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I'm picking up this.
Thanks, Jens
diff --git a/drivers/tee/qcomtee/core.c b/drivers/tee/qcomtee/core.c index b6715ada7700..ecd04403591c 100644 --- a/drivers/tee/qcomtee/core.c +++ b/drivers/tee/qcomtee/core.c @@ -82,7 +82,7 @@ static void qcomtee_do_release_qtee_object(struct work_struct *work) { struct qcomtee_object *object; struct qcomtee *qcomtee;
int ret, result;
int ret, result = 0; /* RELEASE does not require any argument. */ struct qcomtee_arg args[] = { { .type = QCOMTEE_ARG_TYPE_INV } };
base-commit: ab40c92c74c6b0c611c89516794502b3a3173966 change-id: 20251110-qcom-tee-fix-warning-3d58d74a22d8
Best regards,
Amirreza Zarrabi amirreza.zarrabi@oss.qualcomm.com
op-tee@lists.trustedfirmware.org