Re: [PATCH v5] tee: optee: prevent use-after-free when the client exits before the supplicant
Hi all,
We can reproduce the reported use-after-free issue on our platform via an overnight reboot test
The verifications are listed as the following
- With v2 + Michael Wu's patch: Issue resolved. - With v4: Race condition observation and already report to Amir - With v5: Race fixed. Stable in our tests, including: xtest + reboot loop (300 cycles) continuous reboot test (1000 cycles)
No regressions observed with v5.
If there are no other concerns, we recommend adopting v5.
If needed, please add the following tag: Tested-by: Ox Yeh ox.yeh@mediatek.com
Yuanjia Yeh
Hi,
On Wed, Feb 25, 2026 at 8:54 AM Yuanjia Yeh yeh.ooxx@gmail.com wrote:
Hi all,
We can reproduce the reported use-after-free issue on our platform via an overnight reboot test
The verifications are listed as the following
With v2 + Michael Wu's patch: Issue resolved.
With v4: Race condition observation and already report to Amir
With v5: Race fixed. Stable in our tests, including: xtest + reboot loop (300 cycles) continuous reboot test (1000 cycles)
No regressions observed with v5.
If there are no other concerns, we recommend adopting v5.
If needed, please add the following tag: Tested-by: Ox Yeh ox.yeh@mediatek.com
Yuanjia Yeh
Thanks for testing. Sumit, with this Tested-by are, you OK with the patch? I've tested it locally and it doesn't break anything for me.
Cheers, Jens
On Mon, Mar 02, 2026 at 01:59:35PM +0100, Jens Wiklander wrote:
Hi,
On Wed, Feb 25, 2026 at 8:54 AM Yuanjia Yeh yeh.ooxx@gmail.com wrote:
Hi all,
We can reproduce the reported use-after-free issue on our platform via an overnight reboot test
The verifications are listed as the following
With v2 + Michael Wu's patch: Issue resolved.
With v4: Race condition observation and already report to Amir
With v5: Race fixed. Stable in our tests, including: xtest + reboot loop (300 cycles) continuous reboot test (1000 cycles)
No regressions observed with v5.
If there are no other concerns, we recommend adopting v5.
If needed, please add the following tag: Tested-by: Ox Yeh ox.yeh@mediatek.com
Yuanjia Yeh
Thanks for testing. Sumit, with this Tested-by are, you OK with the patch? I've tested it locally and it doesn't break anything for me.
Yeah, feel free to add:
Reviewed-by: Sumit Garg sumit.garg@oss.qualcomm.com
-Sumit
On Mon, Mar 2, 2026 at 2:04 PM Sumit Garg sumit.garg@kernel.org wrote:
On Mon, Mar 02, 2026 at 01:59:35PM +0100, Jens Wiklander wrote:
Hi,
On Wed, Feb 25, 2026 at 8:54 AM Yuanjia Yeh yeh.ooxx@gmail.com wrote:
Hi all,
We can reproduce the reported use-after-free issue on our platform via an overnight reboot test
The verifications are listed as the following
With v2 + Michael Wu's patch: Issue resolved.
With v4: Race condition observation and already report to Amir
With v5: Race fixed. Stable in our tests, including: xtest + reboot loop (300 cycles) continuous reboot test (1000 cycles)
No regressions observed with v5.
If there are no other concerns, we recommend adopting v5.
If needed, please add the following tag: Tested-by: Ox Yeh ox.yeh@mediatek.com
Yuanjia Yeh
Thanks for testing. Sumit, with this Tested-by are, you OK with the patch? I've tested it locally and it doesn't break anything for me.
Yeah, feel free to add:
Reviewed-by: Sumit Garg sumit.garg@oss.qualcomm.com
Thanks, I'm picking up this.
Cheers, Jens
op-tee@lists.trustedfirmware.org
-
Jens Wiklander -
Sumit Garg -
Yuanjia Yeh