On 4/28/2025 9:41 AM, Jens Wiklander wrote:
On Mon, Apr 28, 2025 at 4:30 PM Mario Limonciello superm1@kernel.org wrote:
On 4/28/2025 9:27 AM, Jens Wiklander wrote:
Hi,
On Mon, Apr 21, 2025 at 5:22 PM Mario Limonciello superm1@kernel.org wrote:
From: Mario Limonciello mario.limonciello@amd.com
I just noticed a few small things for amdtee where the error messages didn't consistently use the driver name. While fixing that I noticed the headers weren't sorted.
These patches fix both issues.
Mario Limonciello (2): tee: Use pr_fmt for messages tee: Sort header includes
drivers/tee/amdtee/core.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)
I'm trying to build this, but I run into some selinux build error. How did you build this?
I used kworkflow (kw b). It was based off linux-next at the time I submitted it.
I wasn't aware of kworkflow. I'm usually building manually locally or with tuxbuild.
Can you share your .config? Is it a defconfig?
It's defconfig + CONFIG_CRYPTO_DEV_CCP=y to get AMDTEE enabled. If you have an easier way, please let me know.
Let me pull the tee tree directly and try again with that tree and I'll see if I can reproduce the build error.
The error is: security/selinux/nlmsgtab.c: In function ‘selinux_nlmsg_lookup’: security/selinux/nlmsgtab.c:188:33: error: ‘NETLINK_ROUTE_SOCKET__NLMSG’ undeclared (first use in this function); did you mean ‘NETLINK_ROUTE_SOCKET__LOCK’? 188 | *perm = NETLINK_ROUTE_SOCKET__NLMSG;
Cheers, Jens
Hmm, I couldn't reproduce. I did defconfig + CONFIG_AMDTEE=m
Here's your tree I based it from (tee/next):
9d172b0d7150c (HEAD) tee: Sort header includes 931240733ee67 tee: Use pr_fmt for messages 34e4aaeff2a84 (tee/next) Merge branch 'tee_for_v6_16' into next 26104d8156737 tee: optee: smc: remove unnecessary NULL check before release_firmware() 8ffd015db85fe (tag: v6.15-rc2, tip/x86/platform) Linux 6.15-rc2
I also tried with this successfully.
❯ make drivers/tee/amdtee/ -j16 W=1 CC [M] drivers/tee/amdtee/core.o CC [M] drivers/tee/amdtee/call.o CC [M] drivers/tee/amdtee/shm_pool.o LD [M] drivers/tee/amdtee/amdtee.o