Re: [PATCH v3 1/7] remoteproc: Add TEE support

On 2/14/2024 10:51 PM, Arnaud Pouliquen wrote:

From: Arnaud Pouliquen arnaud.pouliquen@st.com

Add a remoteproc TEE (Trusted Execution Environment) driver that will be probed by the TEE bus. If the associated Trusted application is supported on secure part this device offers a client interface to load a firmware in the secure part. This firmware could be authenticated and decrypted by the secure trusted application.

Signed-off-by: Arnaud Pouliquen arnaud.pouliquen@st.com

<...>

+};

+static struct tee_rproc__context *tee_rproc_ctx;

+static void prepare_args(struct tee_rproc *trproc, int cmd,

• 	 struct tee_ioctl_invoke_arg *arg,
  

• 	 struct tee_param *param, unsigned int num_params)
  

s/prepare_args/tee_rproc_prepare_args ?

please align function args in nextline with (. Eg: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/driv...

+{

• memset(arg, 0, sizeof(*arg));
• memset(param, 0, MAX_TEE_PARAM_ARRY_MEMBER * sizeof(*param));
• arg->func = cmd;

Regards, Naman Jain