Re: [PATCH v2 1/3] rpmb: add Replay Protected Memory Block (RPMB) subsystem

On Wed, Jan 31, 2024 at 06:43:45PM +0100, Jens Wiklander wrote:

+struct class rpmb_class = {

This structure should be marked as 'const', right?

• .name = "rpmb",
• .dev_release = rpmb_dev_release,

+}; +EXPORT_SYMBOL(rpmb_class);

EXPORT_SYMBOL_GPL() to match all the other exports in this file please.

thanks,

greg k-h