On Thu, Mar 12, 2026 at 12:16:11PM +0100, Jens Wiklander wrote:
On Thu, Mar 12, 2026 at 10:16 AM Sumit Garg sumit.garg@kernel.org wrote:
On Fri, Mar 06, 2026 at 12:52:39PM +0100, Markus Elfring wrote:
…
+++ b/drivers/tee/optee/rpc.c @@ -393,6 +393,11 @@ static void handle_rpc_func_rpmb_frames(struct tee_context *ctx, params[0].u.memref.shm_offs); p1 = tee_shm_get_va(params[1].u.memref.shm, params[1].u.memref.shm_offs);
- if (IS_ERR(p0) || IS_ERR(p1)) {
arg->ret = TEEC_ERROR_BAD_PARAMETERS;goto out;- }
- if (rpmb_route_frames(rdev, p0, params[0].u.memref.size, p1, params[1].u.memref.size)) { arg->ret = TEEC_ERROR_BAD_PARAMETERS;
…
How do you think about to use an additional label for the shown error code assignment? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu...
I suppose here you meant to update the label name since it's the same error type used by other code paths too. So following label rename should be fine I think as per coding guidelines:
s/out/err_dev_put/
Wouldn't the name err_dev_put suggest this only occurs in the error path?
Okay, let rather rename it to out_dev_put.
-Sumit