-----Original Message----- From: Jens Wiklander jens.wiklander@linaro.org Sent: Tuesday, August 13, 2024 3:13 PM To: Greg Kroah-Hartman gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org; linux-mmc@vger.kernel.org; op- tee@lists.trustedfirmware.org; Ulf Hansson ulf.hansson@linaro.org; Shyam Saini shyamsaini@linux.microsoft.com; Linus Walleij linus.walleij@linaro.org; Jerome Forissier jerome.forissier@linaro.org; Sumit Garg sumit.garg@linaro.org; Ilias Apalodimas ilias.apalodimas@linaro.org; Bart Van Assche bvanassche@acm.org; Randy Dunlap rdunlap@infradead.org; Ard Biesheuvel ardb@kernel.org; Arnd Bergmann arnd@arndb.de; Manuel Traut manut@mecka.net; Mikko Rapeli mikko.rapeli@linaro.org; Winkler, Tomas tomas.winkler@intel.com; Alex Bennée alex.bennee@linaro.org Subject: Re: [PATCH v8 1/4] rpmb: add Replay Protected Memory Block (RPMB) subsystem
On Tue, Aug 13, 2024 at 1:36 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Tue, Aug 13, 2024 at 01:26:18PM +0200, Jens Wiklander wrote:
On Tue, Aug 13, 2024 at 11:29 AM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Mon, Aug 12, 2024 at 03:31:24PM +0200, Jens Wiklander wrote:
--- /dev/null +++ b/drivers/misc/rpmb-core.c @@ -0,0 +1,233 @@ +// SPDX-License-Identifier: GPL-2.0
Fine, but:
--- /dev/null +++ b/include/linux/rpmb.h @@ -0,0 +1,136 @@ +/* SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0 */
Really?
Why? I need lots of documentation and a lawyer sign off for why this is a dual license for a file that is obviously only for internal Linux kernel stuff.
I'm sorry that was added via one of the patch sets before mine. I'll revert to GPL-2.0 only.
Please be sure to get proper legal approval to change the license of code not written by you :)
The dual license was introduced in https://lore.kernel.org/lkml/20220405093759.1126835-2- alex.bennee@linaro.org/, but https://lore.kernel.org/linux-mmc/1478548394-8184-2-git-send-email- tomas.winkler@intel.com/ uses GPL-2.0 only. So reverting to GPL-2.0 only should be OK, don't you agree?
Ack.