Re: [PATCH v8 1/4] KEYS: trusted: Add generic trusted keys framework

On Wed, 10 Feb 2021 at 22:30, Jarkko Sakkinen jarkko@kernel.org wrote:

On Tue, Nov 03, 2020 at 09:31:43PM +0530, Sumit Garg wrote:

...

• case Opt_new:
  

•         key_len = payload->key_len;
  

•         ret = static_call(trusted_key_get_random)(payload->key,
  

•                                                   key_len);
  

•         if (ret != key_len) {
  

•                 pr_info("trusted_key: key_create failed (%d)\n", ret);
  

•                 goto out;
  

•         }
  

This repeats a regression in existing code, i.e. does not check "ret < 0" condition. I noticed this now when I rebased the code on top of my fixes.

I.e. it's fixed in my master branch, which caused a merge conflict, and I found this.

Okay, I will rebase the next version to your master branch.

-Sumit

/Jarkko