On 6/8/22 8:52 AM, Eugene Syromiatnikov wrote:
On Mon, Apr 25, 2022 at 09:16:17AM -0500, Andrew Davis wrote:
These look to be leftover from an early edition of this driver. Userspace does not need this information. Checking all users of this that I have access to I have verified no one is using them.
This change has broken build of strace's test suite against the latest kernel headers[1]; the usage prety much shows up in the Debian's code search[2].
[1] https://github.com/strace/strace/runs/6794205205?check_suite_focus=true#step... [2] https://codesearch.debian.net/search?q=TEE_IOCTL_SHM_MAPPED+package%3A%5CQst...
Thanks for the headsup, I've sent a patch to fix strace tests.
Andrew
They leak internal use flags out to userspace. Even more they are not correct anymore after a45ea4efa358. Lets drop these flags before someone does try to use them for something and they become ABI.