On 22/07/2020 17:35, Gilles Peskine via mbed-tls wrote:

I just need to warn you that the limiting factor is reviewers' time. For a significant contribution, it may take a while before the Mbed TLS team can look at it in detail. Small patches are usually easier than large ones: if something only takes half an hour to review, someone will probably do it when they're stuck on some other task. If a review takes several days, it needs to be scheduled.

As an aside, Mbed TLS is under the governance of TrustedFirmware. Currently, only Arm employees are consider trusted reviewers, but this is not by policy, it's only due to the history of the project (until a few months ago, Mbed TLS was governed by Arm). We (as in, the Arm employees working on Mbed TLS) welcome design and code reviews from everyone.

We don't yet have a formal process for becoming a “trusted” reviewer, beyond the general principles of TrustedFirmware. But a required part of that process will undoubtedly be to have done some reviews before.

As every project, there is an informal, unwritten culture. If there's interest, we can try to document our review culture in writing. If I had to sum it up in one sentence, I'd say that if a reviewer should reject code that they don't understand: it's the job of the patch author to convince reviewers that the patch is good. “I don't see anything wrong” is not a good enough standard.