Helló János!

Yes I tried that one (and plenty of other stuff). Finally I just reset the branch and recommited the changes solving this particular issue. Unfortunately I had to create a new PR, because git did not let me reopen it, but that is another topic.

Thank you for the help!

BR, Gábor

Janos Follath Janos.Follath@arm.com ezt írta (időpont: 2021. febr. 22., H, 13:17):

Hi Gábor,

Have you tried running `git commit --amend` (without --no-edit --signoff) and adding the “Signed-off-by: toth92g toth92g@gmail.com" line by hand?

Best regards,

Janos

*From: *Gábor Tóth toth92g@gmail.com *Date: *Monday, 22 February 2021 at 11:44 *To: *Janos Follath Janos.Follath@arm.com *Subject: *Re: [mbed-tls] Failing signoff (DCO) on: https://github.com/ARMmbed/mbedtls/pull/4140

Helló János!

Yes, I know which one, but I do not know how to change the commit message in git. I have used the provided commands (amend), but it did not correct the error.

Do you know how to change it manually?

BR,

Gábor

Janos Follath Janos.Follath@arm.com ezt írta (időpont: 2021. febr. 22., H, 12:38):

Hi Gábor,

If you click on the “details” link on the DCO check it will tell you which commits are missing the sign-off:

https://github.com/ARMmbed/mbedtls/pull/4140/checks?check_run_id=1950600200

In this case you have one commit that is not signed off:

https://github.com/ARMmbed/mbedtls/pull/4140/commits/fdd3c65ee47ab80f69cfa4e...

Best regards,

Janos

*From: *mbed-tls mbed-tls-bounces@lists.trustedfirmware.org on behalf of Gábor Tóth via mbed-tls mbed-tls@lists.trustedfirmware.org *Date: *Monday, 22 February 2021 at 11:05 *To: *mbed-tls@lists.trustedfirmware.org < mbed-tls@lists.trustedfirmware.org> *Subject: *[mbed-tls] Failing signoff (DCO) on: https://github.com/ARMmbed/mbedtls/pull/4140

Hello Guys!

I know it is a newbie question, but I am not able to pass this freaking DCO test...I have used the provided commands to signoff all the commits and as I see all of them has signoff, but it still failes on one. Do you have any idea what's wrong or how could I correct it?

Till now I was able to correct it, but now it seems to be bugged.

Thank you!

BR? Gábor

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.