That's weird, I haven't seen that before. Running either kokoro/build.sh or 'make checkpatch' locally works for me, whether or not CHECKPATCH is set.

The Makefile in the root directory is setting CHECKPATCH unconditionally, but it looks like the one under drive/linux uses the existing value if there is one. Maybe we should change that?

What error do you get when CHECKPATCH is not set?

On Fri, 15 May 2020 at 18:18, Olivier Deprez via Hafnium < hafnium@lists.trustedfirmware.org> wrote:

Hi,

Is there a known problem around checkpatch when running kokoro/build.sh locally?

I noticed if CHECKPATCH env variable is already set then kokoro/build.sh fails with:

• export CROSS_COMPILE=aarch64-linux-gnu-
• CROSS_COMPILE=aarch64-linux-gnu-
• cd driver/linux
• make HAFNIUM_PATH=/home/olidep01/WORK/hafnium-upstream checkpatch

<my-own-checkpatch-dir>/checkpatch.pl -f main.c Must be run from the top-level dir. of a kernel tree Makefile:43: recipe for target 'checkpatch' failed make: *** [checkpatch] Error 2

If I unset CHECKPATCH before running build.sh then it fails at the driver/linux check.

Is this something known and/or needing fix?

Regards, Olivier. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -- Hafnium mailing list Hafnium@lists.trustedfirmware.org https://lists.trustedfirmware.org/mailman/listinfo/hafnium